Enable 'getter-setter-error' flag in 3.9

TEST=existing

Change-Id: Ic4a5735adda7cf8ef1565b9356ca277d9b62b064
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/430720
Reviewed-by: Johnni Winther <[email protected]>
Reviewed-by: Alexander Markov <[email protected]>
Reviewed-by: Michael Thomsen <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>

Author: chloestefantsova

pkg/_fe_analyzer_shared/lib/src/experiments/flags.dart

@@ -96,10 +96,10 @@ enum ExperimentalFlag {
 
   getterSetterError(
       name: 'getter-setter-error',
-      isEnabledByDefault: false,
+      isEnabledByDefault: true,
       isExpired: false,
-      experimentEnabledVersion: defaultLanguageVersion,
-      experimentReleasedVersion: defaultLanguageVersion),
+      experimentEnabledVersion: const Version(3, 9),
+      experimentReleasedVersion: const Version(3, 9)),
 
   inferenceUpdate1(
       name: 'inference-update-1',

pkg/analyzer/lib/src/dart/analysis/experiments.g.dart

@@ -326,7 +326,7 @@ class ExperimentalFeatures {
     documentation:
         'Stop reporting errors about mismatching types in a getter/setter pair.',
     experimentalReleaseVersion: null,
-    releaseVersion: null,
+    releaseVersion: Version.parse('3.9.0'),
     channels: ["stable", "beta", "dev", "main"],
   );
 
@@ -663,7 +663,7 @@ class IsEnabledByDefault {
   static const bool generic_metadata = true;
 
   /// Default state of the experiment "getter-setter-error"
-  static const bool getter_setter_error = false;
+  static const bool getter_setter_error = true;
 
   /// Default state of the experiment "inference-update-1"
   static const bool inference_update_1 = true;

pkg/analyzer/test/src/dart/analysis/analysis_context_collection_test.dart

@@ -406,6 +406,7 @@ analysisOptions
       enhanced-enums
       extension-methods
       generic-metadata
+      getter-setter-error
       inference-update-1
       inference-update-2
       inference-update-3
@@ -486,6 +487,7 @@ analysisOptions
       enhanced-enums
       extension-methods
       generic-metadata
+      getter-setter-error
       inference-update-1
       inference-update-2
       inference-update-3