[linter] Follow-up clean up for lint name and code generation

- Add `.g` suffix to generated filenames and export from the base file.
- Rename `linter_lint_codes.dart` to just `lint_codes.dart` for simplicity.
- Export `lint_codes.dart` from `src/analyzer.dart` to avoid importing it in every rule file, as they all need it.
- Use pre-existing/shared `generateAll` method for generation.
- Add some explanatory docs and comments.

Bug: #56835
Change-Id: I605e39156bfcc5e3c19a01157426d26300eb877d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388058
Reviewed-by: Brian Wilkerson <[email protected]>
Auto-Submit: Parker Lougheed <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Phil Quitslund <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>

Author: parlough

pkg/analysis_server/lib/src/services/correction/dart/add_diagnostic_property_reference.dart

@@ -15,8 +15,8 @@ import 'package:analyzer_plugin/utilities/assist/assist.dart';
 import 'package:analyzer_plugin/utilities/change_builder/change_builder_core.dart';
 import 'package:analyzer_plugin/utilities/change_builder/change_builder_dart.dart';
 import 'package:analyzer_plugin/utilities/fixes/fixes.dart';
+import 'package:linter/src/lint_codes.dart';
 import 'package:linter/src/lint_names.dart';
-import 'package:linter/src/linter_lint_codes.dart';
 
 class AddDiagnosticPropertyReference extends ResolvedCorrectionProducer {
   AddDiagnosticPropertyReference({required super.context});

pkg/analysis_server/lib/src/services/correction/dart/remove_comparison.dart

@@ -12,7 +12,7 @@ import 'package:analyzer/src/error/codes.g.dart';
 import 'package:analyzer_plugin/utilities/change_builder/change_builder_core.dart';
 import 'package:analyzer_plugin/utilities/fixes/fixes.dart';
 import 'package:analyzer_plugin/utilities/range_factory.dart';
-import 'package:linter/src/linter_lint_codes.dart';
+import 'package:linter/src/lint_codes.dart';
 
 class RemoveComparison extends ResolvedCorrectionProducer {
   @override

pkg/analysis_server/lib/src/services/correction/dart/replace_with_decorated_box.dart

@@ -11,7 +11,7 @@ import 'package:analyzer/src/lint/linter.dart';
 import 'package:analyzer_plugin/utilities/change_builder/change_builder_core.dart';
 import 'package:analyzer_plugin/utilities/fixes/fixes.dart';
 import 'package:analyzer_plugin/utilities/range_factory.dart';
-import 'package:linter/src/linter_lint_codes.dart';
+import 'package:linter/src/lint_codes.dart';
 
 class ReplaceWithDecoratedBox extends ResolvedCorrectionProducer {
   ReplaceWithDecoratedBox({required super.context});

pkg/analysis_server/lib/src/services/correction/fix_internal.dart

@@ -247,7 +247,7 @@ import 'package:analyzer/error/error.dart';
 import 'package:analyzer/src/dart/error/ffi_code.g.dart';
 import 'package:analyzer/src/error/codes.dart';
 import 'package:analyzer/src/generated/parser.dart';
-import 'package:linter/src/linter_lint_codes.dart';
+import 'package:linter/src/lint_codes.dart';
 
 final _builtInLintMultiProducers = {
   LinterLintCode.comment_references: [

pkg/analyzer/test/generated/error_suppression_test.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:analyzer/src/error/codes.dart';
-import 'package:linter/src/linter_lint_codes.dart';
+import 'package:linter/src/lint_codes.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 
 import '../src/dart/resolution/context_collection_resolution.dart';

pkg/analyzer/test/src/dart/micro/simple_file_resolver_test.dart

@@ -11,7 +11,7 @@ import 'package:analyzer/src/dart/error/syntactic_errors.dart';
 import 'package:analyzer/src/dart/micro/resolve_file.dart';
 import 'package:analyzer/src/dart/micro/utils.dart';
 import 'package:analyzer/src/error/codes.dart';
-import 'package:linter/src/linter_lint_codes.dart';
+import 'package:linter/src/lint_codes.dart';
 import 'package:test/test.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 

pkg/linter/lib/src/analyzer.dart

@@ -33,6 +33,7 @@ export 'package:analyzer/src/lint/util.dart' show FileSpelunker;
 export 'package:analyzer/src/utilities/extensions/ast.dart';
 export 'package:analyzer/src/workspace/pub.dart' show PubPackage;
 
+export 'lint_codes.dart';
 export 'lint_names.dart';
 
 const loggedAnalyzerErrorExitCode = 63;

pkg/linter/lib/src/lint_codes.dart

@@ -0,0 +1,5 @@
+// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+export 'lint_codes.g.dart' show LinterLintCode;

pkg/linter/lib/src/linter_lint_codes.dart renamed to pkg/linter/lib/src/lint_codes.g.dart

@@ -5,7 +5,7 @@
 // THIS FILE IS GENERATED. DO NOT EDIT.
 //
 // Instead modify 'pkg/linter/messages.yaml' and run
-// 'dart run pkg/linter/tool/codes/generate.dart' to update.
+// 'dart run pkg/linter/tool/generate_lints.dart' to update.
 
 // We allow some snake_case and SCREAMING_SNAKE_CASE identifiers in generated
 // code, as they match names declared in the source configuration files.
@@ -1954,6 +1954,9 @@ class LinterLintCode extends LintCode {
     hasPublishedDocs: true,
   );
 
+  /// A lint code that removed lints can specify as their `lintCode`.
+  ///
+  /// Avoid other usages as it should be made unnecessary and removed.
   static const LintCode removed_lint = LinterLintCode(
     'removed_lint',
     'Removed lint.',