linter: remove unused ignoreSyntheticNodes parameter

This parameter was used once in one lint rule, and otherwise seems like
it was designed for testing, but does not need to be used in either
place.

Change-Id: I95af78a1c69c945b467ed3cb51e9e3a7d7c81491
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423902
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: srawlins

pkg/analyzer/lib/src/lint/linter.dart

@@ -256,9 +256,8 @@ abstract class LintRule {
     List<Object> arguments = const [],
     List<DiagnosticMessage>? contextMessages,
     ErrorCode? errorCode,
-    bool ignoreSyntheticNodes = true,
   }) {
-    if (node != null && (!node.isSynthetic || !ignoreSyntheticNodes)) {
+    if (node != null && !node.isSynthetic) {
       reporter.atNode(
         node,
         errorCode ?? lintCode,
@@ -289,9 +288,8 @@ abstract class LintRule {
     List<Object> arguments = const [],
     List<DiagnosticMessage>? contextMessages,
     ErrorCode? errorCode,
-    bool ignoreSyntheticTokens = true,
   }) {
-    if (token != null && (!token.isSynthetic || !ignoreSyntheticTokens)) {
+    if (token != null && !token.isSynthetic) {
       reporter.atToken(
         token,
         errorCode ?? lintCode,

pkg/analyzer/test/src/lint/lint_rule_test.dart

@@ -27,9 +27,8 @@ main() {
         rule.reporter = reporter;
 
         rule.reportLintForToken(
-          Token.eof(0),
+          SimpleToken(TokenType.SEMICOLON, 0),
           errorCode: customCode,
-          ignoreSyntheticTokens: false,
         );
         expect(reporter.code, customCode);
       });
@@ -41,7 +40,7 @@ main() {
         );
         rule.reporter = reporter;
 
-        rule.reportLintForToken(Token.eof(0), ignoreSyntheticTokens: false);
+        rule.reportLintForToken(SimpleToken(TokenType.SEMICOLON, 0));
         expect(reporter.code, rule.lintCode);
       });
       test('reportLint (custom)', () {

pkg/linter/lib/src/rules/specify_nonobvious_local_variable_types.dart

@@ -79,7 +79,7 @@ class _Visitor extends SimpleAstVisitor<void> {
       if (iterable.hasObviousType) {
         return;
       }
-      rule.reportLint(loopParts.loopVariable, ignoreSyntheticNodes: false);
+      rule.reportLint(loopParts.loopVariable);
     }
   }