Fine. Make ManifestType generative constructors private, make encode() factory constructors.

Change-Id: Id8416b46c43c6d62fa7d5326c9ab017cfbc127b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420180
Reviewed-by: Paul Berry <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/fine/manifest_context.dart

@@ -39,14 +39,10 @@ class EncodeContext {
       _typeParameters[typeParameter] = _typeParameters.length;
     }
 
-    var encoded = <ManifestTypeParameter>[];
-    for (var typeParameter in typeParameters) {
-      encoded.add(
-        ManifestTypeParameter(
-          bound: typeParameter.bound?.encode(this),
-        ),
-      );
-    }
+    var encoded = <ManifestTypeParameter>[
+      for (var typeParameter in typeParameters)
+        ManifestTypeParameter.encode(this, typeParameter)
+    ];
 
     try {
       return operation(encoded);