analyzer: Check deprecated member use on DotShorthandInvocation

Change-Id: Ie8cdb4f3b063cb8a5fdd2486ced421d481339f31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/451662
Reviewed-by: Kallen Tu <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: srawlins

pkg/analyzer/lib/src/error/best_practices_verifier.dart

@@ -374,8 +374,9 @@ class BestPracticesVerifier extends RecursiveAstVisitor<void> {
   @override
   void visitDotShorthandInvocation(DotShorthandInvocation node) {
     _deprecatedFunctionalityVerifier.dotShorthandInvocation(node);
-    // TODO(srawlins): I imagine we need to check with
-    // `_deprecatedMemberUseVerifier` here...
+    for (var v in _elementUsageFrontierDetectors) {
+      v.dotShorthandInvocation(node);
+    }
     super.visitDotShorthandInvocation(node);
   }
 

pkg/analyzer/lib/src/error/element_usage_detector.dart

@@ -131,6 +131,10 @@ class ElementUsageDetector<TagInfo extends Object> {
     _invocationArguments(node.constructorName.element, node.argumentList);
   }
 
+  void dotShorthandInvocation(DotShorthandInvocation node) {
+    _invocationArguments(node.memberName.element, node.argumentList);
+  }
+
   void exportDirective(ExportDirective node) {
     checkUsage(node.libraryExport?.exportedLibrary, node);
   }

pkg/analyzer/test/src/diagnostics/deprecated_member_use_test.dart

@@ -13,10 +13,10 @@ import '../dart/resolution/context_collection_resolution.dart';
 
 main() {
   defineReflectiveSuite(() {
-    defineReflectiveTests(DeprecatedMemberUse_PackageConfigWorkspaceTest);
     defineReflectiveTests(DeprecatedMemberUse_BlazeWorkspaceTest);
     defineReflectiveTests(DeprecatedMemberUse_GnWorkspaceTest);
     defineReflectiveTests(DeprecatedMemberUse_PackageBuildWorkspaceTest);
+    defineReflectiveTests(DeprecatedMemberUse_PackageConfigWorkspaceTest);
   });
 }
 
@@ -551,6 +551,29 @@ void f() {
     );
   }
 
+  test_dotShorthandInvocation_deprecatedMethod() async {
+    newFile('$workspaceRootPath/aaa/lib/a.dart', r'''
+class A {
+  @deprecated
+  static A m() => A();
+}
+''');
+
+    await assertErrorsInCode(
+      r'''
+import 'package:aaa/a.dart';
+
+void f() {
+  A a = .m();
+}
+''',
+      [
+        error(WarningCode.unusedLocalVariable, 45, 1),
+        error(HintCode.deprecatedMemberUse, 50, 1),
+      ],
+    );
+  }
+
   test_export() async {
     newFile('$workspaceRootPath/aaa/lib/a.dart', r'''
 @deprecated