[element model] migrate visit_registered_nodes

Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I0772342d6e18109d3ce162048bba857f93d139b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/390261
Auto-Submit: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

Author: pq

pkg/linter/analyzer_use_new_elements.txt

@@ -25,6 +25,7 @@ lib/src/rules/avoid_function_literals_in_foreach_calls.dart
 lib/src/rules/avoid_implementing_value_types.dart
 lib/src/rules/avoid_js_rounded_ints.dart
 lib/src/rules/avoid_multiple_declarations_per_line.dart
+lib/src/rules/avoid_null_checks_in_equality_operators.dart
 lib/src/rules/avoid_print.dart
 lib/src/rules/avoid_private_typedef_functions.dart
 lib/src/rules/avoid_relative_lib_imports.dart
@@ -105,6 +106,7 @@ lib/src/rules/prefer_conditional_assignment.dart
 lib/src/rules/prefer_const_constructors.dart
 lib/src/rules/prefer_const_declarations.dart
 lib/src/rules/prefer_const_literals_to_create_immutables.dart
+lib/src/rules/prefer_constructors_over_static_methods.dart
 lib/src/rules/prefer_contains.dart
 lib/src/rules/prefer_double_quotes.dart
 lib/src/rules/prefer_equal_for_default_values.dart
@@ -132,6 +134,7 @@ lib/src/rules/pub/depend_on_referenced_packages.dart
 lib/src/rules/pub/package_names.dart
 lib/src/rules/pub/secure_pubspec_urls.dart
 lib/src/rules/pub/sort_pub_dependencies.dart
+lib/src/rules/recursive_getters.dart
 lib/src/rules/require_trailing_commas.dart
 lib/src/rules/sized_box_for_whitespace.dart
 lib/src/rules/sized_box_shrink_expand.dart
@@ -227,7 +230,6 @@ test/rules/avoid_implementing_value_types_test.dart
 test/rules/avoid_init_to_null_test.dart
 test/rules/avoid_js_rounded_ints_test.dart
 test/rules/avoid_multiple_declarations_per_line_test.dart
-test/rules/avoid_null_checks_in_equality_operators_test.dart
 test/rules/avoid_positional_boolean_parameters_test.dart
 test/rules/avoid_print_test.dart
 test/rules/avoid_private_typedef_functions_test.dart
@@ -460,6 +462,7 @@ tool/checks/check_messages_yaml.dart
 tool/checks/driver.dart
 tool/checks/rules/no_solo_tests.dart
 tool/checks/rules/no_trailing_spaces.dart
+tool/checks/rules/visit_registered_nodes.dart
 tool/generate_lints.dart
 tool/labeler/issue_config.dart
 tool/labeler/pr_config.dart

pkg/linter/tool/checks/rules/visit_registered_nodes.dart

@@ -4,7 +4,7 @@
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
-import 'package:analyzer/dart/element/element.dart';
+import 'package:analyzer/dart/element/element2.dart';
 import 'package:analyzer/dart/element/type.dart';
 import 'package:linter/src/analyzer.dart';
 
@@ -28,44 +28,41 @@ class VisitRegisteredNodes extends LintRule {
   @override
   void registerNodeProcessors(
       NodeLintRegistry registry, LinterContext context) {
-    var visitor = _Visitor(this);
+    var visitor = _Visitor(this, context.inheritanceManager);
     registry.addMethodDeclaration(this, visitor);
   }
 }
 
 class _BodyVisitor extends RecursiveAstVisitor<void> {
   final LintRule rule;
-  _BodyVisitor(this.rule);
+  final InheritanceManager3 inheritanceManager;
+  _BodyVisitor(this.rule, this.inheritanceManager);
 
-  bool implements(ClassElement visitor, String methodName) {
-    if (visitor.getMethod(methodName) != null) {
-      return true;
-    }
-
-    var method =
-        visitor.lookUpInheritedConcreteMethod(methodName, visitor.library);
+  bool implements(ClassElement2 visitor, String methodName) {
+    var member = inheritanceManager.getMember4(visitor, Name(null, methodName),
+        concrete: true);
     // In general lint visitors should only inherit from SimpleAstVisitors
     // (and the method implementations inherited from there are only stubs).
     // (We might consider enforcing this since it's harder to ensure that
     // Unifying and Generalizing visitors are doing the right thing.)
     // For now we flag methods inherited from SimpleAstVisitor since they
     // surely don't do anything.
-    return method?.enclosingElement3.name != 'SimpleAstVisitor';
+    return member?.enclosingElement2?.name != 'SimpleAstVisitor';
   }
 
   @override
   void visitMethodInvocation(MethodInvocation node) {
     var targetType = node.target?.staticType;
     if (targetType is! InterfaceType) return;
-    if (targetType.element.name != 'NodeLintRegistry') return;
+    if (targetType.element3.name != 'NodeLintRegistry') return;
     var methodName = node.methodName.name;
     if (!methodName.startsWith('add')) return;
     var nodeType = methodName.substring(3);
     var args = node.argumentList.arguments;
     var argType = args[1].staticType;
     if (argType is! InterfaceType) return;
-    var visitor = argType.element;
-    if (visitor is! ClassElement) return;
+    var visitor = argType.element3;
+    if (visitor is! ClassElement2) return;
     if (implements(visitor, 'visit$nodeType')) return;
 
     rule.reportLint(node.methodName);
@@ -74,13 +71,14 @@ class _BodyVisitor extends RecursiveAstVisitor<void> {
 
 class _Visitor extends SimpleAstVisitor<void> {
   final LintRule rule;
+  final InheritanceManager3 inheritanceManager;
 
-  _Visitor(this.rule);
+  _Visitor(this.rule, this.inheritanceManager);
 
   @override
   void visitMethodDeclaration(MethodDeclaration node) {
     if (node.name.lexeme == 'registerNodeProcessors') {
-      node.body.accept(_BodyVisitor(rule));
+      node.body.accept(_BodyVisitor(rule, inheritanceManager));
     }
   }
 }