Skip to content

Commit 722929d

Browse files
fishythefishCommit Queue
authored andcommitted
[dart2js] Clean up wrapper powerset implementation.
This was a very useful experiment to validate that a powerset domain could answer certain abstract value domain queries more efficiently. Now that the core ideas have been incorporated directly into the typemasks, we no longer need to preserve the wrappers. Change-Id: Ife3df6eeb119783da97eeb721d9c045e5da649ca Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/427020 Commit-Queue: Mayank Patke <[email protected]> Reviewed-by: Stephen Adams <[email protected]>
1 parent 553ac95 commit 722929d

File tree

10 files changed

+0
-2787
lines changed

10 files changed

+0
-2787
lines changed

pkg/compiler/lib/src/commandline_options.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,6 @@ class Flags {
3636
static const String experimentalTrackAllocations =
3737
'--experimental-track-allocations';
3838

39-
static const String experimentalWrapped = '--experimental-wrapped';
40-
static const String experimentalPowersets = '--experimental-powersets';
41-
4239
// Temporary experiment for code generation of locals for frequently used
4340
// 'this' and constants.
4441
static const String experimentLocalNames = '--experiment-code-1';

pkg/compiler/lib/src/compiler.dart

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,10 @@ import 'environment.dart';
4242
import 'inferrer/abstract_value_domain.dart';
4343
import 'inferrer/abstract_value_strategy.dart';
4444
import 'inferrer/computable.dart' show ComputableAbstractValueStrategy;
45-
import 'inferrer/powersets/powersets.dart' show PowersetStrategy;
4645
import 'inferrer/trivial.dart' show TrivialAbstractValueStrategy;
4746
import 'inferrer/typemasks/masks.dart' show TypeMaskStrategy;
4847
import 'inferrer/types.dart'
4948
show GlobalTypeInferenceResults, GlobalTypeInferenceTask;
50-
import 'inferrer/wrapped.dart' show WrappedAbstractValueStrategy;
5149
import 'io/source_information.dart';
5250
import 'js_backend/codegen_inputs.dart' show CodegenInputs;
5351
import 'js_backend/enqueuer.dart';
@@ -165,13 +163,6 @@ class Compiler {
165163
options.useTrivialAbstractValueDomain
166164
? const TrivialAbstractValueStrategy()
167165
: const TypeMaskStrategy();
168-
if (options.experimentalWrapped || options.testMode) {
169-
abstractValueStrategy = WrappedAbstractValueStrategy(
170-
abstractValueStrategy,
171-
);
172-
} else if (options.experimentalPowersets) {
173-
abstractValueStrategy = PowersetStrategy(abstractValueStrategy);
174-
}
175166
if (options.debugGlobalInference) {
176167
abstractValueStrategy = ComputableAbstractValueStrategy(
177168
abstractValueStrategy,

pkg/compiler/lib/src/dart2js.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -486,8 +486,6 @@ Future<api.CompilationResult> compile(
486486
_OneOption(Flags.stopAfterProgramSplit, passThrough),
487487
_OneOption(Flags.disableTypeInference, passThrough),
488488
_OneOption(Flags.useTrivialAbstractValueDomain, passThrough),
489-
_OneOption(Flags.experimentalWrapped, passThrough),
490-
_OneOption(Flags.experimentalPowersets, passThrough),
491489
_OneOption(Flags.disableRtiOptimization, passThrough),
492490
_OneOption(Flags.terse, passThrough),
493491
_OneOption('--deferred-map=.+', passThrough),

0 commit comments

Comments
 (0)