Skip to content

Commit 72acd9d

Browse files
srujzsCommit Queue
authored andcommitted
[dart:svg] Add value->newLength parameter name change to templates
https://dart-review.googlesource.com/c/sdk/+/372522 renamed some parameters but the template files did not include the change, so they'd get replaced when we regenerate the web libraries. This change includes some other places where we should use newLength as well. Change-Id: I93b5a5da381dd2d1347769287467f2c174fe07aa CoreLibraryReviewExempt: Fixes a bug in the generation of web libraries. Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401043 Reviewed-by: Samuel Rawlins <[email protected]> Commit-Queue: Srujan Gaddam <[email protected]>
1 parent 57c4da6 commit 72acd9d

File tree

4 files changed

+21
-21
lines changed

4 files changed

+21
-21
lines changed

sdk/lib/html/dart2js/html_dart2js.dart

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -11837,7 +11837,7 @@ class DomRectList extends JavaScriptObject
1183711837
// -- start List<Rectangle> mixins.
1183811838
// Rectangle is the element type.
1183911839

11840-
set length(int value) {
11840+
set length(int newLength) {
1184111841
throw new UnsupportedError("Cannot resize immutable List.");
1184211842
}
1184311843

@@ -12093,7 +12093,7 @@ class DomStringList extends JavaScriptObject
1209312093
// -- start List<String> mixins.
1209412094
// String is the element type.
1209512095

12096-
set length(int value) {
12096+
set length(int newLength) {
1209712097
throw new UnsupportedError("Cannot resize immutable List.");
1209812098
}
1209912099

@@ -16755,7 +16755,7 @@ class FileList extends JavaScriptObject
1675516755
// -- start List<File> mixins.
1675616756
// File is the element type.
1675716757

16758-
set length(int value) {
16758+
set length(int newLength) {
1675916759
throw new UnsupportedError("Cannot resize immutable List.");
1676016760
}
1676116761

@@ -18325,7 +18325,7 @@ class HtmlCollection extends JavaScriptObject
1832518325
// -- start List<Node> mixins.
1832618326
// Node is the element type.
1832718327

18328-
set length(int value) {
18328+
set length(int newLength) {
1832918329
throw new UnsupportedError("Cannot resize immutable List.");
1833018330
}
1833118331

@@ -22894,7 +22894,7 @@ class MimeTypeArray extends JavaScriptObject
2289422894
// -- start List<MimeType> mixins.
2289522895
// MimeType is the element type.
2289622896

22897-
set length(int value) {
22897+
set length(int newLength) {
2289822898
throw new UnsupportedError("Cannot resize immutable List.");
2289922899
}
2290022900

@@ -23982,7 +23982,7 @@ class _ChildNodeListLazy extends ListBase<Node> implements NodeListWrapper {
2398223982
// a local copy of childNodes is more efficient.
2398323983
int get length => _this.childNodes.length;
2398423984

23985-
set length(int value) {
23985+
set length(int newLength) {
2398623986
throw new UnsupportedError("Cannot set length on immutable List.");
2398723987
}
2398823988

@@ -24438,7 +24438,7 @@ class NodeList extends JavaScriptObject
2443824438
// -- start List<Node> mixins.
2443924439
// Node is the element type.
2444024440

24441-
set length(int value) {
24441+
set length(int newLength) {
2444224442
throw new UnsupportedError("Cannot resize immutable List.");
2444324443
}
2444424444

@@ -26626,7 +26626,7 @@ class PluginArray extends JavaScriptObject
2662626626
// -- start List<Plugin> mixins.
2662726627
// Plugin is the element type.
2662826628

26629-
set length(int value) {
26629+
set length(int newLength) {
2663026630
throw new UnsupportedError("Cannot resize immutable List.");
2663126631
}
2663226632

@@ -29403,7 +29403,7 @@ class SourceBufferList extends EventTarget
2940329403
// -- start List<SourceBuffer> mixins.
2940429404
// SourceBuffer is the element type.
2940529405

29406-
set length(int value) {
29406+
set length(int newLength) {
2940729407
throw new UnsupportedError("Cannot resize immutable List.");
2940829408
}
2940929409

@@ -29562,7 +29562,7 @@ class SpeechGrammarList extends JavaScriptObject
2956229562
// -- start List<SpeechGrammar> mixins.
2956329563
// SpeechGrammar is the element type.
2956429564

29565-
set length(int value) {
29565+
set length(int newLength) {
2956629566
throw new UnsupportedError("Cannot resize immutable List.");
2956729567
}
2956829568

@@ -31284,7 +31284,7 @@ class TextTrackCueList extends JavaScriptObject
3128431284
// -- start List<TextTrackCue> mixins.
3128531285
// TextTrackCue is the element type.
3128631286

31287-
set length(int value) {
31287+
set length(int newLength) {
3128831288
throw new UnsupportedError("Cannot resize immutable List.");
3128931289
}
3129031290

@@ -31358,7 +31358,7 @@ class TextTrackList extends EventTarget
3135831358
// -- start List<TextTrack> mixins.
3135931359
// TextTrack is the element type.
3136031360

31361-
set length(int value) {
31361+
set length(int newLength) {
3136231362
throw new UnsupportedError("Cannot resize immutable List.");
3136331363
}
3136431364

@@ -31628,7 +31628,7 @@ class TouchList extends JavaScriptObject
3162831628
// -- start List<Touch> mixins.
3162931629
// Touch is the element type.
3163031630

31631-
set length(int value) {
31631+
set length(int newLength) {
3163231632
throw new UnsupportedError("Cannot resize immutable List.");
3163331633
}
3163431634

@@ -35713,7 +35713,7 @@ class _CssRuleList extends JavaScriptObject
3571335713
// -- start List<CssRule> mixins.
3571435714
// CssRule is the element type.
3571535715

35716-
set length(int value) {
35716+
set length(int newLength) {
3571735717
throw new UnsupportedError("Cannot resize immutable List.");
3571835718
}
3571935719

@@ -36030,7 +36030,7 @@ class _GamepadList extends JavaScriptObject
3603036030
// -- start List<Gamepad?> mixins.
3603136031
// Gamepad? is the element type.
3603236032

36033-
set length(int value) {
36033+
set length(int newLength) {
3603436034
throw new UnsupportedError("Cannot resize immutable List.");
3603536035
}
3603636036

@@ -36308,7 +36308,7 @@ class _NamedNodeMap extends JavaScriptObject
3630836308
// -- start List<Node> mixins.
3630936309
// Node is the element type.
3631036310

36311-
set length(int value) {
36311+
set length(int newLength) {
3631236312
throw new UnsupportedError("Cannot resize immutable List.");
3631336313
}
3631436314

@@ -36502,7 +36502,7 @@ class _SpeechRecognitionResultList extends JavaScriptObject
3650236502
// -- start List<SpeechRecognitionResult> mixins.
3650336503
// SpeechRecognitionResult is the element type.
3650436504

36505-
set length(int value) {
36505+
set length(int newLength) {
3650636506
throw new UnsupportedError("Cannot resize immutable List.");
3650736507
}
3650836508

@@ -36562,7 +36562,7 @@ class _StyleSheetList extends JavaScriptObject
3656236562
// -- start List<StyleSheet> mixins.
3656336563
// StyleSheet is the element type.
3656436564

36565-
set length(int value) {
36565+
set length(int newLength) {
3656636566
throw new UnsupportedError("Cannot resize immutable List.");
3656736567
}
3656836568

sdk/lib/web_sql/dart2js/web_sql_dart2js.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ class SqlResultSetRowList extends JavaScriptObject
255255
// -- start List<Map> mixins.
256256
// Map is the element type.
257257

258-
set length(int value) {
258+
set length(int newLength) {
259259
throw new UnsupportedError("Cannot resize immutable List.");
260260
}
261261

tools/dom/templates/html/dart2js/immutable_list_mixin.darttemplate

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ $if DEFINE_LENGTH_AS_NUM_ITEMS
77
$endif
88

99
$if DEFINE_LENGTH_SETTER
10-
set length(int value) {
10+
set length(int newLength) {
1111
throw new UnsupportedError("Cannot resize immutable List.");
1212
}
1313
$endif

tools/dom/templates/html/impl/impl_Node.darttemplate

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ class _ChildNodeListLazy extends ListBase<Node> implements NodeListWrapper {
163163
// a local copy of childNodes is more efficient.
164164
int get length => _this.childNodes.length;
165165

166-
set length(int value) {
166+
set length(int newLength) {
167167
throw new UnsupportedError(
168168
"Cannot set length on immutable List.");
169169
}

0 commit comments

Comments
 (0)