[tests] Dot shorthands: == and parenthesized expression tests.

A few extra tests for parenthesized dot shorthands on the RHS of an == or !=.

Bug: #57038
Change-Id: I2400247ea7017feff676090c5131822e0b17d5e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/424680
Reviewed-by: Erik Ernst <[email protected]>
Commit-Queue: Kallen Tu <[email protected]>

Author: kallentu

tests/language/dot_shorthands/equality/equality_ctor_error_test.dart

@@ -209,6 +209,20 @@ void rhsNeedsToBeShorthand(
   // [analyzer] unspecified
   // [cfe] No type was provided to find the dot shorthand 'constRegular'.
 
+  if (ctor == (.new(1))) {
+    //          ^^^
+    // [analyzer] unspecified
+    // [cfe] No type was provided to find the dot shorthand 'new'.
+    print('not ok');
+  }
+
+  if (ctor != (.new(1))) {
+    //          ^^^
+    // [analyzer] unspecified
+    // [cfe] No type was provided to find the dot shorthand 'new'.
+    print('not ok');
+  }
+
   if (ctor == (condition ? .new(1) : .regular(1))) {
     //                      ^^^
     // [analyzer] unspecified

tests/language/dot_shorthands/equality/equality_error_test.dart

@@ -151,6 +151,16 @@ void rhsNeedsToBeShorthand(Color color, Integer integer, IntegerExt integerExt,
   // [analyzer] unspecified
   // [cfe] unspecified
 
+  if (color == (.red)) print('not ok');
+  // ^
+  // [analyzer] unspecified
+  // [cfe] unspecified
+
+  if (color != (.red)) print('not ok');
+  // ^
+  // [analyzer] unspecified
+  // [cfe] unspecified
+
   if (color == (condition ? .red : .green)) print('not ok');
   // ^
   // [analyzer] unspecified

tests/language/dot_shorthands/equality/equality_member_error_test.dart

@@ -96,6 +96,20 @@ void rhsNeedsToBeShorthand(
   StaticMemberExt memberExt,
   bool condition,
 ) {
+  if (member == (.member())) {
+    //            ^^^^^^
+    // [analyzer] unspecified
+    // [cfe] No type was provided to find the dot shorthand 'member'.
+    print('not ok');
+  }
+
+  if (member != (.member())) {
+    //            ^^^^^^
+    // [analyzer] unspecified
+    // [cfe] No type was provided to find the dot shorthand 'member'.
+    print('not ok');
+  }
+
   if (member == (condition ? .member() : .memberType<String, int>('s'))) {
     //                        ^^^^^^
     // [analyzer] unspecified

tests/language/dot_shorthands/equality/equality_selector_chain_error_test.dart

@@ -178,6 +178,20 @@ void rhsNeedsToBeShorthand(
   ConstructorWithNonFinal ctor,
   bool condition,
 ) {
+  if (member == (.member().field)) {
+    //            ^^^^^^
+    // [analyzer] unspecified
+    // [cfe] No type was provided to find the dot shorthand 'member'.
+    print('not ok');
+  }
+
+  if (member == (.member().method())) {
+    //            ^^^^^^
+    // [analyzer] unspecified
+    // [cfe] No type was provided to find the dot shorthand 'member'.
+    print('not ok');
+  }
+
   if (member == (condition ? StaticMember.member() : .member().field)) {
     //                                                ^^^^^^
     // [analyzer] unspecified