[gardening] Clean up fuchsia build for IsolateGroup shared callbacks.

Follow-up to 50e0e0d

TEST=ci

Change-Id: I48114f5677a010561638fedf37390479885c8eef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/427041
Commit-Queue: Alexander Aprelev <[email protected]>
Reviewed-by: Ryan Macnak <[email protected]>

Author: aam

BUILD.gn

@@ -309,7 +309,6 @@ if (is_fuchsia) {
     "tests/ffi/inline_array_test.dart",
     "tests/ffi/inline_array_variable_length_test.dart",
     "tests/ffi/invoke_callback_after_suspension_test.dart",
-    "tests/ffi/isolate_group_shared_callback_test.dart",
     "tests/ffi/isolate_local_function_callbacks_test.dart",
     "tests/ffi/msan_test.dart",
     "tests/ffi/native_assets/asset_absolute_test.dart",

runtime/vm/compiler/stub_code_compiler_arm64.cc

@@ -622,7 +622,7 @@ void StubCodeCompiler::GenerateFfiCallbackTrampolineStub() {
 #if defined(DART_TARGET_OS_FUCHSIA)
     // TODO(https://dartbug.com/52579): Remove.
     if (FLAG_precompiled_mode) {
-      GenerateLoadBSSEntry(BSS::Relocation::DRT_ExitIsolateGroupSharedIsolate,
+      GenerateLoadBSSEntry(BSS::Relocation::DLRT_ExitIsolateGroupSharedIsolate,
                            R4, R9);
     } else {
       Label call;

runtime/vm/compiler/stub_code_compiler_x64.cc

@@ -576,7 +576,7 @@ void StubCodeCompiler::GenerateFfiCallbackTrampolineStub() {
 #if defined(DART_TARGET_OS_FUCHSIA)
     // TODO(https://dartbug.com/52579): Remove.
     if (FLAG_precompiled_mode) {
-      GenerateLoadBSSEntry(BSS::Relocation::DRT_ExitIsolateGroupSharedIsolate,
+      GenerateLoadBSSEntry(BSS::Relocation::DLRT_ExitIsolateGroupSharedIsolate,
                            RAX, TMP);
     } else {
       __ movq(RAX, Immediate(reinterpret_cast<int64_t>(

tests/ffi/ffi.status

@@ -59,6 +59,7 @@ function_callbacks_many_test/*: Skip # Test harness doesn't support multitest wi
 function_callbacks_structs_by_value_generated_test/*: Skip # Test harness doesn't support multitest with Fuchsia
 function_callbacks_structs_by_value_native_callable_generated_test/*: Skip # Test harness doesn't support multitest with Fuchsia
 function_callbacks_subtype_test/*: Skip # Test harness doesn't support multitest with Fuchsia
+isolate_group_shared_callback_test: Skip # gen_snapshot requires experimental-shared-data flag
 native_assets/*: Skip # Source not available in the emulator
 run_isolate_group_run_test: Skip # gen_snapshot requires experimental-shared-data flag
 static_checks/*: SkipByDesign # Expecting compile time failures in multi tests doesn't work on the Fuchsia test runner.