Elements. Deprecate FragmentImpl.name

Next I will remove it completely.
And instead require `name2` as the constructor formal parameter.

Change-Id: Ib4afac3266fe36a7299d60a8b6d87c99349dd64c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/432125
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Paul Berry <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analysis_server/lib/src/lsp/mapping.dart

@@ -537,7 +537,7 @@ lsp.Location? fragmentToLocation(
   ) when isSynthetic) {
     var element = nonSynthetic;
     nameOffset = element.nameOffset.nullIfNegative;
-    nameLength = element.name?.length;
+    nameLength = element.name2?.length;
   } else {
     nameOffset = fragment.nameOffset2;
     nameLength = fragment.name2?.length;

pkg/analysis_server/lib/src/services/completion/dart/utilities.dart

@@ -15,7 +15,6 @@ import 'package:analyzer/dart/element/nullability_suffix.dart';
 import 'package:analyzer/dart/element/type.dart';
 import 'package:analyzer/source/source.dart';
 import 'package:analyzer/src/utilities/extensions/flutter.dart';
-import 'package:analyzer/src/utilities/extensions/string.dart';
 import 'package:analyzer_plugin/protocol/protocol_common.dart'
     as protocol
     show Element, ElementKind;
@@ -183,7 +182,7 @@ DefaultArgument? getDefaultStringParameterValue(
     var params = type.formalParameters.indexed
         .map((r) {
           var (index, parameter) = r;
-          var name = parameter.displayName.ifNotEmptyOrElse('p${index + 1}');
+          var name = parameter.name3 ?? 'p${index + 1}';
           return '${getTypeString(parameter.type)}$name';
         })
         .join(', ');

pkg/analysis_server/test/src/services/correction/fix/make_return_type_nullable_test.dart

@@ -3,7 +3,6 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:analysis_server/src/services/correction/fix.dart';
-import 'package:analyzer/src/error/codes.dart';
 import 'package:analyzer_plugin/utilities/fixes/fixes.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 
@@ -87,24 +86,6 @@ class C {
 ''');
   }
 
-  /// This code is parsed in such a way that we find `void` as an `Expression`.
-  /// But this expression is a name in a `NamedType`, and so `NamedType` has
-  /// the `type`, but not `void` - its type is `null`. So, the producer should
-  /// check for `null`, and don't expect that every expression has a type.
-  Future<void> test_getter_sync_invalidVoid() async {
-    await resolveTestCode('''
-int f() {
-  return void;
-}
-''');
-    await assertNoFix(
-      errorFilter:
-          (e) =>
-              e.errorCode ==
-              CompileTimeErrorCode.RETURN_OF_INVALID_TYPE_FROM_FUNCTION,
-    );
-  }
-
   Future<void> test_incompatibilityIsNotLimitedToNullability() async {
     await resolveTestCode('''
 int f() {

pkg/analyzer/lib/src/dart/ast/ast.dart

@@ -6408,7 +6408,7 @@ final class DeclaredVariablePatternImpl extends VariablePatternImpl
       context,
       this,
       declaredElement2!,
-      declaredFragment!.name,
+      declaredFragment!.name2 ?? '',
       type?.typeOrThrow.wrapSharedTypeView(),
     );
     declaredElement2!.type = result.staticType.unwrapTypeView();

pkg/analyzer/lib/src/dart/constant/evaluation.dart

@@ -229,10 +229,10 @@ class ConstantEvaluationEngine {
     if (constant is ConstFieldFragmentImpl && constant.isEnumConstant) {
       var enclosing = constant.enclosingElement3;
       if (enclosing is EnumFragmentImpl) {
-        if (enclosing.name == 'values') {
+        if (enclosing.name2 == 'values') {
           return;
         }
-        if (constant.name == enclosing.name) {
+        if (constant.name2 == enclosing.name2) {
           return;
         }
       }
@@ -490,7 +490,7 @@ class ConstantEvaluationEngine {
       if (enum_ is EnumFragmentImpl) {
         var index = enum_.constants.indexOf(element);
         assert(index >= 0);
-        return _EnumConstant(index: index, name: element.name);
+        return _EnumConstant(index: index, name: element.name2 ?? '');
       }
     }
     return null;
@@ -2875,7 +2875,7 @@ class _InstanceCreationEvaluator {
   Constant evaluateFactoryConstructorCall(List<Expression> arguments) {
     var definingClass = _constructor.asElement2.enclosingElement;
     var argumentCount = arguments.length;
-    if (_constructor.name == "fromEnvironment") {
+    if (_constructor.name2 == "fromEnvironment") {
       if (!_checkFromEnvironmentArguments(arguments, definingType)) {
         return InvalidConstant.forEntity(
           entity: _errorNode,
@@ -2908,14 +2908,14 @@ class _InstanceCreationEvaluator {
           _declaredVariables,
         ).getString2(variableName, _namedValues, _constructor.asElement2);
       }
-    } else if (_constructor.name == 'hasEnvironment' &&
+    } else if (_constructor.name2 == 'hasEnvironment' &&
         definingClass == typeProvider.boolElement2) {
       var name = argumentCount < 1 ? null : firstArgument?.toStringValue();
       return FromEnvironmentEvaluator(
         typeSystem,
         _declaredVariables,
       ).hasEnvironment(name);
-    } else if (_constructor.name == "" &&
+    } else if (_constructor.name2 == 'new' &&
         definingClass == typeProvider.symbolElement2 &&
         argumentCount == 1) {
       if (!_checkSymbolArguments(arguments)) {
@@ -2993,7 +2993,7 @@ class _InstanceCreationEvaluator {
             SimpleIdentifierImpl(
                 token: StringToken(
                   TokenType.STRING,
-                  parameter.name,
+                  parameter.name2 ?? '',
                   parameter.nameOffset,
                 ),
               )
@@ -3008,7 +3008,7 @@ class _InstanceCreationEvaluator {
                 label: SimpleIdentifierImpl(
                   token: StringToken(
                     TokenType.STRING,
-                    parameter.name,
+                    parameter.name2 ?? '',
                     parameter.nameOffset,
                   ),
                 )..element = parameter.asElement2,
@@ -3051,13 +3051,13 @@ class _InstanceCreationEvaluator {
                 CompileTimeErrorCode.CONST_CONSTRUCTOR_FIELD_TYPE_MISMATCH,
             arguments: [
               fieldValue.type.getDisplayString(),
-              field.name,
+              field.name2 ?? '',
               fieldType.getDisplayString(),
             ],
             isRuntimeException: isRuntimeException,
           );
         }
-        _fieldMap[field.name] = fieldValue;
+        _fieldMap[field.name2 ?? ''] = fieldValue;
       }
     }
     return null;
@@ -3326,8 +3326,8 @@ class _InstanceCreationEvaluator {
       DartObjectImpl? argumentValue;
       AstNode? errorTarget;
       if (baseParameter.isNamed) {
-        argumentValue = _namedValues[baseParameter.name];
-        errorTarget = _namedNodes[baseParameter.name];
+        argumentValue = _namedValues[baseParameter.name2 ?? ''];
+        errorTarget = _namedNodes[baseParameter.name2 ?? ''];
       } else if (i < _argumentValues.length) {
         argumentValue = _argumentValues[i];
         errorTarget = arguments[i];
@@ -3392,7 +3392,7 @@ class _InstanceCreationEvaluator {
                 );
               }
             }
-            var fieldName = field.name;
+            var fieldName = field.name2 ?? '';
             if (_fieldMap.containsKey(fieldName)) {
               return InvalidConstant.forEntity(
                 entity: _errorNode,
@@ -3403,7 +3403,7 @@ class _InstanceCreationEvaluator {
             _fieldMap[fieldName] = argumentValue;
           }
         }
-        _parameterMap[baseParameter.name] = argumentValue;
+        _parameterMap[baseParameter.name2 ?? ''] = argumentValue;
       }
     }
     return null;

pkg/analyzer/lib/src/dart/element/display_string_builder.dart

@@ -37,11 +37,11 @@ class ElementDisplayStringBuilder {
   String toString() => _buffer.toString();
 
   void writeAbstractElement(FragmentImpl element) {
-    _write(element.name ?? '<unnamed $runtimeType>');
+    _write(element.name2 ?? '<unnamed ${element.runtimeType}>');
   }
 
   void writeAbstractElement2(ElementImpl2 element) {
-    _write(element.name3 ?? '<unnamed $runtimeType>');
+    _write(element.name3 ?? '<unnamed ${element.runtimeType}>');
   }
 
   void writeClassElement(ClassFragmentImpl element) {
@@ -162,7 +162,7 @@ class ElementDisplayStringBuilder {
     _write('(');
     _writeType(element.representation.type);
     _write(' ');
-    _write(element.representation.name);
+    _write(element.representation.name2 ?? '<null-name}>');
     _write(')');
 
     _writeTypesIfNotEmpty(' implements ', element.interfaces);