DAS: Tidy uses of isOriginDeclaration

Just some switch expression opportunities.

Change-Id: Ida87e1e65773bb5b481c40549a7b13c5605eade2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/465967
Auto-Submit: Samuel Rawlins <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: srawlins

pkg/analysis_server/lib/src/services/refactoring/legacy/rename_unit_member.dart

@@ -127,25 +127,13 @@ class RenameUnitMemberRefactoringImpl extends RenameRefactoringImpl {
 
   @override
   Future<void> fillChange() async {
-    // prepare elements
-    var elements = <Element>[];
-    switch (element) {
-      case PropertyInducingElement element:
-        if (element.isOriginGetterSetter) {
-          var getter = element.getter;
-          var setter = element.setter;
-          if (getter != null) {
-            elements.add(getter);
-          }
-          if (setter != null) {
-            elements.add(setter);
-          }
-        } else {
-          elements.add(element);
-        }
-      default:
-        elements.add(element);
-    }
+    var elements = switch (element) {
+      PropertyInducingElement element when element.isOriginGetterSetter => [
+        ?element.getter,
+        ?element.setter,
+      ],
+      _ => [element],
+    };
 
     // Rename each element and references to it.
     var processor = RenameProcessor(workspace, sessionHelper, change, newName);

pkg/analysis_server/lib/src/status/utilities/element_writer.dart

@@ -134,15 +134,12 @@ class ElementWriter with TreeWriter {
   void _writeElement(Element element) {
     indent();
 
-    var showItalic = false;
-    switch (element) {
-      case ConstructorElement():
-        showItalic = !element.isOriginDeclaration;
-      case PropertyAccessorElement():
-        showItalic = !element.isOriginDeclaration;
-      case PropertyInducingElement():
-        showItalic = !element.isOriginDeclaration;
-    }
+    var showItalic = switch (element) {
+      ConstructorElement() => !element.isOriginDeclaration,
+      PropertyAccessorElement() => !element.isOriginDeclaration,
+      PropertyInducingElement() => !element.isOriginDeclaration,
+      _ => false,
+    };
 
     if (showItalic) {
       buffer.write('<i>');