[analysis_server] Fix preservation of strings when indenting code

When code indentation is replaced, strings should not be updated. This loop had inverted logic which meant that after processing a string before the current line, we would then exit early and not look at the subsequent string ranges (which we might be a match for).

Fixes #60951

Change-Id: I1a94ca05e968bb7f2193544779b2634b784f8aee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/435580
Commit-Queue: Keerti Parthasarathy <[email protected]>
Reviewed-by: Keerti Parthasarathy <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: DanTup

pkg/analysis_server_plugin/lib/edit/correction_utils.dart

@@ -299,8 +299,11 @@ final class CorrectionUtils {
       for (var lineRange in lineRanges) {
         if (lineOffset > lineRange.offset && lineOffset < lineRange.end) {
           inString = true;
+          break;
         }
-        if (lineOffset > lineRange.end) {
+        // We can skip the rest if this line ends before the end of this range
+        // because subsequent ranges are after it.
+        if (lineOffset < lineRange.end) {
           break;
         }
       }

pkg/analysis_server_plugin/test/edit/correction_utils_test.dart

@@ -138,6 +138,41 @@ void f(bool? b4, bool? b5) {
     );
   }
 
+  Future<void> test_replaceSourceIndent_multipleStrings() async {
+    // Test multiple strings because the issue
+    // https://github.com/dart-lang/sdk/issues/60951 was related to only the
+    // first being processed correctly.
+    await assertReplacedIndentation(
+      includeLeading: true,
+      indentOld: '',
+      indentNew: '  ',
+      r'''
+var i = 0;
+var x = '';
+var y = """
+0 indent
+ 1 indent
+  2 indent
+ 1 indent
+0 indent
+""";
+var j = 1;
+''',
+      r'''
+  var i = 0;
+  var x = '';
+  var y = """
+0 indent
+ 1 indent
+  2 indent
+ 1 indent
+0 indent
+""";
+  var j = 1;
+''',
+    );
+  }
+
   Future<void> test_replaceSourceIndent_noLeading_empty_crlf() async {
     await assertReplacedIndentation(
       indentOld: '',