Elements. Remove 'get identifier' from ElementImpl and FragmentImpl.

We used it to construct `ElementLocation`, and we already removed it.

Change-Id: Ie88ba3aae24f094c6eb2c5b656cc64398e5ba91b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/437360
Reviewed-by: Paul Berry <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/element/element.dart

@@ -4,7 +4,6 @@
 
 import 'dart:collection';
 
-import 'package:_fe_analyzer_shared/src/scanner/string_canonicalizer.dart';
 import 'package:_fe_analyzer_shared/src/type_inference/type_analyzer.dart'
     as shared;
 import 'package:_fe_analyzer_shared/src/type_inference/type_analyzer_operations.dart'
@@ -2043,17 +2042,6 @@ abstract class ElementImpl implements Element {
     ];
   }
 
-  /// Return an identifier that uniquely identifies this element among the
-  /// children of this element's parent.
-  String get identifier {
-    var identifier = name3!;
-    // TODO(augmentations): Figure out how to get a unique identifier. In the
-    //  old model we sometimes used the offset of the name to disambiguate
-    //  between elements, but we can't do that anymore because the name can
-    //  appear at multiple offsets.
-    return considerCanonicalizeString(identifier);
-  }
-
   @override
   bool get isPrivate {
     var name3 = this.name3;
@@ -3884,18 +3872,6 @@ abstract class FragmentImpl implements FragmentOrMember {
     return enclosingElement3!.enclosingUnit;
   }
 
-  /// Return an identifier that uniquely identifies this element among the
-  /// children of this element's parent.
-  String get identifier {
-    var identifier = name2 ?? '';
-
-    if (_includeNameOffsetInIdentifier) {
-      identifier += "@$nameOffset";
-    }
-
-    return considerCanonicalizeString(identifier);
-  }
-
   bool get isNonFunctionTypeAliasesEnabled {
     return library!.featureSet.isEnabled(Feature.nonfunction_type_aliases);
   }
@@ -4343,9 +4319,6 @@ class GenericFunctionTypeFragmentImpl extends _ExistingFragmentImpl
   @override
   List<FormalParameterFragmentImpl> get formalParameters => parameters;
 
-  @override
-  String get identifier => '-';
-
   @override
   ElementKind get kind => ElementKind.GENERIC_FUNCTION_TYPE;
 
@@ -4625,9 +4598,6 @@ abstract class InstanceElementImpl extends ElementImpl
   @override
   List<GetterElementImpl> get getters2 => getters;
 
-  @override
-  String get identifier => name3 ?? firstFragment.identifier;
-
   @override
   bool get isPrivate => firstFragment.isPrivate;
 
@@ -6123,7 +6093,7 @@ class LibraryElementImpl extends ElementImpl
   }
 
   @override
-  String get identifier => '${definingCompilationUnit.source.uri}';
+  String get identifier => '$uri';
 
   @override
   bool get isDartAsync => name == "dart.async";
@@ -6652,9 +6622,6 @@ class LibraryFragmentImpl extends _ExistingFragmentImpl
   @override
   int get hashCode => source.hashCode;
 
-  @override
-  String get identifier => '${source.uri}';
-
   @override
   List<LibraryElement> get importedLibraries2 {
     return libraryImports2
@@ -7286,11 +7253,6 @@ class LocalVariableFragmentImpl extends NonParameterVariableFragmentImpl
     enclosingElement3 = value as FragmentImpl;
   }
 
-  @override
-  String get identifier {
-    return '$name2$nameOffset';
-  }
-
   @override
   bool get isLate {
     return hasModifier(Modifier.LATE);
@@ -8964,13 +8926,6 @@ sealed class PropertyAccessorFragmentImpl extends ExecutableFragmentImpl
     throw UnsupportedError('Not a fragment: ${enclosing.runtimeType}');
   }
 
-  @override
-  String get identifier {
-    String name = displayName;
-    String suffix = isGetter ? "?" : "=";
-    return considerCanonicalizeString("$name$suffix");
-  }
-
   /// Set whether this class is abstract.
   set isAbstract(bool isAbstract) {
     setModifier(Modifier.ABSTRACT, isAbstract);

pkg/analyzer/lib/src/error/dead_code_verifier.dart

@@ -158,7 +158,7 @@ class DeadCodeVerifier extends RecursiveAstVisitor<void> {
         _diagnosticReporter.atNode(
           name,
           warningCode,
-          arguments: [library.identifier, nameStr],
+          arguments: ['${library.uri}', nameStr],
         );
       }
     }