Remove two underused methods from ResourceProviderMixin

Change-Id: I41f288f216e7db5a744d10a38074e104321e49f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/429220
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: srawlins

pkg/analysis_server/test/analysis_server_base.dart

@@ -276,12 +276,20 @@ class PubPackageAnalysisServerTest extends ContextResolutionTest
     );
   }
 
+  /// Deletes the analysis options YAML file at [testPackageRootPath].
   void deleteTestPackageAnalysisOptionsFile() {
-    deleteAnalysisOptionsYamlFile(testPackageRootPath);
+    var path = join(testPackageRootPath, file_paths.analysisOptionsYaml);
+    deleteFile(path);
   }
 
+  /// Deletes the `package_config.json` file at [testPackageRootPath].
   void deleteTestPackageConfigJsonFile() {
-    deletePackageConfigJsonFile(testPackageRootPath);
+    var filePath = join(
+      testPackageRootPath,
+      file_paths.dotDartTool,
+      file_paths.packageConfigJson,
+    );
+    deleteFile(filePath);
   }
 
   /// Returns the offset of [search] in [testFileContent].

pkg/analyzer_testing/api.txt

@@ -29,10 +29,8 @@ package:analyzer_testing/resource_provider_mixin.dart:
     pathContext (getter: Context)
     resourceProvider (getter: ResourceProvider)
     convertPath (method: String Function(String))
-    deleteAnalysisOptionsYamlFile (method: void Function(String))
     deleteFile (method: void Function(String))
     deleteFolder (method: void Function(String))
-    deletePackageConfigJsonFile (method: void Function(String))
     fromUri (method: String Function(Uri))
     getFile (method: File Function(String))
     getFolder (method: Folder Function(String))

pkg/analyzer_testing/lib/resource_provider_mixin.dart

@@ -35,12 +35,6 @@ mixin ResourceProviderMixin {
   /// path context.
   String convertPath(String filePath) => resourceProvider.convertPath(filePath);
 
-  /// Deletes the analysis options YAML file at [directoryPath].
-  void deleteAnalysisOptionsYamlFile(String directoryPath) {
-    var path = join(directoryPath, file_paths.analysisOptionsYaml);
-    deleteFile(path);
-  }
-
   /// Deletes the file at [path].
   void deleteFile(String path) {
     resourceProvider.getFile(convertPath(path)).delete();
@@ -51,16 +45,6 @@ mixin ResourceProviderMixin {
     resourceProvider.getFolder(convertPath(path)).delete();
   }
 
-  /// Deletes the `package_config.json` file at [directoryPath].
-  void deletePackageConfigJsonFile(String directoryPath) {
-    var path = join(
-      directoryPath,
-      file_paths.dotDartTool,
-      file_paths.packageConfigJson,
-    );
-    deleteFile(path);
-  }
-
   /// Returns [uri] as a String.
   String fromUri(Uri uri) {
     return resourceProvider.pathContext.fromUri(uri);

pkg/linter/lib/src/rules/switch_on_type.dart

@@ -22,9 +22,6 @@ class SwitchOnType extends LintRule {
   @override
   DiagnosticCode get diagnosticCode => LinterLintCode.switch_on_type;
 
-  @override
-  LintCode get lintCode => LinterLintCode.switch_on_type;
-
   @override
   void registerNodeProcessors(
     NodeLintRegistry registry,