DAS: Rename constants in code_completion tool to use lowerCamelCase

Change-Id: I993d9386c63766471dd8d5ae7f1e63f3f9bf8ce3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/459844
Auto-Submit: Samuel Rawlins <[email protected]>
Reviewed-by: Keerti Parthasarathy <[email protected]>
Commit-Queue: Keerti Parthasarathy <[email protected]>

Author: srawlins

pkg/analysis_server/tool/code_completion/completion_metrics.dart

@@ -153,7 +153,7 @@ ArgParser createArgParser() {
     )
     ..addFlag('help', abbr: 'h', help: 'Print this help message.')
     ..addOption(
-      CompletionMetricsOptions.OVERLAY,
+      CompletionMetricsOptions.overlayOption,
       allowed: [
         OverlayMode.none.flag,
         OverlayMode.removeRestOfFile.flag,
@@ -167,38 +167,38 @@ ArgParser createArgParser() {
           'complete at the start of the token without modifying the file.',
     )
     ..addOption(
-      CompletionMetricsOptions.PREFIX_LENGTH,
+      CompletionMetricsOptions.prefixLengthOption,
       defaultsTo: '0',
       help:
           'The number of characters to include in the prefix. Each '
           'completion will be requested this many characters in from the '
           'start of the token being completed.',
     )
     ..addFlag(
-      CompletionMetricsQualityOptions.PRINT_MISSED_COMPLETION_DETAILS,
+      CompletionMetricsQualityOptions._printMissedCompletionDetails,
       help:
           'Print detailed information every time a completion request fails '
           'to produce a suggestions matching the expected suggestion.',
       negatable: false,
     )
     ..addFlag(
-      CompletionMetricsQualityOptions.PRINT_MISSED_COMPLETION_SUMMARY,
+      CompletionMetricsQualityOptions._printMissedCompletionSummary,
       help:
           'Print summary information about the times that a completion '
           'request failed to produce a suggestions matching the expected '
           'suggestion.',
       negatable: false,
     )
     ..addFlag(
-      CompletionMetricsQualityOptions.PRINT_MISSING_INFORMATION,
+      CompletionMetricsQualityOptions._printMissingInformation,
       help:
           'Print information about places where no completion location was '
           'computed and about information that is missing in the completion '
           'tables.',
       negatable: false,
     )
     ..addFlag(
-      CompletionMetricsQualityOptions.PRINT_MRR_BY_LOCATION,
+      CompletionMetricsQualityOptions._printMrrByLocation,
       help:
           'Print information about the mrr score achieved at each completion '
           'location. This can help focus efforts to improve the overall '
@@ -207,22 +207,22 @@ ArgParser createArgParser() {
       negatable: false,
     )
     ..addFlag(
-      CompletionMetricsQualityOptions.PRINT_SHADOWED_COMPLETION_DETAILS,
+      CompletionMetricsQualityOptions._printShadowedCompletionDetails,
       help:
           'Print detailed information every time a completion request '
           'produces a suggestion whose name matches the expected suggestion '
           'but that is referencing a different element',
       negatable: false,
     )
     ..addFlag(
-      CompletionMetricsOptions.PRINT_SLOWEST_RESULTS,
+      CompletionMetricsOptions.printSlowestResultsFlag,
       help:
           'Print information about the completion requests that were the '
           'slowest to return suggestions.',
       negatable: false,
     )
     ..addFlag(
-      CompletionMetricsQualityOptions.PRINT_WORST_RESULTS,
+      CompletionMetricsQualityOptions._printWorstResults,
       help:
           'Print information about the completion requests that had the '
           'worst mrr scores.',
@@ -691,34 +691,34 @@ class CompletionMetricsQualityOptions extends CompletionMetricsOptions {
   /// A flag that causes detailed information to be printed every time a
   /// completion request fails to produce a suggestions matching the expected
   /// suggestion.
-  static const String PRINT_MISSED_COMPLETION_DETAILS =
+  static const String _printMissedCompletionDetails =
       'print-missed-completion-details';
 
   /// A flag that causes summary information to be printed about the times that
   /// a completion request failed to produce a suggestions matching the expected
   /// suggestion.
-  static const String PRINT_MISSED_COMPLETION_SUMMARY =
+  static const String _printMissedCompletionSummary =
       'print-missed-completion-summary';
 
   /// A flag that causes information to be printed about places where no
   /// completion location was computed and about information that's missing in
   /// the completion tables.
-  static const String PRINT_MISSING_INFORMATION = 'print-missing-information';
+  static const String _printMissingInformation = 'print-missing-information';
 
   /// A flag that causes information to be printed about the mrr score achieved
   /// at each completion location.
-  static const String PRINT_MRR_BY_LOCATION = 'print-mrr-by-location';
+  static const String _printMrrByLocation = 'print-mrr-by-location';
 
   /// A flag that causes detailed information to be printed every time a
   /// completion request produce a suggestions whose name matches the expected
   /// suggestion but that is referencing a different element (one that's
   /// shadowed by the correct element).
-  static const String PRINT_SHADOWED_COMPLETION_DETAILS =
+  static const String _printShadowedCompletionDetails =
       'print-shadowed-completion-details';
 
   /// A flag that causes information to be printed about the completion requests
   /// that had the worst mrr scores.
-  static const String PRINT_WORST_RESULTS = 'print-worst-results';
+  static const String _printWorstResults = 'print-worst-results';
 
   /// A flag indicating whether information should be printed every time a
   /// completion request fails to produce a suggestions matching the expected
@@ -749,15 +749,18 @@ class CompletionMetricsQualityOptions extends CompletionMetricsOptions {
   final bool printWorstResults;
 
   CompletionMetricsQualityOptions(super.results)
-    : printMissedCompletionDetails =
-          results[PRINT_MISSED_COMPLETION_DETAILS] as bool,
-      printMissedCompletionSummary =
-          results[PRINT_MISSED_COMPLETION_SUMMARY] as bool,
-      printMissingInformation = results[PRINT_MISSING_INFORMATION] as bool,
-      printMrrByLocation = results[PRINT_MRR_BY_LOCATION] as bool,
-      printShadowedCompletionDetails =
-          results[PRINT_SHADOWED_COMPLETION_DETAILS] as bool,
-      printWorstResults = results[PRINT_WORST_RESULTS] as bool;
+    : printMissedCompletionDetails = results.flag(
+        _printMissedCompletionDetails,
+      ),
+      printMissedCompletionSummary = results.flag(
+        _printMissedCompletionSummary,
+      ),
+      printMissingInformation = results.flag(_printMissingInformation),
+      printMrrByLocation = results.flag(_printMrrByLocation),
+      printShadowedCompletionDetails = results.flag(
+        _printShadowedCompletionDetails,
+      ),
+      printWorstResults = results.flag(_printWorstResults);
 }
 
 /// This is the main metrics computer class for code completions. After the

pkg/analysis_server/tool/code_completion/completion_metrics_base.dart

@@ -190,17 +190,17 @@ abstract class CompletionMetricsComputer {
 /// The options specified on the command-line.
 class CompletionMetricsOptions {
   /// An option to control whether and how overlays should be produced.
-  static const String OVERLAY = 'overlay';
+  static const String overlayOption = 'overlay';
 
   /// An option controlling how long of a prefix should be used.
   ///
   /// This affects the offset of the completion request, and how much content is
   /// removed in each of the overlay modes.
-  static const String PREFIX_LENGTH = 'prefix-length';
+  static const String prefixLengthOption = 'prefix-length';
 
   /// A flag that causes information to be printed about the completion requests
   /// that were the slowest to return suggestions.
-  static const String PRINT_SLOWEST_RESULTS = 'print-slowest-results';
+  static const String printSlowestResultsFlag = 'print-slowest-results';
 
   /// The overlay mode that should be used.
   final OverlayMode overlay;
@@ -212,9 +212,9 @@ class CompletionMetricsOptions {
   final bool printSlowestResults;
 
   CompletionMetricsOptions(ArgResults results)
-    : overlay = OverlayMode.parseFlag(results[OVERLAY] as String),
-      prefixLength = int.parse(results[PREFIX_LENGTH] as String),
-      printSlowestResults = results[PRINT_SLOWEST_RESULTS] as bool;
+    : overlay = OverlayMode.parseFlag(results.option(overlayOption)!),
+      prefixLength = int.parse(results.option(prefixLengthOption)!),
+      printSlowestResults = results.flag(printSlowestResultsFlag);
 }
 
 enum OverlayMode {

pkg/analysis_server/tool/code_completion/completion_metrics_client.dart

@@ -67,7 +67,7 @@ ArgParser _createArgParser() {
     )
     ..addFlag('help', abbr: 'h', help: 'Print this help message.')
     ..addOption(
-      CompletionMetricsOptions.OVERLAY,
+      CompletionMetricsOptions.overlayOption,
       allowed: [
         OverlayMode.none.flag,
         OverlayMode.removeRestOfFile.flag,
@@ -81,15 +81,15 @@ ArgParser _createArgParser() {
           'complete at the start of the token without modifying the file.',
     )
     ..addOption(
-      CompletionMetricsOptions.PREFIX_LENGTH,
+      CompletionMetricsOptions.prefixLengthOption,
       defaultsTo: '0',
       help:
           'The number of characters to include in the prefix. Each '
           'completion will be requested this many characters in from the '
           'start of the token being completed.',
     )
     ..addFlag(
-      CompletionMetricsOptions.PRINT_SLOWEST_RESULTS,
+      CompletionMetricsOptions.printSlowestResultsFlag,
       help:
           'Print information about the completion requests that were the '
           'slowest to return suggestions.',

pkg/analysis_server/tool/code_completion/visitors.dart

@@ -130,19 +130,19 @@ class ExpectedCompletion {
 }
 
 class ExpectedCompletionsVisitor extends RecursiveAstVisitor<void> {
-  static const ASYNC_STAR = 'async*';
+  static const _asyncStar = 'async*';
 
-  static const DEFAULT_COLON = 'default:';
+  static const _defaultColon = 'default:';
 
-  static const DEFERRED_AS = 'deferred as';
+  static const _deferredAs = 'deferred as';
 
-  static const EXPORT_STATEMENT = "export '';";
+  static const _exportStatement = "export '';";
 
-  static const IMPORT_STATEMENT = "import '';";
+  static const _importStatement = "import '';";
 
-  static const PART_STATEMENT = "part '';";
-  static const SYNC_STAR = 'sync*';
-  static const YIELD_STAR = 'yield*';
+  static const _partStatement = "part '';";
+  static const _syncStar = 'sync*';
+  static const _yieldStar = 'yield*';
 
   /// The result of resolving the file being visited.
   final ResolvedUnitResult result;
@@ -204,7 +204,7 @@ class ExpectedCompletionsVisitor extends RecursiveAstVisitor<void> {
             entity,
             lineNumber,
             columnNumber,
-            ASYNC_STAR,
+            _asyncStar,
             kind,
             elementKind,
           ),
@@ -216,7 +216,7 @@ class ExpectedCompletionsVisitor extends RecursiveAstVisitor<void> {
             entity,
             lineNumber,
             columnNumber,
-            DEFAULT_COLON,
+            _defaultColon,
             kind,
             elementKind,
           ),
@@ -228,7 +228,7 @@ class ExpectedCompletionsVisitor extends RecursiveAstVisitor<void> {
             entity,
             lineNumber,
             columnNumber,
-            DEFERRED_AS,
+            _deferredAs,
             kind,
             elementKind,
           ),
@@ -240,7 +240,7 @@ class ExpectedCompletionsVisitor extends RecursiveAstVisitor<void> {
             entity,
             lineNumber,
             columnNumber,
-            EXPORT_STATEMENT,
+            _exportStatement,
             kind,
             elementKind,
           ),
@@ -252,7 +252,7 @@ class ExpectedCompletionsVisitor extends RecursiveAstVisitor<void> {
             entity,
             lineNumber,
             columnNumber,
-            IMPORT_STATEMENT,
+            _importStatement,
             kind,
             elementKind,
           ),
@@ -264,7 +264,7 @@ class ExpectedCompletionsVisitor extends RecursiveAstVisitor<void> {
             entity,
             lineNumber,
             columnNumber,
-            PART_STATEMENT,
+            _partStatement,
             kind,
             elementKind,
           ),
@@ -276,7 +276,7 @@ class ExpectedCompletionsVisitor extends RecursiveAstVisitor<void> {
             entity,
             lineNumber,
             columnNumber,
-            SYNC_STAR,
+            _syncStar,
             kind,
             elementKind,
           ),
@@ -288,7 +288,7 @@ class ExpectedCompletionsVisitor extends RecursiveAstVisitor<void> {
             entity,
             lineNumber,
             columnNumber,
-            YIELD_STAR,
+            _yieldStar,
             kind,
             elementKind,
           ),