Fine. Tracking for LibraryElementImpl.exportedLibraries

Change-Id: Ia2a74667f97efbbb45dde7b95e4649edbc1a55dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/449681
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/binary/binary_reader.dart

@@ -135,6 +135,14 @@ class SummaryDataReader {
     }
   }
 
+  List<Uri>? readOptionalUriList() {
+    if (readBool()) {
+      return readUriList();
+    } else {
+      return null;
+    }
+  }
+
   String readStringReference() {
     var index = readUint30();
     return stringOfIndex(index);
@@ -237,6 +245,10 @@ class SummaryDataReader {
     return Uri.parse(uriStr);
   }
 
+  List<Uri> readUriList() {
+    return readTypedList(readUri);
+  }
+
   /// Temporary move to [offset] and run [operation].
   void runAtOffset(int offset, void Function() operation) {
     var oldOffset = this.offset;

pkg/analyzer/lib/src/binary/binary_writer.dart

@@ -189,6 +189,15 @@ class BufferedSink {
     }
   }
 
+  void writeOptionalUriList(List<Uri>? value) {
+    if (value != null) {
+      writeBool(true);
+      writeUriList(value);
+    } else {
+      writeBool(false);
+    }
+  }
+
   /// Write the [value] as UTF8 encoded byte array.
   void writeStringUtf8(String value) {
     var bytes = const Utf8Encoder().convert(value);
@@ -246,6 +255,10 @@ class BufferedSink {
     writeStringUtf8(uriStr);
   }
 
+  void writeUriList(List<Uri> uriList) {
+    writeList(uriList, writeUri);
+  }
+
   @pragma("vm:prefer-inline")
   void _addByte(int byte) {
     _buffer[_length++] = byte;

pkg/analyzer/lib/src/dart/analysis/driver.dart

@@ -106,7 +106,7 @@ testFineAfterLibraryAnalyzerHook;
 // TODO(scheglov): Clean up the list of implicitly analyzed files.
 class AnalysisDriver {
   /// The version of data format, should be incremented on every format change.
-  static const int DATA_VERSION = 555;
+  static const int DATA_VERSION = 556;
 
   /// The number of exception contexts allowed to write. Once this field is
   /// zero, we stop writing any new exception contexts in this process.

pkg/analyzer/lib/src/dart/element/element.dart

@@ -6092,8 +6092,10 @@ class LibraryElementImpl extends ElementImpl
   }
 
   @override
+  @trackedDirectly
   List<LibraryElementImpl> get exportedLibraries {
-    return fragments
+    globalResultRequirements?.record_library_exportedLibraries(element: this);
+    return _fragments
         .expand((fragment) => fragment.libraryExports)
         .map((export) => export.exportedLibrary)
         .nonNulls

pkg/analyzer/lib/src/fine/library_manifest.dart

@@ -27,6 +27,8 @@ class LibraryManifest {
   final Uint8List featureSet;
   final ManifestLibraryLanguageVersion languageVersion;
 
+  final List<Uri> exportedLibraryUris;
+
   /// The names that are re-exported by this library.
   /// This does not include names that are declared in this library.
   final Map<LookupName, ManifestItemId> reExportMap;
@@ -52,6 +54,7 @@ class LibraryManifest {
     required this.name,
     required this.featureSet,
     required this.languageVersion,
+    required this.exportedLibraryUris,
     required this.reExportMap,
     required this.reExportDeprecatedOnly,
     required this.declaredClasses,
@@ -72,6 +75,7 @@ class LibraryManifest {
       name: reader.readOptionalStringUtf8(),
       featureSet: reader.readUint8List(),
       languageVersion: ManifestLibraryLanguageVersion.read(reader),
+      exportedLibraryUris: reader.readUriList(),
       reExportMap: reader.readLookupNameToIdMap(),
       reExportDeprecatedOnly: reader.readLookupNameSet(),
       declaredClasses: reader.readLookupNameMap(
@@ -152,6 +156,7 @@ class LibraryManifest {
     sink.writeOptionalStringUtf8(name);
     sink.writeUint8List(featureSet);
     languageVersion.write(sink);
+    sink.writeUriList(exportedLibraryUris);
     reExportMap.write(sink);
     reExportDeprecatedOnly.write(sink);
     declaredClasses.write(sink);
@@ -865,6 +870,9 @@ class LibraryManifestBuilder {
         languageVersion: ManifestLibraryLanguageVersion.encode(
           libraryElement.languageVersion,
         ),
+        exportedLibraryUris: libraryElement.exportedLibraries
+            .map((e) => e.uri)
+            .toList(),
         reExportMap: {},
         reExportDeprecatedOnly: <LookupName>{},
         declaredClasses: newClassItems,
@@ -1085,6 +1093,7 @@ class LibraryManifestBuilder {
           name: null,
           featureSet: Uint8List(0),
           languageVersion: ManifestLibraryLanguageVersion.empty(),
+          exportedLibraryUris: [],
           reExportMap: {},
           reExportDeprecatedOnly: <LookupName>{},
           declaredClasses: {},

pkg/analyzer/lib/src/fine/requirement_failure.dart

@@ -298,6 +298,24 @@ class LibraryChildrenIdsMismatch extends RequirementFailure {
   }
 }
 
+class LibraryExportedUrisMismatch extends RequirementFailure {
+  final Uri libraryUri;
+  final List<Uri> expected;
+  final List<Uri> actual;
+
+  LibraryExportedUrisMismatch({
+    required this.libraryUri,
+    required this.expected,
+    required this.actual,
+  });
+
+  @override
+  String toString() {
+    return 'LibraryExportedUrisMismatch(libraryUri: $libraryUri, '
+        'expected: $expected, actual: $actual)';
+  }
+}
+
 class LibraryFeatureSetMismatch extends RequirementFailure {
   final Uri libraryUri;
   final Uint8List? expected;
@@ -326,6 +344,12 @@ class LibraryLanguageVersionMismatch extends RequirementFailure {
     required this.expected,
     required this.actual,
   });
+
+  @override
+  String toString() {
+    return 'LibraryLanguageVersionMismatch(libraryUri: $libraryUri, '
+        'expected: $expected, actual: $actual)';
+  }
 }
 
 class LibraryMissing extends RequirementFailure {

pkg/analyzer/lib/src/fine/requirements.dart

@@ -375,6 +375,8 @@ class LibraryRequirements {
   Uint8List? featureSet;
   ManifestLibraryLanguageVersion? languageVersion;
 
+  List<Uri>? exportedLibraryUris;
+
   /// TopName => ID
   final Map<LookupName, ManifestItemId?> exportedTopLevels;
 
@@ -416,6 +418,7 @@ class LibraryRequirements {
     required this.name,
     required this.featureSet,
     required this.languageVersion,
+    required this.exportedLibraryUris,
     required this.exportedTopLevels,
     required this.instances,
     required this.interfaces,
@@ -448,6 +451,7 @@ class LibraryRequirements {
       name: null,
       featureSet: null,
       languageVersion: null,
+      exportedLibraryUris: null,
       exportedTopLevels: {},
       instances: {},
       interfaces: {},
@@ -481,6 +485,7 @@ class LibraryRequirements {
       name: reader.readOptionalStringUtf8(),
       featureSet: reader.readOptionalUint8List(),
       languageVersion: ManifestLibraryLanguageVersion.readOptional(reader),
+      exportedLibraryUris: reader.readOptionalUriList(),
       exportedTopLevels: reader.readNameToOptionalIdMap(),
       instances: reader.readMap(
         readKey: () => LookupName.read(reader),
@@ -522,6 +527,7 @@ class LibraryRequirements {
     sink.writeOptionalStringUtf8(name);
     sink.writeOptionalUint8List(featureSet);
     sink.writeOptionalObject(languageVersion, (it) => it.write(sink));
+    sink.writeOptionalUriList(exportedLibraryUris);
     sink.writeNameToIdMap(exportedTopLevels);
 
     sink.writeMap(
@@ -1314,6 +1320,17 @@ class RequirementsManifest {
           );
         }
       }
+
+      if (libraryRequirements.exportedLibraryUris case var expected?) {
+        var actual = libraryManifest.exportedLibraryUris;
+        if (!const ListEquality<Uri>().equals(expected, actual)) {
+          return LibraryExportedUrisMismatch(
+            libraryUri: libraryUri,
+            expected: expected,
+            actual: actual,
+          );
+        }
+      }
     }
 
     for (var exportRequirement in exportRequirements) {
@@ -1823,6 +1840,20 @@ class RequirementsManifest {
     requirements.exportedTopLevels[mainName] = id;
   }
 
+  void record_library_exportedLibraries({required LibraryElementImpl element}) {
+    if (_recordingLockLevel != 0) {
+      return;
+    }
+
+    var manifest = element.manifest;
+    if (manifest == null) {
+      return;
+    }
+
+    var requirements = _getLibraryRequirements(element);
+    requirements.exportedLibraryUris = manifest.exportedLibraryUris;
+  }
+
   void record_library_featureSet({required LibraryElementImpl element}) {
     if (_recordingLockLevel != 0) {
       return;