Update various packages based on diagnostics from strict_top_level_inference.

Change-Id: I032d10fd1956b62a9e45ceee9ca2b28c9863d1ce
Tested: diagnostic updates only change
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401560
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Nate Bosch <[email protected]>

Author: devoncarew

pkg/analysis_server/lib/src/legacy_analysis_server.dart

@@ -524,7 +524,7 @@ class LegacyAnalysisServer extends AnalysisServer {
 
   /// There was an error related to the socket from which requests are being
   /// read.
-  void error(argument) {}
+  void error(Object argument) {}
 
   /// Return the cached analysis result for the file with the given [path].
   /// If there is no cached result, return `null`.

pkg/analysis_server/lib/src/services/completion/postfix/postfix_completion.dart

@@ -306,9 +306,12 @@ abstract final class DartPostfixCompletion {
     return processor.findObjectExpression() != null;
   }
 
-  static bool _false(_) => false;
+  static bool _false(PostfixCompletionProcessor _) => false;
 
-  static Future<PostfixCompletion?> _null(_, _) async => null;
+  static Future<PostfixCompletion?> _null(
+    PostfixCompletionProcessor _,
+    PostfixCompletionKind _,
+  ) async => null;
 }
 
 /// A description of a postfix completion.

pkg/analysis_server/lib/src/utilities/mocks.dart

@@ -47,7 +47,7 @@ class MockServerChannel implements ServerCommunicationChannel {
     _closed = true;
   }
 
-  void expectMsgCount({responseCount = 0, notificationCount = 0}) {
+  void expectMsgCount({int responseCount = 0, int notificationCount = 0}) {
     expect(responsesReceived, hasLength(responseCount));
     expect(notificationsReceived, hasLength(notificationCount));
   }

pkg/build_integration/lib/file_system/multi_root.dart

@@ -36,7 +36,7 @@ class MultiRootFileSystem implements FileSystem {
   final List<Uri> roots;
   final FileSystem original;
 
-  MultiRootFileSystem(this.markerScheme, List roots, this.original)
+  MultiRootFileSystem(this.markerScheme, List<Uri> roots, this.original)
       : roots = roots.map(_normalize).toList();
 
   @override
@@ -116,7 +116,6 @@ class MissingFileSystemEntity implements FileSystemEntity {
       Future.error(FileSystemException(uri, 'File not found'));
 }
 
-Uri _normalize(root) {
-  Uri uri = root;
+Uri _normalize(Uri uri) {
   return uri.path.endsWith('/') ? uri : uri.replace(path: '${uri.path}/');
 }

pkg/build_integration/lib/file_system/single_root.dart

@@ -80,7 +80,6 @@ class SingleRootFileSystemEntity implements FileSystemEntity {
   Future<String> readAsString() async => delegate.readAsString();
 }
 
-_normalize(root) {
-  Uri uri = root;
+Uri _normalize(Uri uri) {
   return uri.path.endsWith('/') ? uri : uri.replace(path: '${uri.path}/');
 }

pkg/dart2js_info/bin/src/library_size_split.dart

@@ -213,7 +213,7 @@ class _Divider extends _Row {
   const _Divider() : super('', 0);
 }
 
-String _pad(value, n, {bool right = false}) {
+String _pad(Object value, int n, {bool right = false}) {
   final s = '$value';
   if (s.length >= n) return s;
   var pad = ' ' * (n - s.length);

pkg/dart2js_info/bin/src/live_code_size_analysis.dart

@@ -75,7 +75,11 @@ class LiveCodeAnalysisCommand extends Command<void> with PrintUsageException {
   }
 }
 
-Future<void> _liveCodeAnalysis(infoFile, coverageFile, bool verbose) async {
+Future<void> _liveCodeAnalysis(
+  String infoFile,
+  String coverageFile,
+  bool verbose,
+) async {
   var info = await infoFromFile(infoFile);
   var coverage = jsonDecode(File(coverageFile).readAsStringSync());
 

pkg/dart2js_info/bin/tools.dart

@@ -22,7 +22,7 @@ import 'src/text_print.dart';
 import 'src/to_devtools_format.dart';
 
 /// Entrypoint to run all dart2js_info tools.
-void main(args) {
+void main(List<String> args) {
   var commandRunner =
       CommandRunner(
           "dart2js_info",

pkg/dart2js_tools/bin/deobfuscate.dart

@@ -40,7 +40,7 @@ import 'package:stack_trace/stack_trace.dart';
 ///
 /// The .js file must contain a `//# sourceMappingURL=` line at the end, which
 /// tells this script how to determine the name of the source-map file.
-main(List<String> args) {
+void main(List<String> args) {
   if (args.length != 1) {
     print('usage: deobfuscate.dart <stack-trace-file>');
     exit(1);
@@ -87,7 +87,7 @@ main(List<String> args) {
 final green = stdout.hasTerminal ? '\x1b[32m' : '';
 final none = stdout.hasTerminal ? '\x1b[0m' : '';
 
-printPadded(String mapping, String? original, sb) {
+void printPadded(String mapping, String? original, sb) {
   var len = mapping.length;
   var s = mapping.indexOf('\n');
   if (s >= 0) len -= s + 1;

pkg/dart2js_tools/bin/lookup_name.dart

@@ -4,7 +4,7 @@ import 'dart:io';
 import 'package:dart2js_tools/src/dart2js_mapping.dart';
 import 'package:dart2js_tools/src/util.dart';
 
-main(List<String> args) {
+void main(List<String> args) {
   if (args.length < 2) {
     print('usage: read.dart <source-map-file> <name>');
     exit(1);