Call File::GetCanonicalPath in Platform::ResolveExecutablePathInto() to make

it uniform with Platform::ResolveExecutablePath()

TEST=ci

Change-Id: Ib9e2f0c8ce2dc0d10cb67ceb3c3166f37201391f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/434040
Reviewed-by: Alexander Aprelev <[email protected]>
Commit-Queue: Siva Annamalai <[email protected]>

Author: a-siva

runtime/bin/platform_win.cc

@@ -386,16 +386,20 @@ intptr_t Platform::ResolveExecutablePathInto(char* result, size_t result_size) {
   // Ensure no last error before calling GetModuleFileNameW.
   SetLastError(ERROR_SUCCESS);
   const int kTmpBufferSize = 32768;
-  wchar_t tmp_buffer[kTmpBufferSize];
+  wchar_t tmp_buffer_1[kTmpBufferSize];
+  char tmp_buffer_2[kTmpBufferSize];
   // Get the required length of the buffer.
-  GetModuleFileNameW(nullptr, tmp_buffer, kTmpBufferSize);
+  GetModuleFileNameW(nullptr, tmp_buffer_1, kTmpBufferSize);
   if (GetLastError() != ERROR_SUCCESS) {
     return -1;
   }
-  WideToUtf8Scope wide_to_utf8_scope(tmp_buffer);
-  if (wide_to_utf8_scope.length() <= result_size) {
-    strncpy(result, wide_to_utf8_scope.utf8(), result_size);
-    return wide_to_utf8_scope.length();
+  WideToUtf8Scope wide_to_utf8_scope(tmp_buffer_1);
+  if (wide_to_utf8_scope.length() <= kTmpBufferSize) {
+    strncpy(tmp_buffer_2, wide_to_utf8_scope.utf8(), kTmpBufferSize);
+    if (!File::GetCanonicalPath(nullptr, tmp_buffer_2, result, result_size)) {
+      return -1;
+    }
+    return strlen(result);
   }
   return -1;
 }