Skip to content

Commit 7ac80be

Browse files
stereotype441Commit Queue
authored andcommitted
[front end] Remove type argument from class Code.
This type argument was never used. Removing it should make it easier to make changes to the front end error message logic (and associated code generator), which I intend to do as part of a long term plan to make the analyzer and front end error reporting systems more consistent, and eventually merge them. Change-Id: I994cd2a74c5fd77df192f6a1f2dde46ba8a31883 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/442723 Reviewed-by: Nicholas Shahan <[email protected]> Commit-Queue: Paul Berry <[email protected]> Reviewed-by: Johnni Winther <[email protected]>
1 parent 206e10a commit 7ac80be

File tree

12 files changed

+1056
-1996
lines changed

12 files changed

+1056
-1996
lines changed

pkg/_fe_analyzer_shared/lib/src/messages/codes.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ part 'codes_generated.dart';
1818

1919
const int noLength = 1;
2020

21-
class Code<T> {
21+
class Code {
2222
final String name;
2323

2424
/// The unique positive integer associated with this code,
@@ -42,7 +42,7 @@ class Code<T> {
4242
}
4343

4444
class Message {
45-
final Code<dynamic> code;
45+
final Code code;
4646

4747
final String problemMessage;
4848

@@ -71,7 +71,7 @@ class Message {
7171
}
7272
}
7373

74-
class MessageCode extends Code<Null> implements Message {
74+
class MessageCode extends Code implements Message {
7575
@override
7676
final String problemMessage;
7777

@@ -91,7 +91,7 @@ class MessageCode extends Code<Null> implements Message {
9191
Map<String, dynamic> get arguments => const <String, dynamic>{};
9292

9393
@override
94-
Code<dynamic> get code => this;
94+
Code get code => this;
9595

9696
@override
9797
LocatedMessage withLocation(Uri uri, int charOffset, int length) {
@@ -140,7 +140,7 @@ class LocatedMessage implements Comparable<LocatedMessage> {
140140
this.messageObject,
141141
);
142142

143-
Code<dynamic> get code => messageObject.code;
143+
Code get code => messageObject.code;
144144

145145
String get problemMessage => messageObject.problemMessage;
146146

@@ -245,7 +245,7 @@ class FormattedMessage implements DiagnosticMessage {
245245
this.involvedFiles,
246246
});
247247

248-
Code<dynamic> get code => locatedMessage.code;
248+
Code get code => locatedMessage.code;
249249

250250
@override
251251
String get codeName => code.name;

0 commit comments

Comments
 (0)