Remove element_flags library.

All modifiers are directly written using write/read modifiers, so
encoding and decoding using flags is no longer necessary.

Change-Id: I8a58f14e0b7639293984745044dbedf6a6be2c1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/443361
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Paul Berry <[email protected]>
Commit-Queue: Paul Berry <[email protected]>

Author: fshcheglov

pkg/analyzer/lib/src/dart/analysis/driver.dart

@@ -109,7 +109,7 @@ testFineAfterLibraryAnalyzerHook;
 // TODO(scheglov): Clean up the list of implicitly analyzed files.
 class AnalysisDriver {
   /// The version of data format, should be incremented on every format change.
-  static const int DATA_VERSION = 509;
+  static const int DATA_VERSION = 510;
 
   /// The number of exception contexts allowed to write. Once this field is
   /// zero, we stop writing any new exception contexts in this process.

pkg/analyzer/lib/src/dart/element/element.dart

@@ -5695,9 +5695,6 @@ class LibraryElementImpl extends ElementImpl
   // TODO(scheglov): replace with `LibraryName` or something.
   int nameLength;
 
-  @override
-  bool isSynthetic = false;
-
   @override
   List<ClassElementImpl> classes = [];
 
@@ -5897,6 +5894,15 @@ class LibraryElementImpl extends ElementImpl
     return DartUriResolver.isDartUri(uri);
   }
 
+  @override
+  bool get isSynthetic {
+    return hasModifier(Modifier.SYNTHETIC);
+  }
+
+  set isSynthetic(bool isSynthetic) {
+    setModifier(Modifier.SYNTHETIC, isSynthetic);
+  }
+
   @override
   ElementKind get kind => ElementKind.LIBRARY;
 

pkg/analyzer/lib/src/summary2/bundle_reader.dart

@@ -26,7 +26,6 @@ import 'package:analyzer/src/generated/utilities_dart.dart';
 import 'package:analyzer/src/summary2/ast_binary_reader.dart';
 import 'package:analyzer/src/summary2/ast_binary_tag.dart';
 import 'package:analyzer/src/summary2/data_reader.dart';
-import 'package:analyzer/src/summary2/element_flags.dart';
 import 'package:analyzer/src/summary2/export.dart';
 import 'package:analyzer/src/summary2/informative_data.dart';
 import 'package:analyzer/src/summary2/linked_element_factory.dart';
@@ -146,7 +145,7 @@ class LibraryReader {
     _libraryElement.reference = _reference;
 
     // Read the rest of non-resolution data for the library.
-    LibraryElementFlags.read(_reader, _libraryElement);
+    _libraryElement.readModifiers(_reader);
     _libraryElement.languageVersion = _readLanguageVersion();
 
     _libraryElement.exportedReferences = _reader.readTypedList(
@@ -1084,7 +1083,7 @@ class LibraryReader {
         );
       }
       idFragmentMap[id] = element;
-      ParameterElementFlags.read(_reader, element);
+      element.readModifiers(_reader);
       element.typeParameters = _readTypeParameters();
       element.formalParameters = _readParameters();
       return element;

pkg/analyzer/lib/src/summary2/bundle_writer.dart

@@ -20,7 +20,6 @@ import 'package:analyzer/src/error/inference_error.dart';
 import 'package:analyzer/src/summary2/ast_binary_tag.dart';
 import 'package:analyzer/src/summary2/ast_binary_writer.dart';
 import 'package:analyzer/src/summary2/data_writer.dart';
-import 'package:analyzer/src/summary2/element_flags.dart';
 import 'package:analyzer/src/summary2/export.dart';
 import 'package:analyzer/src/summary2/reference.dart';
 
@@ -101,7 +100,7 @@ class BundleWriter {
     // Write non-resolution data for the library.
     _sink._writeStringReference(libraryElement.name);
     _writeFeatureSet(libraryElement.featureSet);
-    LibraryElementFlags.write(_sink, libraryElement);
+    libraryElement.writeModifiers(_sink);
     _writeLanguageVersion(libraryElement.languageVersion);
     _writeExportedReferences(libraryElement.exportedReferences);
     _sink.writeUint30List(libraryElement.nameUnion.mask);
@@ -628,7 +627,7 @@ class BundleWriter {
     _sink.writeBool(element.isInitializingFormal);
     _sink.writeBool(element.isSuperFormal);
     _sink._writeFormalParameterKind(element);
-    ParameterElementFlags.write(_sink, element);
+    element.writeModifiers(_sink);
 
     _resolutionSink._writeMetadata(element.metadata);