[dart2wasm] Enable compiler asserts for dynamic module tests.

Fixes several asserts that were throwing when running with dynamic modules enabled.

Bug: #60743
Change-Id: I6bcd3723ecdee784b3d1603e1c87a47e3703a7f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423261
Reviewed-by: Martin Kustermann <[email protected]>
Commit-Queue: Nate Biggs <[email protected]>

Author: natebiggs

pkg/dart2wasm/lib/class_info.dart

@@ -572,7 +572,6 @@ class ClassInfoCollector {
         if (translator.isDynamicSubmodule && mainModuleConcreteRange.isEmpty) {
           final submoduleConcreteRange =
               classIdNumbering.getConcreteClassIdRangeForDynamicSubmodule(cls);
-          assert(submoduleConcreteRange.isNotEmpty);
           addRanges(submoduleConcreteRange);
         } else {
           assert(classIdNumbering

pkg/dart2wasm/lib/dispatch_table.dart

@@ -230,8 +230,10 @@ class SelectorInfo {
 
     List<w.ValueType> typeParameters = List.filled(paramInfo.typeParamCount,
         translator.classInfo[translator.typeClass]!.nonNullableType);
-    List<w.ValueType> inputs = List.generate(inputSets.length,
-        (i) => _upperBound(inputSets[i], ensureBoxed: ensureBoxed[i]));
+    List<w.ValueType> inputs = List.generate(
+        inputSets.length,
+        (i) => _upperBound(inputSets[i],
+            ensureBoxed: ensureBoxed[i], isReceiver: i == 0));
     if (name == '==') {
       // == can't be called with null
       inputs[1] = inputs[1].withNullability(false);
@@ -242,13 +244,18 @@ class SelectorInfo {
         [inputs[0], ...typeParameters, ...inputs.sublist(1)], outputs);
   }
 
-  w.ValueType _upperBound(Set<w.ValueType> types, {required bool ensureBoxed}) {
+  w.ValueType _upperBound(Set<w.ValueType> types,
+      {required bool ensureBoxed, bool isReceiver = false}) {
     if (types.isEmpty) {
       // This happens if the selector doesn't have any targets. Any call site of
       // such a selector is unreachable. Though such call sites still have to
       // evaluate receiver and arguments. Doing so requires the signature. So we
-      // create a dummy signature with top types.
-      return translator.topInfo.nullableType;
+      // create a dummy signature with top types. Receivers specifically should
+      // be non-nullable since we must be invoking a selector on some object.
+      assert(!isReceiver || isDynamicSubmoduleOverridable);
+      return isReceiver
+          ? translator.topInfo.nonNullableType
+          : translator.topInfo.nullableType;
     }
     if (!ensureBoxed && types.length == 1 && types.single.isPrimitive) {
       // Unboxed primitive.

pkg/dart2wasm/lib/dynamic_forwarders.dart

@@ -54,7 +54,7 @@ class _DynamicForwarderCallTarget extends CallTarget {
   _DynamicForwarderCallTarget(
       this.translator, this._kind, this.memberName, this.callingModule)
       : assert(!translator.isDynamicSubmodule ||
-            (memberName == 'call' && _kind == _ForwarderKind.Getter)),
+            (memberName == 'call' && _kind == _ForwarderKind.Method)),
         super(_kind.functionType(translator));
 
   @override

pkg/dart2wasm/lib/functions.dart

@@ -346,8 +346,11 @@ class _FunctionTypeGenerator extends MemberVisitor1<w.FunctionType, Reference> {
       return _makeFunctionType(translator, target, null);
     }
     assert(!translator.dispatchTable
-        .selectorForTarget(target)
-        .containsTarget(target));
+            .selectorForTarget(target)
+            .containsTarget(target) &&
+        !translator.dispatchTable
+            .selectorForTarget(target)
+            .containsTarget(target));
 
     final receiverType = target.asMember.enclosingClass!
         .getThisType(translator.coreTypes, Nullability.nonNullable);
@@ -365,8 +368,11 @@ class _FunctionTypeGenerator extends MemberVisitor1<w.FunctionType, Reference> {
     }
 
     assert(!translator.dispatchTable
-        .selectorForTarget(target)
-        .containsTarget(target));
+            .selectorForTarget(target)
+            .containsTarget(target) &&
+        !translator.dispatchTable
+            .selectorForTarget(target)
+            .containsTarget(target));
 
     final receiverType = target.asMember.enclosingClass!
         .getThisType(translator.coreTypes, Nullability.nonNullable);

pkg/dart2wasm/lib/record_class_generator.dart

@@ -421,10 +421,11 @@ class _RecordClassGenerator {
       statements.add(IfStatement(
         Not(InstanceInvocation(
           InstanceAccessKind.Instance,
-          (InstanceInvocation(InstanceAccessKind.Instance, ThisExpression(),
-              getRti.name, Arguments([]),
+          (InstanceGet(
+              InstanceAccessKind.Instance, ThisExpression(), getRti.name,
               interfaceTarget: getRti,
-              functionType: getRti.computeSignatureOrFunctionType())),
+              resultType: InterfaceType(
+                  recordRuntimeTypeClass, Nullability.nonNullable))),
           checkInstance.name,
           Arguments([VariableGet(parameter)]),
           interfaceTarget: checkInstance,

pkg/dart2wasm/lib/translator.dart

@@ -1007,8 +1007,10 @@ class Translator with KernelNodes {
         .getClosureRepresentation(typeCount, positionalCount, names)!;
     assert(representation.vtableStruct.fields.length ==
         representation.vtableBaseIndex +
-            (1 + positionalCount) +
-            representation.nameCombinations.length);
+            (dynamicModuleSupportEnabled
+                ? 0
+                : (1 + positionalCount) +
+                    representation.nameCombinations.length));
 
     List<w.BaseFunction> functions = [];
 
@@ -1336,6 +1338,7 @@ class Translator with KernelNodes {
   }
 
   DispatchTable dispatchTableForTarget(Reference target) {
+    assert(target.asMember.isInstanceMember);
     if (!isDynamicSubmodule) return dispatchTable;
     if (moduleForReference(target) == dynamicSubmodule) return dispatchTable;
     assert(target.asMember.isDynamicSubmoduleCallable(coreTypes));
@@ -1348,18 +1351,28 @@ class Translator with KernelNodes {
   }
 
   w.FunctionType signatureForDirectCall(Reference target) {
-    return _signatureFromDispatchTable(target, dispatchTableForTarget(target));
+    return _signatureForModule(
+        target,
+        target.asMember.isInstanceMember
+            ? dispatchTableForTarget(target)
+            : null);
   }
 
   w.FunctionType signatureForMainModule(Reference target) {
-    return _signatureFromDispatchTable(target, dynamicMainModuleDispatchTable!);
+    return _signatureForModule(
+        target,
+        target.asMember.isInstanceMember
+            ? dynamicMainModuleDispatchTable!
+            : null);
   }
 
-  w.FunctionType _signatureFromDispatchTable(
-      Reference target, DispatchTable table) {
-    if (target.asMember.isInstanceMember && !target.isBodyReference) {
+  w.FunctionType _signatureForModule(Reference target, DispatchTable? table) {
+    if (table != null &&
+        !target.isBodyReference &&
+        !target.isTypeCheckerReference) {
       final selector = table.selectorForTarget(target);
-      if (selector.containsTarget(target)) {
+      if (selector.containsTarget(target) ||
+          selector.isDynamicSubmoduleOverridable) {
         return selector.signature;
       }
     }

pkg/dynamic_modules/test/runner/dart2wasm.dart

@@ -63,6 +63,7 @@ class Dart2wasmExecutor implements TargetExecutor {
   ) async {
     var testDir = _tmp.uri.resolve(testName).toFilePath();
     var args = [
+      '--compiler-asserts',
       '--packages=${repoRoot.toFilePath()}/.dart_tool/package_config.json',
       '--multi-root=${sourceDir.resolve('../../').toFilePath()}',
       '--multi-root-scheme=$rootScheme',