[cfe] Dot shorthands - FutureOr for invocations.

This CL implements `FutureOr` for static method invocations and constructors.

Note: `static_method_future_or_test` doesn't work due to unrelated reasons (initializers), but I corrected a typo anyways.

Bug: #59758
Change-Id: I77b97b0a9104fb0354ce1de39b619394f4477f32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414664
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Kallen Tu <[email protected]>

Author: kallentu

pkg/front_end/lib/src/type_inference/inference_visitor.dart

@@ -12127,6 +12127,13 @@ class InferenceVisitorImpl extends InferenceVisitorBase
     // Use the previously cached context type to determine the declaration
     // member that we're trying to find.
     DartType cachedContext = getDotShorthandContext().unwrapTypeSchemaView();
+
+    // The static namespace denoted by `S` is also the namespace denoted by
+    // `FutureOr<S>`.
+    while (cachedContext is FutureOrType) {
+      cachedContext = cachedContext.typeArgument;
+    }
+
     Member? member = findInterfaceMember(
             cachedContext, node.name, node.fileOffset,
             includeExtensionMethods: false,

pkg/front_end/testcases/dot_shorthands/futureor.dart

@@ -6,6 +6,12 @@ import 'dart:async';
 
 enum Color { red, blue, green }
 
+class E {
+  final int x;
+  static E y(int x) => E(x);
+  E(this.x);
+}
+
 void main() {
   FutureOr<Color> color = .blue;
   FutureOr<FutureOr<Color>> recursiveColor = .blue;
@@ -22,4 +28,7 @@ void main() {
   }
 
   var colorList = <FutureOr<Color>>[.blue, .green, .red];
+
+  FutureOr<E> e = .y(1);
+  FutureOr<FutureOr<E>> recursiveE = .y(1);
 }

pkg/front_end/testcases/dot_shorthands/futureor.dart.strong.expect

@@ -16,6 +16,14 @@ class Color extends core::_Enum /*isEnum*/  {
   method _enumToString() → core::String
     return "Color.${this.{core::_Enum::_name}{core::String}}";
 }
+class E extends core::Object {
+  final field core::int x;
+  constructor •(core::int x) → self::E
+    : self::E::x = x, super core::Object::•()
+    ;
+  static method y(core::int x) → self::E
+    return new self::E::•(x);
+}
 static method main() → void {
   FutureOr<self::Color>color = #C6;
   FutureOr<FutureOr<self::Color>>recursiveColor = #C6;
@@ -55,6 +63,8 @@ static method main() → void {
     }
   }
   core::List<FutureOr<self::Color>> colorList = <FutureOr<self::Color>>[#C6, #C9, #C3];
+  FutureOr<self::E>e = self::E::y(1);
+  FutureOr<FutureOr<self::E>>recursiveE = self::E::y(1);
 }
 
 constants  {

pkg/front_end/testcases/dot_shorthands/futureor.dart.strong.modular.expect

@@ -16,6 +16,14 @@ class Color extends core::_Enum /*isEnum*/  {
   method _enumToString() → core::String
     return "Color.${this.{core::_Enum::_name}{core::String}}";
 }
+class E extends core::Object {
+  final field core::int x;
+  constructor •(core::int x) → self::E
+    : self::E::x = x, super core::Object::•()
+    ;
+  static method y(core::int x) → self::E
+    return new self::E::•(x);
+}
 static method main() → void {
   FutureOr<self::Color>color = #C6;
   FutureOr<FutureOr<self::Color>>recursiveColor = #C6;
@@ -55,6 +63,8 @@ static method main() → void {
     }
   }
   core::List<FutureOr<self::Color>> colorList = <FutureOr<self::Color>>[#C6, #C9, #C3];
+  FutureOr<self::E>e = self::E::y(1);
+  FutureOr<FutureOr<self::E>>recursiveE = self::E::y(1);
 }
 
 constants  {

pkg/front_end/testcases/dot_shorthands/futureor.dart.strong.outline.expect

@@ -15,6 +15,13 @@ class Color extends core::_Enum /*isEnum*/  {
   method _enumToString() → core::String
     return "Color.${this.{core::_Enum::_name}{core::String}}";
 }
+class E extends core::Object {
+  final field core::int x;
+  constructor •(core::int x) → self::E
+    ;
+  static method y(core::int x) → self::E
+    ;
+}
 static method main() → void
   ;
 

pkg/front_end/testcases/dot_shorthands/futureor.dart.strong.transformed.expect

@@ -16,6 +16,14 @@ class Color extends core::_Enum /*isEnum*/  {
   method _enumToString() → core::String
     return "Color.${this.{core::_Enum::_name}{core::String}}";
 }
+class E extends core::Object {
+  final field core::int x;
+  constructor •(core::int x) → self::E
+    : self::E::x = x, super core::Object::•()
+    ;
+  static method y(core::int x) → self::E
+    return new self::E::•(x);
+}
 static method main() → void {
   FutureOr<self::Color>color = #C6;
   FutureOr<FutureOr<self::Color>>recursiveColor = #C6;
@@ -55,6 +63,8 @@ static method main() → void {
     }
   }
   core::List<FutureOr<self::Color>> colorList = core::_GrowableList::_literal3<FutureOr<self::Color>>(#C6, #C9, #C3);
+  FutureOr<self::E>e = self::E::y(1);
+  FutureOr<FutureOr<self::E>>recursiveE = self::E::y(1);
 }
 
 constants  {

pkg/front_end/testcases/dot_shorthands/futureor.dart.textual_outline.expect

@@ -2,4 +2,10 @@ import 'dart:async';
 
 enum Color { red, blue, green }
 
+class E {
+  final int x;
+  static E y(int x) => E(x);
+  E(this.x);
+}
+
 void main() {}

pkg/front_end/testcases/dot_shorthands/futureor.dart.textual_outline_modelled.expect

@@ -1,5 +1,11 @@
 import 'dart:async';
 
+class E {
+  E(this.x);
+  final int x;
+  static E y(int x) => E(x);
+}
+
 enum Color { red, blue, green }
 
 void main() {}

tests/language/dot_shorthands/member/static_method_future_or_test.dart

@@ -46,7 +46,7 @@ void main() {
   var memberExtList = <FutureOr<StaticMemberExt>>[.member(), .memberType<String, int>("s")];
   var nullableMemberExtList = <FutureOr<StaticMemberExt?>>[.member(), .memberType<String, int>("s")];
 
-  var memberExtContextPositional = StaticMemberExtFutureOrContext(.member(), .regular(1));
+  var memberExtContextPositional = StaticMemberExtFutureOrContext(.member(), .memberType<String, int>("s"));
   var memberExtContextNamed = StaticMemberExtFutureOrContext.named(nullableMemberExt: .memberType<String, int>("s"));
   var memberExtContextOptional = StaticMemberExtFutureOrContext.optional(.memberType<String, int>("s"));
 }