Skip to content

Commit 7e94bec

Browse files
derekxu16Commit Queue
authored andcommitted
Unconditionally shut down the resident frontend server after each VM Service test run that uses it
Change-Id: I67af9d4813a5b9e7a3b425bb8dc3394923f9a90d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/403400 Commit-Queue: Derek Xu <[email protected]> Reviewed-by: Ben Konyi <[email protected]>
1 parent b99b43a commit 7e94bec

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

pkg/vm_service/test/common/test_helper.dart

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -364,6 +364,16 @@ $st
364364
});
365365

366366
final exitCode = await process.exitCode;
367+
if (shouldTesteeBeLaunchedWithDartRunResident) {
368+
print(
369+
'** Shutting down resident frontend compiler that was used by VM '
370+
'Service tests',
371+
);
372+
await io.Process.run(
373+
io.Platform.executable,
374+
['compilation-server', 'shutdown'],
375+
);
376+
}
367377
if (exitCode != 0) {
368378
if (!(process.killedByTester || allowForNonZeroExitCode)) {
369379
throw 'Testee exited with unexpected exitCode: $exitCode';

0 commit comments

Comments
 (0)