[linter] Mark package_api_docs as removed

Resolves #59554

Change-Id: Ic843c827b1b7c9345132c4b8d901de040a56e1a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396780
Commit-Queue: Brian Wilkerson <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Phil Quitslund <[email protected]>

Author: parlough

CHANGELOG.md

@@ -59,10 +59,11 @@ main() {
   and with a `Flexible` widget.
 - Offer an assist to "inline" an else-block's inner if-statement with the
   else-block to read `else if`.
-  (Thanks [@FMorschel](https://github.com/FMorschel) for the above enhacements!
+  (Thanks [@FMorschel](https://github.com/FMorschel) for the above enhancements!
 - Add the experimental `specify_nonobvious_property_types` lint rule.
 - Add the experimental `omit_obvious_property_types` lint rule.
-- Deprecate the `package_api_docs` lint rule.
+- Remove the `package_api_docs` lint rule.
+- Remove the `unsafe_html` lint rule.
 
 #### Dart format
 

pkg/linter/CHANGELOG.md

@@ -1,11 +1,10 @@
 # 3.7.0-wip
 
-- deprecated lint: `package_api_docs`
+- removed lint: `package_api_docs`
+- removed lint: `unsafe_html`
 - _(soon to be)_ deprecated lint: `avoid_null_checks_in_equality_operators`
-- _(soon to be)_ deprecated lint: `unsafe_html`
 - new _(experimental)_ lint: `omit_obvious_property_types`
 - new _(experimental)_ lint: `specify_nonobvious_property_types`
-- removed lint: `unsafe_html`
 - new _(experimental)_ lint: `unsafe_variance`
 
 # 3.6.0

pkg/linter/lib/src/lint_codes.g.dart

@@ -1017,12 +1017,6 @@ class LinterLintCode extends LintCode {
     hasPublishedDocs: true,
   );
 
-  static const LintCode package_api_docs = LinterLintCode(
-    LintNames.package_api_docs,
-    "Missing documentation for public API.",
-    correctionMessage: "Try adding a documentation comment.",
-  );
-
   static const LintCode package_names = LinterLintCode(
     LintNames.package_names,
     "The package name '{0}' isn't a lower_case_with_underscores identifier.",

pkg/linter/lib/src/rules/package_api_docs.dart

@@ -6,15 +6,12 @@ import 'package:pub_semver/pub_semver.dart';
 
 import '../analyzer.dart';
 
-const _desc = r'Provide doc comments for all public APIs.';
-
 class PackageApiDocs extends LintRule {
   PackageApiDocs()
       : super(
-          name: LintNames.package_api_docs,
-          description: _desc,
-          state: State.deprecated(since: Version(3, 7, 0)),
-        );
+            name: LintNames.package_api_docs,
+            description: r'Provide doc comments for all public APIs.',
+            state: State.removed(since: Version(3, 7, 0)));
 
   @override
   LintCode get lintCode => LinterLintCode.removed_lint;

pkg/linter/lib/src/rules/unsafe_html.dart

@@ -6,14 +6,11 @@ import 'package:pub_semver/pub_semver.dart';
 
 import '../analyzer.dart';
 
-const _desc = '$_descPrefix.';
-const _descPrefix = r'Avoid unsafe HTML APIs';
-
 class UnsafeHtml extends LintRule {
   UnsafeHtml()
       : super(
             name: LintNames.unsafe_html,
-            description: _desc,
+            description: 'Avoid unsafe HTML APIs.',
             state: State.removed(since: Version(3, 7, 0)));
 
   @override

pkg/linter/messages.yaml

@@ -7401,10 +7401,11 @@ LintCode:
     correctionMessage: "Try adding a documentation comment."
     state:
       stable: "2.0"
+      removed: "3.7"
     categories: [effectiveDart, publicInterface]
     hasPublishedDocs: false
     deprecatedDetails: |-
-      **NOTE:** This lint is deprecated because it is has not
+      **NOTE:** This lint has been removed because it is has not
       been fully functional since at least Dart 2.0.
       Remove all inclusions of this lint from your analysis options.
 

pkg/linter/tool/machine/rules.json

@@ -1629,11 +1629,11 @@
       "effectiveDart",
       "publicInterface"
     ],
-    "state": "deprecated",
+    "state": "removed",
     "incompatible": [],
     "sets": [],
     "fixStatus": "noFix",
-    "details": "**NOTE:** This lint is deprecated because it is has not\nbeen fully functional since at least Dart 2.0.\nRemove all inclusions of this lint from your analysis options.\n\n**DO** provide doc comments for all public APIs.\n\nAs described in the [pub package layout doc](https://dart.dev/tools/pub/package-layout#implementation-files),\npublic APIs consist in everything in your package's `lib` folder, minus\nimplementation files in `lib/src`, adding elements explicitly exported with an\n`export` directive.\n\nFor example, given `lib/foo.dart`:\n```dart\nexport 'src/bar.dart' show Bar;\nexport 'src/baz.dart';\n\nclass Foo { }\n\nclass _Foo { }\n```\nits API includes:\n\n* `Foo` (but not `_Foo`)\n* `Bar` (exported) and\n* all *public* elements in `src/baz.dart`\n\nAll public API members should be documented with `///` doc-style comments.\n\n**BAD:**\n```dart\nclass Bar {\n  void bar();\n}\n```\n\n**GOOD:**\n```dart\n/// A Foo.\nabstract class Foo {\n  /// Start foo-ing.\n  void start() => _start();\n\n  _start();\n}\n```\n\nAdvice for writing good doc comments can be found in the\n[Doc Writing Guidelines](https://dart.dev/effective-dart/documentation).",
+    "details": "**NOTE:** This lint has been removed because it is has not\nbeen fully functional since at least Dart 2.0.\nRemove all inclusions of this lint from your analysis options.\n\n**DO** provide doc comments for all public APIs.\n\nAs described in the [pub package layout doc](https://dart.dev/tools/pub/package-layout#implementation-files),\npublic APIs consist in everything in your package's `lib` folder, minus\nimplementation files in `lib/src`, adding elements explicitly exported with an\n`export` directive.\n\nFor example, given `lib/foo.dart`:\n```dart\nexport 'src/bar.dart' show Bar;\nexport 'src/baz.dart';\n\nclass Foo { }\n\nclass _Foo { }\n```\nits API includes:\n\n* `Foo` (but not `_Foo`)\n* `Bar` (exported) and\n* all *public* elements in `src/baz.dart`\n\nAll public API members should be documented with `///` doc-style comments.\n\n**BAD:**\n```dart\nclass Bar {\n  void bar();\n}\n```\n\n**GOOD:**\n```dart\n/// A Foo.\nabstract class Foo {\n  /// Start foo-ing.\n  void start() => _start();\n\n  _start();\n}\n```\n\nAdvice for writing good doc comments can be found in the\n[Doc Writing Guidelines](https://dart.dev/effective-dart/documentation).",
     "sinceDartSdk": "2.0"
   },
   {