Elements. Migrate many analyzer resolution and diagnostics tests.

Change-Id: I28af838697c4956c0df02d860f616f694d9b982e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396200
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/analyzer_use_new_elements.txt

@@ -259,32 +259,10 @@ test/src/dart/resolution/library_import_prefix_test.dart
 test/src/dart/resolution/local_function_test.dart
 test/src/dart/resolution/local_variable_test.dart
 test/src/dart/resolution/metadata_test.dart
-test/src/dart/resolution/method_declaration_test.dart
-test/src/dart/resolution/method_invocation_test.dart
-test/src/dart/resolution/mixin_test.dart
-test/src/dart/resolution/non_nullable_test.dart
-test/src/dart/resolution/optional_const_test.dart
 test/src/dart/resolution/prefix_element_test.dart
-test/src/dart/resolution/prefixed_identifier_test.dart
-test/src/dart/resolution/property_access_test.dart
 test/src/dart/resolution/resolution.dart
 test/src/dart/resolution/scope_test.dart
-test/src/dart/resolution/simple_identifier_test.dart
 test/src/dart/resolution/super_formal_parameter_test.dart
-test/src/dart/resolution/top_level_variable_test.dart
-test/src/dart/resolution/top_type_inference_test.dart
-test/src/dart/resolution/type_inference/function_expression_test.dart
-test/src/dart/resolution/type_inference/inference_update_1_test.dart
-test/src/dart/resolution/type_inference/local_variable_test.dart
-test/src/dart/resolution/type_inference/tear_off_test.dart
-test/src/diagnostics/conflicting_generic_interfaces_test.dart
-test/src/diagnostics/instance_access_to_static_member_test.dart
-test/src/diagnostics/invalid_uri_test.dart
-test/src/diagnostics/mixin_application_not_implemented_interface_test.dart
-test/src/diagnostics/mock_sdk_test.dart
-test/src/diagnostics/referenced_before_declaration_test.dart
-test/src/diagnostics/top_level_instance_getter_test.dart
-test/src/diagnostics/type_argument_not_matching_bounds_test.dart
 test/src/lint/lint_rule_test.dart
 test/src/lint/linter/linter_context_impl_test.dart
 test/src/services/top_level_declarations_test.dart

pkg/analyzer/test/src/dart/resolution/method_declaration_test.dart

@@ -25,10 +25,14 @@ class A {
 }
 ''');
 
-    assertElement(
-      findNode.simple('foo + 1'),
-      findElement.getter('foo', of: 'A'),
-    );
+    var node = findNode.simple('foo + 1');
+    assertResolvedNodeText(node, r'''
+SimpleIdentifier
+  token: foo
+  staticElement: <testLibraryFragment>::@class::A::@getter::foo
+  element: <testLibraryFragment>::@class::A::@getter::foo#element
+  staticType: int
+''');
   }
 
   test_formalParameterScope_type() async {
@@ -42,15 +46,23 @@ class B {
 }
 ''');
 
-    assertElement(
-      findNode.namedType('a a'),
-      findElement.class_('a'),
-    );
+    var node1 = findNode.namedType('a a');
+    assertResolvedNodeText(node1, r'''
+NamedType
+  name: a
+  element: <testLibraryFragment>::@class::a
+  element2: <testLibrary>::@class::a
+  type: a
+''');
 
-    assertElement(
-      findNode.simple('a;'),
-      findElement.parameter('a'),
-    );
+    var node2 = findNode.simple('a;');
+    assertResolvedNodeText(node2, r'''
+SimpleIdentifier
+  token: a
+  staticElement: <testLibraryFragment>::@class::B::@method::bar::@parameter::a
+  element: <testLibraryFragment>::@class::B::@method::bar::@parameter::a#element
+  staticType: a
+''');
   }
 
   test_formalParameterScope_wildcardVariable() async {

pkg/analyzer/test/src/dart/resolution/method_invocation_test.dart

@@ -7724,10 +7724,11 @@ void f() {
 }
 ''');
 
-    var element = findNode.simple('a:').staticElement!;
     // See https://github.com/dart-lang/sdk/issues/54669 for why we check for
     // isNotNull despite #50660 suggesting the source would be null.
-    expect(element.source, isNotNull);
+    var element = findNode.simple('a:').element!;
+    var libraryFragment2 = element.firstFragment.libraryFragment!;
+    expect(libraryFragment2.source, isNotNull);
   }
 
   test_remainder_int_context_cascaded() async {

pkg/analyzer/test/src/dart/resolution/mixin_test.dart

@@ -3,7 +3,6 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:analyzer/src/error/codes.dart';
-import 'package:test/test.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 
 import 'context_collection_resolution.dart';
@@ -62,69 +61,15 @@ const a = 0;
 mixin M {}
 ''');
 
-    var aRef = findNode.commentReference('a]').expression;
-    assertElement(aRef, findElement.topGet('a'));
-    assertTypeNull(aRef);
-  }
-
-  test_element() async {
-    await assertNoErrorsInCode(r'''
-mixin M {}
-''');
-
-    var mixin = findNode.mixin('mixin M');
-    var element = findElement.mixin('M');
-    assertElement(mixin, element);
-
-    expect(element.typeParameters, isEmpty);
-
-    expect(element.supertype, isNull);
-    expect(element.thisType.isDartCoreObject, isFalse);
-
-    assertElementTypes(
-      element.superclassConstraints,
-      ['Object'],
-    );
-    assertElementTypes(element.interfaces, []);
-  }
-
-  test_element_allSupertypes() async {
-    await assertNoErrorsInCode(r'''
-class A {}
-class B {}
-class C {}
-
-mixin M1 on A, B {}
-mixin M2 on A implements B, C {}
-''');
-
-    assertElementTypes(
-      findElement.mixin('M1').allSupertypes,
-      ['Object', 'A', 'B'],
-    );
-    assertElementTypes(
-      findElement.mixin('M2').allSupertypes,
-      ['Object', 'A', 'B', 'C'],
-    );
-  }
-
-  test_element_allSupertypes_generic() async {
-    await assertNoErrorsInCode(r'''
-class A<T, U> {}
-class B<T> extends A<int, T> {}
-
-mixin M1 on A<int, double> {}
-mixin M2 on B<String> {}
+    var node = findNode.commentReference('a]');
+    assertResolvedNodeText(node, r'''
+CommentReference
+  expression: SimpleIdentifier
+    token: a
+    staticElement: <testLibraryFragment>::@getter::a
+    element: <testLibraryFragment>::@getter::a#element
+    staticType: null
 ''');
-
-    assertElementTypes(
-      findElement.mixin('M1').allSupertypes,
-      ['Object', 'A<int, double>'],
-    );
-    assertElementTypes(
-      findElement.mixin('M2').allSupertypes,
-      ['Object', 'A<int, String>', 'B<String>'],
-    );
   }
 
   test_field() async {
@@ -249,16 +194,18 @@ const a = 0;
 mixin M {}
 ''');
 
-    var a = findElement.topGet('a');
-    var element = findElement.mixin('M');
-
-    var metadata = element.metadata;
-    expect(metadata, hasLength(1));
-    expect(metadata[0].element, same(a));
-
-    var annotation = findNode.annotation('@a');
-    assertElement(annotation, a);
-    expect(annotation.elementAnnotation, same(metadata[0]));
+    var node = findNode.annotation('@a');
+    assertResolvedNodeText(node, r'''
+Annotation
+  atSign: @
+  name: SimpleIdentifier
+    token: a
+    staticElement: <testLibraryFragment>::@getter::a
+    element: <testLibraryFragment>::@getter::a#element
+    staticType: null
+  element: <testLibraryFragment>::@getter::a
+  element2: <testLibraryFragment>::@getter::a#element
+''');
   }
 
   test_method() async {
@@ -401,9 +348,20 @@ mixin M on A {
 class X extends A with M {}
 ''');
 
-    var access = findNode.propertyAccess('super.foo;');
-    assertElement(access, findElement.getter('foo'));
-    assertType(access, 'int');
+    var node = findNode.propertyAccess('super.foo;');
+    assertResolvedNodeText(node, r'''
+PropertyAccess
+  target: SuperExpression
+    superKeyword: super
+    staticType: M
+  operator: .
+  propertyName: SimpleIdentifier
+    token: foo
+    staticElement: <testLibraryFragment>::@class::A::@getter::foo
+    element: <testLibraryFragment>::@class::A::@getter::foo#element
+    staticType: int
+  staticType: int
+''');
   }
 
   test_superInvocation_method() async {