DAS plugins: report early when a fix or assist does not have a fixKind or assistKind

Change-Id: I83a147adc4740d1a8891faa06d35c4901cf568b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417943
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: srawlins

pkg/analysis_server_plugin/lib/src/registry.dart

@@ -2,6 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:analysis_server_plugin/edit/dart/correction_producer.dart';
 import 'package:analysis_server_plugin/registry.dart';
 import 'package:analysis_server_plugin/src/correction/assist_generators.dart';
 import 'package:analysis_server_plugin/src/correction/fix_generators.dart';
@@ -16,11 +17,29 @@ final class PluginRegistryImpl implements PluginRegistry {
 
   @override
   void registerAssist(ProducerGenerator generator) {
+    var producer = generator(context: StubCorrectionProducerContext.instance);
+    if (producer.assistKind == null) {
+      throw ArgumentError.value(
+        generator,
+        'generator',
+        "Assist producer '${producer.runtimeType}' must declare a non-null "
+            "'assistKind'.",
+      );
+    }
     registeredAssistGenerators.registerGenerator(generator);
   }
 
   @override
   void registerFixForRule(LintCode code, ProducerGenerator generator) {
+    var producer = generator(context: StubCorrectionProducerContext.instance);
+    if (producer.fixKind == null) {
+      throw ArgumentError.value(
+        generator,
+        'generator',
+        "Fix producer '${producer.runtimeType}' must declare a non-null "
+            "'fixKind'.",
+      );
+    }
     registeredFixGenerators.registerFixForLint(code, generator);
   }
 

pkg/analysis_server_plugin/test/src/plugin_server_error_test.dart

@@ -158,6 +158,26 @@ plugins:
           .having((e) => e.stackTrace, 'stackTrace', isNotNull),
     );
   }
+
+  Future<void> test_registerAssistWithoutAssistKind() async {
+    expect(
+      () => pluginServer = PluginServer(
+        resourceProvider: resourceProvider,
+        plugins: [_PluginWithAssistWithNoAssistKind()],
+      ),
+      throwsArgumentError,
+    );
+  }
+
+  Future<void> test_registerFixWithoutFixKind() async {
+    expect(
+      () => pluginServer = PluginServer(
+        resourceProvider: resourceProvider,
+        plugins: [_PluginWithFixWithNoFixKind()],
+      ),
+      throwsArgumentError,
+    );
+  }
 }
 
 class _FixThrowsAsyncErrorPlugin extends Plugin {
@@ -176,6 +196,33 @@ class _FixThrowsSyncErrorPlugin extends Plugin {
   }
 }
 
+/// A correction producer with a `null` `fixKind`.
+class _MissingFixKindFix extends ResolvedCorrectionProducer {
+  _MissingFixKindFix({required super.context});
+
+  @override
+  CorrectionApplicability get applicability =>
+      CorrectionApplicability.acrossFiles;
+
+  @override
+  Future<void> compute(ChangeBuilder builder) async {}
+}
+
+class _PluginWithAssistWithNoAssistKind extends Plugin {
+  @override
+  void register(PluginRegistry registry) {
+    registry.registerAssist(_ThrowsSyncErrorFix.new);
+  }
+}
+
+class _PluginWithFixWithNoFixKind extends Plugin {
+  @override
+  void register(PluginRegistry registry) {
+    registry.registerWarningRule(NoBoolsRule());
+    registry.registerFixForRule(NoBoolsRule.code, _MissingFixKindFix.new);
+  }
+}
+
 class _RuleThrowsAsyncErrorPlugin extends Plugin {
   @override
   void register(PluginRegistry registry) {