DAS plugins: Use a caret dependency on the analysis_server_plugin package

Also stop generating that version number. This code that used the
version of the analysis_server_plugin package in the Dart SDK was
defensive, but is now seen as overly restrictive; it does not allow
bug fixes to be used, to no benefit.

The only reason to bump the minimum version here is if there is a
change made to the API spec which is breaking, which requires a new
version of the package in order to communicate with DAS.

Change-Id: I13dab8135a8ec754aa993509656d871a547cb9cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/446686
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: srawlins

pkg/analysis_server/lib/src/plugin2/analyzer_version.g.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:analysis_server/src/plugin2/analyzer_version.g.dart';
 import 'package:analyzer/dart/analysis/analysis_options.dart';
 
 /// This class can generate various files to make up the shared plugin package.
@@ -64,7 +63,9 @@ version: 0.0.1
 environment:
   sdk: ^3.6.0
 dependencies:
-  analysis_server_plugin: '$analysisServerPluginVersion'
+  # The version of the analysis_server_plugin package that matches the protocol
+  # used by the active analysis_server.
+  analysis_server_plugin: ^0.2.0
 ''');
 
     for (var configuration in _pluginConfigurations) {

pkg/analysis_server/lib/src/plugin2/generator.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:analysis_server/src/plugin2/analyzer_version.g.dart';
 import 'package:analysis_server/src/plugin2/generator.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:test/test.dart';
@@ -68,8 +67,6 @@ import 'package:no_ints/main.dart' as no_ints;
     expect(
       pluginPackageGenerator.generatePubspec(),
       contains('''
-dependencies:
-  analysis_server_plugin: '$analysisServerPluginVersion'
   no_bools:
     git:
       url: https://example.com/example.git
@@ -91,8 +88,6 @@ dependencies:
     expect(
       pluginPackageGenerator.generatePubspec(),
       contains('''
-dependencies:
-  analysis_server_plugin: '$analysisServerPluginVersion'
   no_bools:
     path: ../no_bools_plugin
   no_ints:
@@ -126,8 +121,6 @@ environment:
     expect(
       pluginPackageGenerator.generatePubspec(),
       contains('''
-dependencies:
-  analysis_server_plugin: '$analysisServerPluginVersion'
   no_bools: ^1.0.0
   no_ints: ^1.2.0
 '''),