Elements. Migrate ConvertIntoIsNotEmpty.

Change-Id: I4e41db2de0ab39f969945582ebbc63bedbc90e30
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/389763
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analysis_server/analyzer_use_new_elements.txt

@@ -269,6 +269,7 @@ lib/src/services/correction/dart/convert_into_final_field.dart
 lib/src/services/correction/dart/convert_into_for_index.dart
 lib/src/services/correction/dart/convert_into_getter.dart
 lib/src/services/correction/dart/convert_into_is_not.dart
+lib/src/services/correction/dart/convert_into_is_not_empty.dart
 lib/src/services/correction/dart/convert_map_from_iterable_to_for_literal.dart
 lib/src/services/correction/dart/convert_part_of_to_uri.dart
 lib/src/services/correction/dart/convert_quotes.dart
@@ -1515,4 +1516,4 @@ tool/spec/codegen_protocol_constants.dart
 tool/spec/from_html.dart
 tool/spec/generate_all.dart
 tool/spec/implied_types.dart
-tool/spec/to_html.dart
+tool/spec/to_html.dart

pkg/analysis_server/lib/src/services/correction/dart/convert_into_is_not_empty.dart

@@ -45,14 +45,14 @@ class ConvertIntoIsNotEmpty extends ResolvedCorrectionProducer {
       return;
     }
     // should be "isEmpty"
-    var propertyElement = isEmptyIdentifier.staticElement;
+    var propertyElement = isEmptyIdentifier.element;
     if (propertyElement == null || 'isEmpty' != propertyElement.name) {
       return;
     }
     // should have "isNotEmpty"
-    var propertyTarget = propertyElement.enclosingElement3;
+    var propertyTarget = propertyElement.enclosingElement2;
     if (propertyTarget == null ||
-        getChildren(propertyTarget, 'isNotEmpty').isEmpty) {
+        getChildren2(propertyTarget, 'isNotEmpty').isEmpty) {
       return;
     }
     // should be in PrefixExpression

pkg/analysis_server/lib/src/services/search/hierarchy.dart

@@ -22,6 +22,18 @@ List<Element> getChildren(Element parent, [String? name]) {
   return children;
 }
 
+/// Returns direct children of [parent].
+List<Element2> getChildren2(Element2 parent, [String? name]) {
+  var children = <Element2>[];
+  visitChildren2(parent, (element) {
+    if (name == null || _getBaseName2(element) == name) {
+      children.add(element);
+    }
+    return false;
+  });
+  return children;
+}
+
 /// Returns direct non-synthetic children of the given [InterfaceElement].
 ///
 /// Includes: fields, accessors and methods.
@@ -311,3 +323,11 @@ String? _getBaseName(Element element) {
   }
   return element.name;
 }
+
+String? _getBaseName2(Element2 element) {
+  if (element is SetterElement) {
+    var name = element.name;
+    return name.substring(0, name.length - 1);
+  }
+  return element.name;
+}