[CFE] Textual outline: allow formatter crash in experiment not enabled

Change-Id: Idefb2647592e359388901edd0218b21d511fd7bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/412580
Commit-Queue: Jens Johansen <[email protected]>
Reviewed-by: Chloe Stefantsova <[email protected]>

Author: jensjoha

pkg/front_end/test/textual_outline_suite.dart

@@ -8,7 +8,8 @@ import 'dart:typed_data';
 import 'package:_fe_analyzer_shared/src/scanner/abstract_scanner.dart'
     show ScannerConfiguration;
 import 'package:_fe_analyzer_shared/src/scanner/token.dart';
-import 'package:dart_style/dart_style.dart' show DartFormatter;
+import 'package:dart_style/dart_style.dart'
+    show DartFormatter, FormatterException;
 import 'package:front_end/src/api_prototype/experimental_flags.dart';
 import 'package:front_end/src/util/textual_outline.dart';
 import 'package:testing/testing.dart'
@@ -110,6 +111,17 @@ class TextualOutline extends Step<TestDescription, TestDescription, Context> {
     Map<ExperimentalFlag, bool> experimentalFlagsExplicit =
         folderOptions.computeExplicitExperimentalFlags(const {});
 
+    bool allowFormatterCrash = false;
+    for (MapEntry<ExperimentalFlag, bool> entry
+        in experimentalFlagsExplicit.entries) {
+      if (entry.value) {
+        if (!entry.key.isEnabledByDefault) {
+          allowFormatterCrash = true;
+          break;
+        }
+      }
+    }
+
     Uint8List bytes = new File.fromUri(description.uri).readAsBytesSync();
     for (bool modelled in [false, true]) {
       TextualOutlineInfoForTesting info = new TextualOutlineInfoForTesting();
@@ -166,6 +178,13 @@ class TextualOutline extends Step<TestDescription, TestDescription, Context> {
         } catch (e, st) {
           formatterException = e;
           formatterExceptionSt = st;
+          if (e is FormatterException) {
+            for (var error in e.errors) {
+              if (error.errorCode.name == "EXPERIMENT_NOT_ENABLED") {
+                allowFormatterCrash = true;
+              }
+            }
+          }
         }
       }
 
@@ -184,22 +203,12 @@ class TextualOutline extends Step<TestDescription, TestDescription, Context> {
             null, context.expectationSet["UnknownChunk"], description.uri);
       }
 
-      if (formatterException != null && !info.hasParserErrors) {
-        bool hasUnreleasedExperiment = false;
-        for (MapEntry<ExperimentalFlag, bool> entry
-            in experimentalFlagsExplicit.entries) {
-          if (entry.value) {
-            if (!entry.key.isEnabledByDefault) {
-              hasUnreleasedExperiment = true;
-              break;
-            }
-          }
-        }
-        if (!hasUnreleasedExperiment) {
-          return new Result(null, context.expectationSet["FormatterCrash"],
-              formatterException,
-              trace: formatterExceptionSt);
-        }
+      if (formatterException != null &&
+          !info.hasParserErrors &&
+          !allowFormatterCrash) {
+        return new Result(
+            null, context.expectationSet["FormatterCrash"], formatterException,
+            trace: formatterExceptionSt);
       }
     }
 

pkg/front_end/testcases/coverage/metadata_test.dart.textual_outline_modelled.expect

@@ -0,0 +1,10 @@
+// @dart = 2.12
+
+class C<T> {
+  const C();
+}
+
+@C()
+@C<dynamic>()
+@C<int>()
+void foo() {}

pkg/front_end/testcases/general/base_class_declaration.dart.textual_outline_modelled.expect

@@ -0,0 +1,9 @@
+// @dart = 2.19
+
+abstract base class B {}
+
+base class A {}
+
+base class C = Object with M;
+
+base mixin M {}

pkg/front_end/testcases/general/enum_super_constructor.dart.textual_outline_modelled.expect

@@ -0,0 +1,7 @@
+// @dart = 2.16
+
+enum A { a; A() : super(); }
+
+enum B { b; const B() : super(); }
+
+main() {}

pkg/front_end/testcases/general/extension_type_declaration_disabled.dart.textual_outline_modelled.expect

@@ -0,0 +1,5 @@
+// @dart = 2.18
+
+extension type ExtensionType1(int it) {}
+
+extension type ExtensionType2<T>._(int it) implements int, ExtensionType1 {}

pkg/front_end/testcases/general/final_class_declaration.dart.textual_outline_modelled.expect

@@ -0,0 +1,9 @@
+// @dart = 2.19
+
+abstract final class B {}
+
+final class A {}
+
+final class C = Object with M;
+
+mixin M {}

pkg/front_end/testcases/general/interface_class_declaration.dart.textual_outline_modelled.expect

@@ -0,0 +1,9 @@
+// @dart = 2.19
+
+abstract interface class B {}
+
+interface class A {}
+
+interface class C = Object with M;
+
+mixin M {}

pkg/front_end/testcases/general/issue48487.dart.textual_outline_modelled.expect

@@ -0,0 +1,5 @@
+// @dart = 2.16
+
+enum T { t(); void test() { print("Success"); } }
+
+void main() {}

pkg/front_end/testcases/general/issue48487b.dart.textual_outline_modelled.expect

@@ -0,0 +1,5 @@
+// @dart = 2.16
+
+enum T { t; const T.named(); }
+
+void main() {}

pkg/front_end/testcases/general/issue_46886.dart.textual_outline_modelled.expect

@@ -0,0 +1,14 @@
+// @dart = 2.13
+
+abstract class Bar implements List<List<List<String>>> {}
+
+class Foo {
+  Foo operator >>>(_) => this;
+}
+
+extension on Symbol {
+  String call(_) => "Called";
+  String operator >(_) => "Greater Than used";
+}
+
+main() {}