Skip to content

Commit 8121b02

Browse files
scheglovCommit Queue
authored andcommitted
Elements. Migrate test/support/abstract_context.dart
Change-Id: I75004a7f979315b838d2699a0dcdd8df13b2864d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/403702 Reviewed-by: Phil Quitslund <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
1 parent f3e68f2 commit 8121b02

File tree

3 files changed

+3
-50
lines changed

3 files changed

+3
-50
lines changed

pkg/analyzer_plugin/analyzer_use_new_elements.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,5 @@ lib/utilities/range_factory.dart
1515
test/src/utilities/change_builder/change_builder_dart_test.dart
1616
test/src/utilities/completion/completion_target_test.dart
1717
test/src/utilities/visitors/local_declaration_visitor_test.dart
18-
test/support/abstract_context.dart
19-
test/support/abstract_single_unit.dart
2018
test/utilities/analyzer_converter_test.dart
2119
test/utilities/range_factory_test.dart

pkg/analyzer_plugin/test/support/abstract_context.dart

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ import 'package:analyzer/dart/analysis/analysis_context.dart';
66
import 'package:analyzer/dart/analysis/analysis_context_collection.dart';
77
import 'package:analyzer/dart/analysis/results.dart';
88
import 'package:analyzer/dart/analysis/session.dart';
9-
import 'package:analyzer/dart/element/element.dart';
10-
import 'package:analyzer/dart/element/visitor.dart';
119
import 'package:analyzer/file_system/file_system.dart';
1210
import 'package:analyzer/src/dart/analysis/analysis_context_collection.dart';
1311
import 'package:analyzer/src/dart/analysis/byte_store.dart';
@@ -20,24 +18,6 @@ import 'package:analyzer_utilities/test/mock_packages/mock_packages.dart';
2018
import 'package:linter/src/rules.dart';
2119
import 'package:meta/meta.dart';
2220

23-
/// Finds an [Element] with the given [name].
24-
Element? findChildElement(Element root, String name, [ElementKind? kind]) {
25-
Element? result;
26-
root.accept(_ElementVisitorFunctionWrapper((Element element) {
27-
if (element.name != name) {
28-
return;
29-
}
30-
if (kind != null && element.kind != kind) {
31-
return;
32-
}
33-
result = element;
34-
}));
35-
return result;
36-
}
37-
38-
/// A function to be called for every [Element].
39-
typedef _ElementVisitorFunction = void Function(Element element);
40-
4121
class AbstractContextTest with MockPackagesMixin, ResourceProviderMixin {
4222
final ByteStore _byteStore = MemoryByteStore();
4323

@@ -200,17 +180,3 @@ class AbstractContextTest with MockPackagesMixin, ResourceProviderMixin {
200180
);
201181
}
202182
}
203-
204-
/// Wraps the given [_ElementVisitorFunction] into an instance of
205-
/// [engine.GeneralizingElementVisitor].
206-
class _ElementVisitorFunctionWrapper extends GeneralizingElementVisitor {
207-
final _ElementVisitorFunction function;
208-
209-
_ElementVisitorFunctionWrapper(this.function);
210-
211-
@override
212-
void visitElement(Element element) {
213-
function(element);
214-
super.visitElement(element);
215-
}
216-
}

pkg/analyzer_plugin/test/support/abstract_single_unit.dart

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,14 @@
44

55
import 'package:analyzer/dart/analysis/results.dart';
66
import 'package:analyzer/dart/ast/ast.dart';
7-
import 'package:analyzer/dart/element/element.dart';
7+
import 'package:analyzer/dart/element/element2.dart';
88
import 'package:analyzer/error/error.dart';
99
import 'package:analyzer/src/dart/ast/element_locator.dart';
1010
import 'package:analyzer/src/dart/ast/utilities.dart';
1111
import 'package:analyzer/src/error/codes.dart';
1212
import 'package:analyzer/src/test_utilities/find_element.dart';
1313
import 'package:analyzer/src/test_utilities/find_element2.dart';
1414
import 'package:analyzer/src/test_utilities/find_node.dart';
15-
import 'package:analyzer/src/utilities/extensions/element.dart';
1615
import 'package:test/test.dart';
1716

1817
import 'abstract_context.dart';
@@ -62,25 +61,15 @@ class AbstractSingleUnitTest extends AbstractContextTest {
6261
return findNodeAtOffset(offset, predicate);
6362
}
6463

65-
Element? findNodeElementAtString(
64+
Element2? findNodeElementAtString(
6665
String search, [
6766
bool Function(AstNode)? predicate,
6867
]) {
6968
var node = findNodeAtString(search, predicate);
7069
if (node == null) {
7170
return null;
7271
}
73-
74-
switch (node) {
75-
case ExportDirective():
76-
return node.element;
77-
case ImportDirective():
78-
return node.element;
79-
case PartOfDirective():
80-
return node.element;
81-
default:
82-
return ElementLocator.locate2(node).asElement;
83-
}
72+
return ElementLocator.locate2(node);
8473
}
8574

8675
int findOffset(String search) {

0 commit comments

Comments
 (0)