Skip to content

Commit 81a7f3e

Browse files
rmacnak-googleCommit Queue
authored andcommitted
[vm, gc] Remove some dead code.
- Serial scavenge - Serial marking - Redudant safepoint operation scope - Redudant Thread::Current - Unused HandleVisitor::thread_ - Profile tag updates in PRODUCT mode - Freelist printing TEST=ci Change-Id: I2de4c50df37c7ebe9d267514bcbd548dd61a5a57 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/426582 Commit-Queue: Ryan Macnak <[email protected]> Reviewed-by: Alexander Aprelev <[email protected]>
1 parent c4c730f commit 81a7f3e

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+238
-554
lines changed

runtime/tests/vm/dart/gc/fragmentation_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
// VMOptions=--concurrent_mark --use_compactor
2020
// VMOptions=--concurrent_mark --use_compactor --force_evacuation
2121
// VMOptions=--scavenger_tasks=-1
22-
// VMOptions=--scavenger_tasks=0
2322
// VMOptions=--scavenger_tasks=1
2423
// VMOptions=--scavenger_tasks=2
2524
// VMOptions=--profiler --dontneed_on_sweep

runtime/tests/vm/dart/gc/fragmentation_typed_data_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
// VMOptions=--concurrent_mark --use_compactor
1414
// VMOptions=--concurrent_mark --use_compactor --force_evacuation
1515
// VMOptions=--scavenger_tasks=-1
16-
// VMOptions=--scavenger_tasks=0
1716
// VMOptions=--scavenger_tasks=1
1817
// VMOptions=--scavenger_tasks=2
1918
// VMOptions=--profiler --dontneed_on_sweep

runtime/tests/vm/dart/gc/scavenger_abort_test.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
// VMOptions=
6-
// VMOptions=--scavenger_tasks=0
7-
85
import "dart:io";
96
import "package:expect/expect.dart";
107

runtime/tests/vm/dart/gc/splay_c_finalizer_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
// VMOptions=--concurrent_mark --use_compactor
1919
// VMOptions=--concurrent_mark --use_compactor --force_evacuation
2020
// VMOptions=--scavenger_tasks=-1
21-
// VMOptions=--scavenger_tasks=0
2221
// VMOptions=--scavenger_tasks=1
2322
// VMOptions=--scavenger_tasks=2
2423
// VMOptions=--verify_before_gc

runtime/tests/vm/dart/gc/splay_dart_finalizer_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
// VMOptions=--concurrent_mark --use_compactor
1919
// VMOptions=--concurrent_mark --use_compactor --force_evacuation
2020
// VMOptions=--scavenger_tasks=-1
21-
// VMOptions=--scavenger_tasks=0
2221
// VMOptions=--scavenger_tasks=1
2322
// VMOptions=--scavenger_tasks=2
2423
// VMOptions=--verify_before_gc

runtime/tests/vm/dart/gc/splay_ephemeron_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
// VMOptions=--concurrent_mark --use_compactor
2121
// VMOptions=--concurrent_mark --use_compactor --force_evacuation
2222
// VMOptions=--scavenger_tasks=-1
23-
// VMOptions=--scavenger_tasks=0
2423
// VMOptions=--scavenger_tasks=1
2524
// VMOptions=--scavenger_tasks=2
2625
// VMOptions=--verify_before_gc

runtime/tests/vm/dart/gc/splay_isolates_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
// VMOptions=--profiler --concurrent_mark --concurrent_sweep
1818
// VMOptions=--profiler --concurrent_mark --use_compactor
1919
// VMOptions=--profiler --concurrent_mark --use_compactor --force_evacuation
20-
// VMOptions=--profiler --scavenger_tasks=0
2120
// VMOptions=--profiler --verify_before_gc
2221
// VMOptions=--profiler --verify_after_gc
2322
// VMOptions=--profiler --verify_before_gc --verify_after_gc

runtime/tests/vm/dart/gc/splay_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
// VMOptions=--profiler --concurrent_mark --use_compactor
1919
// VMOptions=--profiler --concurrent_mark --use_compactor --force_evacuation
2020
// VMOptions=--profiler --scavenger_tasks=-1
21-
// VMOptions=--profiler --scavenger_tasks=0
2221
// VMOptions=--profiler --scavenger_tasks=1
2322
// VMOptions=--profiler --scavenger_tasks=2
2423
// VMOptions=--profiler --verify_before_gc

runtime/tests/vm/dart/gc/splay_weak_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
// VMOptions=--concurrent_mark --use_compactor
1919
// VMOptions=--concurrent_mark --use_compactor --force_evacuation
2020
// VMOptions=--scavenger_tasks=-1
21-
// VMOptions=--scavenger_tasks=0
2221
// VMOptions=--scavenger_tasks=1
2322
// VMOptions=--scavenger_tasks=2
2423
// VMOptions=--verify_before_gc

runtime/vm/bootstrap.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ static ErrorPtr BootstrapFromKernelSingleProgram(
113113
Thread* thread,
114114
std::unique_ptr<kernel::Program> program) {
115115
Zone* zone = thread->zone();
116-
LongJumpScope jump;
116+
LongJumpScope jump(thread);
117117
if (DART_SETJMP(*jump.Set()) == 0) {
118118
kernel::KernelLoader loader(program.get(), /*uri_to_source_table=*/nullptr);
119119

0 commit comments

Comments
 (0)