[CFE] Update flutter_gallery_leak_tester after flutter started using workspaces

The weekly bot failed because flutter started using workspaces.
This fixes the issue (by using the code where it is instead of copying
it) and removes some no-longer-needed hack for shoterning the file
paths.

Change-Id: Ib10f0703566d89f53291f4ce543bfe4c342b7050
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433680
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Jens Johansen <[email protected]>

Author: jensjoha

pkg/front_end/test/flutter_gallery_leak_tester.dart

@@ -59,21 +59,13 @@ Future<void> main(List<String> args) async {
     throw "File not found: $frontendServerStarter";
   }
 
-  Directory gallery = new Directory("$rootPath/gallery");
-  if (!gallery.existsSync()) {
-    print("Gallery not found... Copying from flutter dir.");
-
-    Directory galleryFlutterDev =
-        new Directory("$rootPath/flutter/dev/integration_tests/new_gallery");
-
-    // Copy it.
-    Process process = await Process.start(
-        "cp", ["-r", galleryFlutterDev.path, "$rootPath/gallery"]);
-    int processExitCode = await process.exitCode;
-    print("Exit code from cp: $processExitCode");
+  File packageConfig =
+      new File("$rootPath/flutter/.dart_tool/package_config.json");
 
-    process = await Process.start("../flutter/bin/flutter", ["pub", "get"],
-        workingDirectory: "$rootPath/gallery/");
+  if (!packageConfig.existsSync()) {
+    // If the package_config doesn't exist we should run pub get.
+    Process process = await Process.start("bin/flutter", ["pub", "get"],
+        workingDirectory: "$rootPath/flutter/");
     process.stdout
         .transform(utf8.decoder)
         .transform(new LineSplitter())
@@ -86,59 +78,12 @@ Future<void> main(List<String> args) async {
         .listen((line) {
       print("flutter stderr> $line");
     });
-    processExitCode = await process.exitCode;
+    int processExitCode = await process.exitCode;
     print("Exit code from flutter: $processExitCode");
-
-    // Attempt to hack around strings being truncated to 128 bytes in heap dumps
-    // https://github.com/dart-lang/sdk/blob/c59cdee365b94ce066344840f9e3412d642019b5/runtime/vm/object_graph.cc#L809
-    // (pub paths can become too long, so two distinct files will look to have
-    // the same url and thus give a false positive).
-    Uri pubDirUri = Uri.parse("file://${Platform.environment['HOME']}/"
-        ".pub-cache/hosted/pub.dev/");
-    Directory pubDir = new Directory.fromUri(pubDirUri);
-    if (!pubDir.existsSync()) {
-      File galleryPackageConfig =
-          new File("$rootPath/gallery/.dart_tool/package_config.json");
-      String? packagesData;
-      if (galleryPackageConfig.existsSync()) {
-        packagesData = galleryPackageConfig.readAsStringSync();
-      }
-
-      throw "Expected to find $pubDir but didn't.\n"
-          "Content of packages file (${packagesData.runtimeType}): "
-          "$packagesData";
-    }
-
-    File galleryPackageConfig =
-        new File("$rootPath/gallery/.dart_tool/package_config.json");
-    if (!galleryPackageConfig.existsSync()) {
-      throw "Didn't find $galleryPackageConfig";
-    }
-    String data = galleryPackageConfig.readAsStringSync();
-    data = data.replaceAll(pubDirUri.toString(), "../pub/");
-    galleryPackageConfig.writeAsStringSync(data);
-
-    process = await Process.start("ln", ["-s", pubDir.path, "pub"],
-        workingDirectory: "$rootPath/gallery/");
-    process.stdout
-        .transform(utf8.decoder)
-        .transform(new LineSplitter())
-        .listen((line) {
-      print("ln stdout> $line");
-    });
-    process.stderr
-        .transform(utf8.decoder)
-        .transform(new LineSplitter())
-        .listen((line) {
-      print("ln stderr> $line");
-    });
-    processExitCode = await process.exitCode;
-    print("Exit code from ln: $processExitCode");
   }
 
-  File packageConfig =
-      new File("$rootPath/gallery/.dart_tool/package_config.json");
   if (!packageConfig.existsSync()) {
+    // If it still doesn't exist something is wrong.
     throw "Didn't find $packageConfig";
   }
 
@@ -179,7 +124,7 @@ Future<void> main(List<String> args) async {
     "--output-dill",
     "$rootPath/flutter_server_tmp.dill",
     "--packages",
-    "$rootPath/gallery/.dart_tool/package_config.json",
+    packageConfig.path,
     "-Ddart.vm.profile=false",
     "-Ddart.vm.product=false",
     "--enable-asserts",