Skip to content

Commit 81c3a50

Browse files
scheglovCommit Queue
authored andcommitted
Fine. Refactor LibraryManifestBuilder into multiple methods.
There are no functional changes (as evident from no changes to existing tests). But I noticed that we don't have tests for reusing IDs for instance getters inherited inside the same library cycles, so I added related tests. Change-Id: I86ef590579e0cde879a32d1ab9643edb58f643eb Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/417321 Commit-Queue: Konstantin Shcheglov <[email protected]> Reviewed-by: Paul Berry <[email protected]>
1 parent 3830835 commit 81c3a50

File tree

3 files changed

+360
-165
lines changed

3 files changed

+360
-165
lines changed

pkg/analyzer/lib/src/dart/analysis/library_context.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,7 @@ class LibraryContext {
224224
newLibraryManifests = LibraryManifestBuilder(
225225
elementFactory: elementFactory,
226226
inputLibraries: cycle.libraries,
227-
inputLibraryManifests: inputLibraryManifests,
228-
requirementsManifest: requirementsManifest,
227+
inputManifests: inputLibraryManifests,
229228
).computeManifests(
230229
performance: performance,
231230
);

0 commit comments

Comments
 (0)