[model] Check setters of late lower fields in overrides

This CL includes the setters induced by late lower fields into the
override checks. Due to this change the erroneous overrides will be
marked as such.

Change-Id: Ie1ca9e6ab7e55c076c713b55dc85c6284af45ffe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/426100
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>

Author: chloestefantsova

pkg/front_end/lib/src/source/source_class_builder.dart

@@ -1442,7 +1442,7 @@ class SourceClassBuilder extends ClassBuilderImpl
               !declaredMember.isConst) ||
           declaredMember is Procedure && declaredMember.isSetter;
       bool interfaceMemberHasSetter = (interfaceMember is Field &&
-              !interfaceMember.isFinal &&
+              !(interfaceMember.isFinal && !interfaceMember.isLate) &&
               !interfaceMember.isConst) ||
           interfaceMember is Procedure && interfaceMember.isSetter;
       if (declaredMemberHasGetter && interfaceMemberHasGetter) {

pkg/front_end/testcases/getter_setter_error/pre_feature/getter_vs_setter_type_late.dart.strong.expect

@@ -9,6 +9,14 @@ library;
 //   late final int? property6;
 //                   ^^^^^^^^^
 //
+// pkg/front_end/testcases/getter_setter_error/pre_feature/getter_vs_setter_type_late.dart:12:26: Error: The parameter 'i' of the method 'B2.property6' has type 'int', which does not match the corresponding type, 'int?', in the overridden method, 'B1.property6'.
+// Change to a supertype of 'int?', or, for a covariant parameter, a subtype.
+//   void set property6(int i); // error
+//                          ^
+// pkg/front_end/testcases/getter_setter_error/pre_feature/getter_vs_setter_type_late.dart:8:19: Context: This is the overridden method ('property6').
+//   late final int? property6;
+//                   ^
+//
 import self as self;
 import "dart:core" as core;
 
@@ -22,5 +30,5 @@ abstract class B2 extends core::Object implements self::B1 {
   synthetic constructor •() → self::B2
     : super core::Object::•()
     ;
-  abstract set property6(core::int i) → void;
+  abstract erroneous set property6(core::int i) → void;
 }

pkg/front_end/testcases/getter_setter_error/pre_feature/getter_vs_setter_type_late.dart.strong.modular.expect

@@ -9,6 +9,14 @@ library;
 //   late final int? property6;
 //                   ^^^^^^^^^
 //
+// pkg/front_end/testcases/getter_setter_error/pre_feature/getter_vs_setter_type_late.dart:12:26: Error: The parameter 'i' of the method 'B2.property6' has type 'int', which does not match the corresponding type, 'int?', in the overridden method, 'B1.property6'.
+// Change to a supertype of 'int?', or, for a covariant parameter, a subtype.
+//   void set property6(int i); // error
+//                          ^
+// pkg/front_end/testcases/getter_setter_error/pre_feature/getter_vs_setter_type_late.dart:8:19: Context: This is the overridden method ('property6').
+//   late final int? property6;
+//                   ^
+//
 import self as self;
 import "dart:core" as core;
 
@@ -22,5 +30,5 @@ abstract class B2 extends core::Object implements self::B1 {
   synthetic constructor •() → self::B2
     : super core::Object::•()
     ;
-  abstract set property6(core::int i) → void;
+  abstract erroneous set property6(core::int i) → void;
 }

pkg/front_end/testcases/getter_setter_error/pre_feature/getter_vs_setter_type_late.dart.strong.outline.expect

@@ -9,6 +9,14 @@ library;
 //   late final int? property6;
 //                   ^^^^^^^^^
 //
+// pkg/front_end/testcases/getter_setter_error/pre_feature/getter_vs_setter_type_late.dart:12:26: Error: The parameter 'i' of the method 'B2.property6' has type 'int', which does not match the corresponding type, 'int?', in the overridden method, 'B1.property6'.
+// Change to a supertype of 'int?', or, for a covariant parameter, a subtype.
+//   void set property6(int i); // error
+//                          ^
+// pkg/front_end/testcases/getter_setter_error/pre_feature/getter_vs_setter_type_late.dart:8:19: Context: This is the overridden method ('property6').
+//   late final int? property6;
+//                   ^
+//
 import self as self;
 import "dart:core" as core;
 
@@ -20,5 +28,5 @@ abstract class B1 extends core::Object {
 abstract class B2 extends core::Object implements self::B1 {
   synthetic constructor •() → self::B2
     ;
-  abstract set property6(core::int i) → void;
+  abstract erroneous set property6(core::int i) → void;
 }

pkg/front_end/testcases/getter_setter_error/pre_feature/getter_vs_setter_type_late.dart.strong.transformed.expect

@@ -9,6 +9,14 @@ library;
 //   late final int? property6;
 //                   ^^^^^^^^^
 //
+// pkg/front_end/testcases/getter_setter_error/pre_feature/getter_vs_setter_type_late.dart:12:26: Error: The parameter 'i' of the method 'B2.property6' has type 'int', which does not match the corresponding type, 'int?', in the overridden method, 'B1.property6'.
+// Change to a supertype of 'int?', or, for a covariant parameter, a subtype.
+//   void set property6(int i); // error
+//                          ^
+// pkg/front_end/testcases/getter_setter_error/pre_feature/getter_vs_setter_type_late.dart:8:19: Context: This is the overridden method ('property6').
+//   late final int? property6;
+//                   ^
+//
 import self as self;
 import "dart:core" as core;
 
@@ -22,5 +30,5 @@ abstract class B2 extends core::Object implements self::B1 {
   synthetic constructor •() → self::B2
     : super core::Object::•()
     ;
-  abstract set property6(core::int i) → void;
+  abstract erroneous set property6(core::int i) → void;
 }

pkg/front_end/testcases/nnbd/getter_vs_setter_type_late.dart

@@ -27,7 +27,7 @@ abstract class B2 implements B1 {
 
   void set property5(int? i); // ok
 
-  void set property6(int i); // ok
+  void set property6(int i); // error
 }
 
 abstract class C1 {

pkg/front_end/testcases/nnbd/getter_vs_setter_type_late.dart.strong.expect

@@ -2,6 +2,14 @@ library;
 //
 // Problems in library:
 //
+// pkg/front_end/testcases/nnbd/getter_vs_setter_type_late.dart:30:26: Error: The parameter 'i' of the method 'B2.property6' has type 'int', which does not match the corresponding type, 'int?', in the overridden method, 'B1.property6'.
+// Change to a supertype of 'int?', or, for a covariant parameter, a subtype.
+//   void set property6(int i); // error
+//                          ^
+// pkg/front_end/testcases/nnbd/getter_vs_setter_type_late.dart:20:19: Context: This is the overridden method ('property6').
+//   late final int? property6;
+//                   ^
+//
 // pkg/front_end/testcases/nnbd/getter_vs_setter_type_late.dart:50:12: Error: The return type of the method 'C2.property6' is 'int?', which does not match the return type, 'int', of the overridden method, 'C1.property6'.
 // Change to a subtype of 'int'.
 //   int? get property6; // error
@@ -35,7 +43,7 @@ abstract class B2 extends core::Object implements self::B1 {
     ;
   abstract set property4(core::int i) → void;
   abstract set property5(core::int? i) → void;
-  abstract set property6(core::int i) → void;
+  abstract erroneous set property6(core::int i) → void;
 }
 abstract class C1 extends core::Object {
   late field core::int property4;

pkg/front_end/testcases/nnbd/getter_vs_setter_type_late.dart.strong.modular.expect

@@ -2,6 +2,14 @@ library;
 //
 // Problems in library:
 //
+// pkg/front_end/testcases/nnbd/getter_vs_setter_type_late.dart:30:26: Error: The parameter 'i' of the method 'B2.property6' has type 'int', which does not match the corresponding type, 'int?', in the overridden method, 'B1.property6'.
+// Change to a supertype of 'int?', or, for a covariant parameter, a subtype.
+//   void set property6(int i); // error
+//                          ^
+// pkg/front_end/testcases/nnbd/getter_vs_setter_type_late.dart:20:19: Context: This is the overridden method ('property6').
+//   late final int? property6;
+//                   ^
+//
 // pkg/front_end/testcases/nnbd/getter_vs_setter_type_late.dart:50:12: Error: The return type of the method 'C2.property6' is 'int?', which does not match the return type, 'int', of the overridden method, 'C1.property6'.
 // Change to a subtype of 'int'.
 //   int? get property6; // error
@@ -35,7 +43,7 @@ abstract class B2 extends core::Object implements self::B1 {
     ;
   abstract set property4(core::int i) → void;
   abstract set property5(core::int? i) → void;
-  abstract set property6(core::int i) → void;
+  abstract erroneous set property6(core::int i) → void;
 }
 abstract class C1 extends core::Object {
   late field core::int property4;

pkg/front_end/testcases/nnbd/getter_vs_setter_type_late.dart.strong.outline.expect

@@ -2,6 +2,14 @@ library;
 //
 // Problems in library:
 //
+// pkg/front_end/testcases/nnbd/getter_vs_setter_type_late.dart:30:26: Error: The parameter 'i' of the method 'B2.property6' has type 'int', which does not match the corresponding type, 'int?', in the overridden method, 'B1.property6'.
+// Change to a supertype of 'int?', or, for a covariant parameter, a subtype.
+//   void set property6(int i); // error
+//                          ^
+// pkg/front_end/testcases/nnbd/getter_vs_setter_type_late.dart:20:19: Context: This is the overridden method ('property6').
+//   late final int? property6;
+//                   ^
+//
 // pkg/front_end/testcases/nnbd/getter_vs_setter_type_late.dart:50:12: Error: The return type of the method 'C2.property6' is 'int?', which does not match the return type, 'int', of the overridden method, 'C1.property6'.
 // Change to a subtype of 'int'.
 //   int? get property6; // error
@@ -32,7 +40,7 @@ abstract class B2 extends core::Object implements self::B1 {
     ;
   abstract set property4(core::int i) → void;
   abstract set property5(core::int? i) → void;
-  abstract set property6(core::int i) → void;
+  abstract erroneous set property6(core::int i) → void;
 }
 abstract class C1 extends core::Object {
   late field core::int property4;

pkg/front_end/testcases/nnbd/getter_vs_setter_type_late.dart.strong.transformed.expect

@@ -2,6 +2,14 @@ library;
 //
 // Problems in library:
 //
+// pkg/front_end/testcases/nnbd/getter_vs_setter_type_late.dart:30:26: Error: The parameter 'i' of the method 'B2.property6' has type 'int', which does not match the corresponding type, 'int?', in the overridden method, 'B1.property6'.
+// Change to a supertype of 'int?', or, for a covariant parameter, a subtype.
+//   void set property6(int i); // error
+//                          ^
+// pkg/front_end/testcases/nnbd/getter_vs_setter_type_late.dart:20:19: Context: This is the overridden method ('property6').
+//   late final int? property6;
+//                   ^
+//
 // pkg/front_end/testcases/nnbd/getter_vs_setter_type_late.dart:50:12: Error: The return type of the method 'C2.property6' is 'int?', which does not match the return type, 'int', of the overridden method, 'C1.property6'.
 // Change to a subtype of 'int'.
 //   int? get property6; // error
@@ -35,7 +43,7 @@ abstract class B2 extends core::Object implements self::B1 {
     ;
   abstract set property4(core::int i) → void;
   abstract set property5(core::int? i) → void;
-  abstract set property6(core::int i) → void;
+  abstract erroneous set property6(core::int i) → void;
 }
 abstract class C1 extends core::Object {
   late field core::int property4;