[DAS] Fixes renaming fields at constructor parameters

Fixes: #52305
Change-Id: I39a547c391ffd3538b3ccaafeab3af65bb4088b0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413340
Reviewed-by: Samuel Rawlins <[email protected]>
Reviewed-by: Phil Quitslund <[email protected]>
Auto-Submit: Felipe Morschel <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>

Author: FMorschel

pkg/analysis_server/lib/src/services/refactoring/legacy/refactoring.dart

@@ -495,6 +495,17 @@ abstract class RenameRefactoring implements Refactoring {
     if (element is LibraryElement2) {
       return RenameLibraryRefactoringImpl(workspace, sessionHelper, element);
     }
+    if (enclosingElement?.thisOrAncestorOfType2<InterfaceElement2>()
+        case var enclosingElement?) {
+      if (element case FieldFormalParameterElement2(:var field2?)) {
+        return RenameClassMemberRefactoringImpl(
+          workspace,
+          sessionHelper,
+          enclosingElement,
+          field2,
+        );
+      }
+    }
     if (element is FormalParameterElement) {
       return RenameParameterRefactoringImpl(workspace, sessionHelper, element);
     }

pkg/analysis_server/test/edit/refactoring_test.dart

@@ -2036,29 +2036,6 @@ void f() {
     );
   }
 
-  Future<void> test_classMember_field_onFieldFormalParameter_named_private() {
-    addTestFile('''
-class A {
-  final int test;
-  A({this.test = 0});
-}
-void f() {
-  A(test: 42);
-}
-''');
-
-    return getRefactoringResult(() {
-      return sendRenameRequest('test: 42', '_new');
-    }).then((result) {
-      var problems = result.finalProblems;
-      expect(problems, hasLength(1));
-      assertResultProblemsError(
-        problems,
-        "The parameter 'test' is named and can not be private.",
-      );
-    });
-  }
-
   Future<void> test_classMember_getter() {
     addTestFile('''
 class A {

pkg/analysis_server/test/services/refactoring/legacy/rename_class_member_test.dart

@@ -19,6 +19,134 @@ void main() {
 
 @reflectiveTest
 class RenameClassMemberClassTest extends RenameRefactoringTest {
+  Future<void> test_atConstructor_named() async {
+    await indexTestUnit('''
+class A {
+  final int foo;
+
+  A({this.foo = 0});
+}
+''');
+    createRenameRefactoringAtString('foo = 0');
+    // check status
+    refactoring.newName = 'bar';
+    var status = await refactoring.checkFinalConditions();
+    assertRefactoringStatusOK(status);
+  }
+
+  Future<void> test_atConstructor_named_subclasses() async {
+    await indexTestUnit('''
+class A {
+  final int foo;
+
+  A({this.foo = 0});
+}
+
+class B extends A {
+  B({super.foo});
+}
+
+class C extends A {
+  C(int foo) : super(foo: foo);
+}
+''');
+    createRenameRefactoringAtString('foo = 0');
+    // check status
+    refactoring.newName = 'bar';
+    var status = await refactoring.checkFinalConditions();
+    assertRefactoringStatusOK(status);
+    await assertSuccessfulRefactoring('''
+class A {
+  final int bar;
+
+  A({this.bar = 0});
+}
+
+class B extends A {
+  B({super.bar});
+}
+
+class C extends A {
+  C(int foo) : super(bar: foo);
+}
+''');
+  }
+
+  Future<void> test_atConstructor_named_subclasses_toPrivate() async {
+    await indexTestUnit('''
+class A {
+  final int foo;
+
+  A({this.foo = 0});
+}
+
+class B extends A {
+  B({super.foo});
+}
+''');
+    createRenameRefactoringAtString('foo = 0');
+    // check status
+    refactoring.newName = '_foo';
+    var status = await refactoring.checkFinalConditions();
+    assertRefactoringStatusOK(status);
+    await assertSuccessfulRefactoring('''
+class A {
+  final int _foo;
+
+  A({int foo = 0}) : _foo = foo;
+}
+
+class B extends A {
+  B({super.foo});
+}
+''');
+  }
+
+  Future<void> test_atConstructor_positional() async {
+    await indexTestUnit('''
+class A {
+  int foo = 0;
+
+  A(this.foo);
+}
+''');
+    createRenameRefactoringAtString('foo);');
+    // check status
+    refactoring.newName = 'bar';
+    var status = await refactoring.checkFinalConditions();
+    assertRefactoringStatusOK(status);
+  }
+
+  Future<void> test_atConstructor_positional_subclasses_toPrivate() async {
+    await indexTestUnit('''
+class A {
+  int foo = 0;
+
+  A(this.foo); // marker
+}
+
+class B extends A {
+  B(super.foo);
+}
+''');
+    createRenameRefactoringAtString('foo); // marker');
+    // check status
+    refactoring.newName = '_foo';
+    var status = await refactoring.checkFinalConditions();
+    assertRefactoringStatusOK(status);
+    await assertSuccessfulRefactoring('''
+class A {
+  int _foo = 0;
+
+  A(this._foo); // marker
+}
+
+class B extends A {
+  B(super.foo);
+}
+''');
+  }
+
   Future<void> test_checkFinalConditions_classNameConflict_sameClass() async {
     await indexTestUnit('''
 class NewName {