Fine. Track inherited members in manifest and interface ID.

Add an `inherited` map to `ManifestInterface` and populate it from
`InheritanceManager3.getInheritedMap`. Include this map in serialization
and in the ID computation alongside `map`, `implemented`, and
`superImplemented`. The interface ID now changes when only inherited
members change.

Previously, if a superclass member changed (e.g. its signature) but was
overridden in a subclass, the subclass’s interface ID could remain
stable because only its declared/implemented members were considered.
That caused stale analysis results and missed invalidations. By tracking
`inherited`, interface IDs accurately reflect upstream API changes even
when they are shadowed locally.

Other updates:
- Print the `inherited` section in `result_printer`.
- Mark `inheritanceManager` as `@trackedIndirectly` and stop recording
  opaque API use on access.
- Bump `AnalysisDriver.DATA_VERSION` to 543 due to the format change.

Change-Id: I54c637bef7b10d7cb27f93ae146c96b62ff6cddd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/448720
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: scheglov

pkg/analyzer/lib/src/dart/analysis/driver.dart

@@ -106,7 +106,7 @@ testFineAfterLibraryAnalyzerHook;
 // TODO(scheglov): Clean up the list of implicitly analyzed files.
 class AnalysisDriver {
   /// The version of data format, should be incremented on every format change.
-  static const int DATA_VERSION = 542;
+  static const int DATA_VERSION = 543;
 
   /// The number of exception contexts allowed to write. Once this field is
   /// zero, we stop writing any new exception contexts in this process.

pkg/analyzer/lib/src/dart/element/element.dart

@@ -4827,9 +4827,8 @@ abstract class InterfaceElementImpl extends InstanceElementImpl
     _hasNonFinalField = value;
   }
 
-  @trackedDirectlyOpaque
+  @trackedIndirectly
   InheritanceManager3 get inheritanceManager {
-    globalResultRequirements?.recordOpaqueApiUse(this, 'inheritanceManager');
     return library.session.inheritanceManager;
   }
 

pkg/analyzer/lib/src/fine/library_manifest.dart

@@ -875,7 +875,8 @@ class LibraryManifestBuilder {
     var item = declaredItems[element] as InterfaceItem;
     item.interface.beforeUpdating();
 
-    var interface = element.inheritanceManager.getInterface(element);
+    var inheritance = element.inheritanceManager;
+    var interface = inheritance.getInterface(element);
 
     for (var entry in interface.map.entries) {
       var executable = entry.value.baseElement;
@@ -937,6 +938,15 @@ class LibraryManifestBuilder {
       item.interface.superImplemented.add(layer);
     }
 
+    for (var entry in inheritance.getInheritedMap(element).entries) {
+      var executable = entry.value.baseElement;
+      var lookupName = executable.lookupName?.asLookupName;
+      if (lookupName != null && !lookupName.isPrivate) {
+        var id = _getInterfaceElementMemberId(executable);
+        item.interface.inherited[lookupName] = id;
+      }
+    }
+
     item.interface.afterUpdate();
   }
 

pkg/analyzer/lib/src/fine/manifest_item.dart

@@ -1155,12 +1155,14 @@ class ManifestInterface {
   Map<LookupName, ManifestItemId> map;
   Map<LookupName, ManifestItemId> implemented;
   List<Map<LookupName, ManifestItemId>> superImplemented;
+  Map<LookupName, ManifestItemId> inherited;
 
   /// We move [map] into here during building the manifest, so that we can
   /// compare after building, and decide if [id] should be updated.
   Map<LookupName, ManifestItemId> mapPrevious = {};
   Map<LookupName, ManifestItemId> implementedPrevious = {};
   List<Map<LookupName, ManifestItemId>> superImplementedPrevious = [];
+  Map<LookupName, ManifestItemId> inheritedPrevious = {};
 
   /// Key: IDs of method declarations.
   /// Value: ID assigned last time.
@@ -1176,6 +1178,7 @@ class ManifestInterface {
     required this.map,
     required this.implemented,
     required this.superImplemented,
+    required this.inherited,
     required this.combinedIds,
   });
 
@@ -1185,6 +1188,7 @@ class ManifestInterface {
       map: {},
       implemented: {},
       superImplemented: [],
+      inherited: {},
       combinedIds: {},
     );
   }
@@ -1197,6 +1201,7 @@ class ManifestInterface {
       superImplemented: reader.readTypedList(() {
         return reader.readLookupNameToIdMap();
       }),
+      inherited: reader.readLookupNameToIdMap(),
       combinedIds: reader.readMap(
         readKey: () => ManifestItemIdList.read(reader),
         readValue: () => ManifestItemId.read(reader),
@@ -1211,13 +1216,14 @@ class ManifestInterface {
     );
     if (!mapEquality.equals(map, mapPrevious) ||
         !mapEquality.equals(implemented, implementedPrevious) ||
-        !listEquality.equals(superImplemented, superImplementedPrevious)) {
+        !listEquality.equals(superImplemented, superImplementedPrevious) ||
+        !mapEquality.equals(inherited, inheritedPrevious)) {
       id = ManifestItemId.generate();
     }
     mapPrevious = {};
     implementedPrevious = {};
     superImplementedPrevious = [];
-
+    inheritedPrevious = {};
     combinedIdsTemp = {};
   }
 
@@ -1231,6 +1237,9 @@ class ManifestInterface {
     superImplementedPrevious = superImplemented;
     superImplemented = [];
 
+    inheritedPrevious = inherited;
+    inherited = {};
+
     combinedIdsTemp = combinedIds;
     combinedIds = {};
   }
@@ -1240,6 +1249,7 @@ class ManifestInterface {
     map.write(sink);
     implemented.write(sink);
     sink.writeList(superImplemented, (map) => map.write(sink));
+    inherited.write(sink);
     sink.writeMap(
       combinedIds,
       writeKey: (key) => key.write(sink),