lint: include anonymous function expressions in parameter_assignments check

[email protected]

Bug: #58659
Change-Id: If954cd3dfbed648490901e40319b73dc86ca0a54
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/460340
Auto-Submit: Nishtha Jain <[email protected]>
Reviewed-by: Keerti Parthasarathy <[email protected]>
Commit-Queue: Keerti Parthasarathy <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>

Author: Nishthajain7

pkg/linter/lib/src/rules/parameter_assignments.dart

@@ -42,6 +42,8 @@ class ParameterAssignments extends AnalysisRule {
     var visitor = _Visitor(this);
     registry.addFunctionDeclaration(this, visitor);
     registry.addMethodDeclaration(this, visitor);
+    registry.addFunctionExpression(this, visitor);
+    registry.addConstructorDeclaration(this, visitor);
   }
 }
 
@@ -151,6 +153,11 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   _Visitor(this.rule);
 
+  @override
+  void visitConstructorDeclaration(ConstructorDeclaration node) {
+    _checkParameters(node.parameters, node.body);
+  }
+
   @override
   void visitFunctionDeclaration(FunctionDeclaration node) {
     _checkParameters(
@@ -159,6 +166,13 @@ class _Visitor extends SimpleAstVisitor<void> {
     );
   }
 
+  @override
+  void visitFunctionExpression(FunctionExpression node) {
+    if (node.parent is! FunctionDeclaration) {
+      _checkParameters(node.parameters, node.body);
+    }
+  }
+
   @override
   void visitMethodDeclaration(MethodDeclaration node) {
     _checkParameters(node.parameters, node.body);

pkg/linter/test/rules/parameter_assignments_test.dart

@@ -17,6 +17,43 @@ class ParameterAssignmentsTest extends LintRuleTest {
   @override
   String get lintRule => LintNames.parameter_assignments;
 
+  test_anonymousFunction_assignment() async {
+    await assertDiagnostics(
+      r'''
+void main() {
+  (int i) {
+    i = 42;
+  }(0);
+}
+''',
+      [lint(30, 6)],
+    );
+  }
+
+  test_anonymousFunction_assignment_arrowBody() async {
+    await assertDiagnostics(
+      r'''
+void main() {
+  (int i) => i = 42;
+}
+''',
+      [lint(27, 6)],
+    );
+  }
+
+  test_anonymousFunction_assignment_notInvoked() async {
+    await assertDiagnostics(
+      r'''
+void main() {
+  (int i) {
+    i = 42;
+  };
+}
+''',
+      [lint(30, 6)],
+    );
+  }
+
   test_assignment_inIfElseBranches() async {
     await assertDiagnostics(
       r'''
@@ -70,7 +107,6 @@ void f([int? _]) {
     );
   }
 
-  @FailingTest(reason: 'Closures not implemented')
   test_closure_assignment() async {
     await assertDiagnostics(
       r'''
@@ -95,6 +131,19 @@ void f(int p) {
     );
   }
 
+  test_constructor_assignment() async {
+    await assertDiagnostics(
+      r'''
+class Foo {
+  Foo(int x) {
+    x = 4;
+  }
+}
+''',
+      [lint(31, 5)],
+    );
+  }
+
   test_function_assignment() async {
     await assertDiagnostics(
       r'''