Skip to content

Commit 85f6898

Browse files
committed
[deps] Roll dart-lang/native
Change-Id: I38b68ed5b6d4497e36463b7be16258d2e7a7c0d0 Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-arm64-try,pkg-win-release-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/402100 Reviewed-by: Martin Kustermann <[email protected]>
1 parent 4587eca commit 85f6898

File tree

5 files changed

+25
-20
lines changed

5 files changed

+25
-20
lines changed

DEPS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ vars = {
143143
"markdown_rev": "4d5dbc659955973902f2585c54e94d453532db70",
144144
"material_color_utilities_rev": "799b6ba2f3f1c28c67cc7e0b4f18e0c7d7f3c03e",
145145
# dart-native-interop-team@ is rolling breaking changes manually while the assets features are in experimental.
146-
"native_rev": "4d81ce6c5e17164ef63d8a3f5144e5def0702207", # disable tools/rev_sdk_deps.dart
146+
"native_rev": "7adf6bfa33e6042ffd9ae45f505bae30c6ee1fa6", # disable tools/rev_sdk_deps.dart
147147
"package_config_rev": "76f2f6c245451da1fa24d7bbb00251b909e729a5",
148148
"pool_rev": "f85209d83cb0aa3c5612ed80de32df51ba580abd",
149149
"protobuf_rev": "da7279c56734cffed4deb1e3a6f93bdcefccf6b8",

pkg/dartdev/lib/src/commands/build.dart

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import 'package:dartdev/src/experiments.dart';
1111
import 'package:dartdev/src/native_assets_bundling.dart';
1212
import 'package:dartdev/src/sdk.dart';
1313
import 'package:dartdev/src/utils.dart';
14+
import 'package:file/local.dart';
1415
import 'package:front_end/src/api_prototype/compiler_options.dart'
1516
show Verbosity;
1617
import 'package:native_assets_builder/native_assets_builder.dart';
@@ -134,9 +135,11 @@ class BuildCommand extends DartdevCommand {
134135
stdout.writeln('Building native assets.');
135136
final workingDirectory = Directory.current.uri;
136137
final target = Target.current;
137-
final targetMacOSVersion =
138-
target.os == OS.macOS ? minimumSupportedMacOSVersion : null;
138+
final macOSConfig = target.os == OS.macOS
139+
? MacOSConfig(targetVersion: minimumSupportedMacOSVersion)
140+
: null;
139141
final nativeAssetsBuildRunner = NativeAssetsBuildRunner(
142+
fileSystem: const LocalFileSystem(),
140143
dartExecutable: Uri.file(sdk.dart),
141144
logger: logger(verbose),
142145
);
@@ -149,7 +152,7 @@ class BuildCommand extends DartdevCommand {
149152
targetOS: target.os,
150153
linkModePreference: LinkModePreference.dynamic,
151154
targetArchitecture: target.architecture,
152-
targetMacOSVersion: targetMacOSVersion,
155+
macOSConfig: macOSConfig,
153156
cCompilerConfig: cCompilerConfig,
154157
),
155158
configValidator: (config) async => [
@@ -207,7 +210,7 @@ class BuildCommand extends DartdevCommand {
207210
targetOS: target.os,
208211
targetArchitecture: target.architecture,
209212
linkModePreference: LinkModePreference.dynamic,
210-
targetMacOSVersion: targetMacOSVersion,
213+
macOSConfig: macOSConfig,
211214
cCompilerConfig: cCompilerConfig,
212215
),
213216
configValidator: (config) async => [
@@ -217,8 +220,6 @@ class BuildCommand extends DartdevCommand {
217220
resourceIdentifiers:
218221
recordUseEnabled ? Uri.file(recordedUsagesPath!) : null,
219222
workingDirectory: workingDirectory,
220-
221-
222223
buildResult: buildResult,
223224
buildAssetTypes: [
224225
CodeAsset.type,

pkg/dartdev/lib/src/native_assets.dart

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import 'dart:io';
88
import 'package:dartdev/src/native_assets_bundling.dart';
99
import 'package:dartdev/src/sdk.dart';
1010
import 'package:dartdev/src/utils.dart';
11+
import 'package:file/local.dart';
1112
import 'package:logging/logging.dart';
1213
import 'package:native_assets_builder/native_assets_builder.dart';
1314
import 'package:native_assets_cli/code_assets_builder.dart';
@@ -45,10 +46,12 @@ Future<List<EncodedAsset>?> compileNativeAssetsJit({
4546
// This always runs in JIT mode.
4647
dartExecutable: Uri.file(sdk.dart),
4748
logger: logger(verbose),
49+
fileSystem: const LocalFileSystem(),
4850
);
4951
final target = Target.current;
50-
final targetMacOSVersion =
51-
target.os == OS.macOS ? minimumSupportedMacOSVersion : null;
52+
final macOSConfig = target.os == OS.macOS
53+
? MacOSConfig(targetVersion: minimumSupportedMacOSVersion)
54+
: null;
5255
final cCompilerConfig = getCCompilerConfig();
5356
final buildResult = await nativeAssetsBuildRunner.build(
5457
configCreator: () => BuildConfigBuilder()
@@ -57,7 +60,7 @@ Future<List<EncodedAsset>?> compileNativeAssetsJit({
5760
targetArchitecture: target.architecture,
5861
// When running in JIT mode, only dynamic libraries are supported.
5962
linkModePreference: LinkModePreference.dynamic,
60-
targetMacOSVersion: targetMacOSVersion,
63+
macOSConfig: macOSConfig,
6164
cCompilerConfig: cCompilerConfig,
6265
),
6366
configValidator: (config) async => [
@@ -129,7 +132,10 @@ Future<bool> warnOnNativeAssets() async {
129132
}
130133
try {
131134
final packageLayout =
132-
await PackageLayout.fromRootPackageRoot(workingDirectory);
135+
await PackageLayout.fromRootPackageRoot(
136+
const LocalFileSystem(),
137+
workingDirectory,
138+
);
133139
final packagesWithNativeAssets = [
134140
...await packageLayout.packagesWithAssets(Hook.build),
135141
...await packageLayout.packagesWithAssets(Hook.link)
@@ -182,17 +188,13 @@ CCompilerConfig? getCCompilerConfig() {
182188
.toList();
183189
final hasEnvScriptArgs = envScriptArgs != null && envScriptArgs.isNotEmpty;
184190

185-
if (cc != null ||
186-
ar != null ||
187-
ld != null ||
188-
envScript != null ||
189-
hasEnvScriptArgs) {
191+
if (cc != null && ar != null && ld != null) {
190192
return CCompilerConfig(
191-
archiver: ar != null ? Uri.file(ar) : null,
192-
compiler: cc != null ? Uri.file(cc) : null,
193+
archiver: Uri.file(ar),
194+
compiler: Uri.file(cc),
193195
envScript: envScript != null ? Uri.file(envScript) : null,
194196
envScriptArgs: hasEnvScriptArgs ? envScriptArgs : null,
195-
linker: ld != null ? Uri.file(ld) : null,
197+
linker: Uri.file(ld),
196198
);
197199
}
198200
return null;

pkg/dartdev/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ dependencies:
2020
dds: any
2121
dds_service_extensions: any
2222
dtd_impl: any
23+
file: any
2324
front_end: any
2425
frontend_server: any
2526
http: any
@@ -39,7 +40,6 @@ dependencies:
3940
# Use 'any' constraints here; we get our versions from the DEPS file.
4041
dev_dependencies:
4142
expect: any
42-
file: any
4343
lints: any
4444
pub_semver: any
4545
test: any

pkg/dartdev/test/native_assets/helpers.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import 'dart:async';
66
import 'dart:io';
77

8+
import 'package:file/local.dart';
89
import 'package:logging/logging.dart';
910
import 'package:native_assets_builder/src/utils/run_process.dart'
1011
as run_process;
@@ -60,6 +61,7 @@ Future<run_process.RunProcessResult> runProcess({
6061
captureOutput: captureOutput,
6162
expectedExitCode: expectedExitCode,
6263
throwOnUnexpectedExitCode: throwOnUnexpectedExitCode,
64+
filesystem: const LocalFileSystem(),
6365
);
6466

6567
Future<void> copyTestProjects(

0 commit comments

Comments
 (0)