[analysis_server] Make fix/assists consistently use "initializing formal" instead of "field formal"

There was a mix of the term "field formal" and "initializing formal" in fixes and assists. This changes those that used "field formal" to "initializing formal" (which seems to be the term used most here and on the website).

I did not update all places that use this (for example there are many in the analyzer, including classes).

Change-Id: Ia4a1095a756adb35ca7faa8dc06c541abb04bfcc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413781
Commit-Queue: Brian Wilkerson <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: DanTup

pkg/analysis_server/lib/src/computer/computer_documentation.dart

@@ -23,8 +23,8 @@ class DartDocumentationComputer {
       _ => elementBeingDocumented,
     };
     if (element == null) {
-      // This can happen when the code is invalid, such as having a field formal
-      // parameter for a field that does not exist.
+      // This can happen when the code is invalid, such as having an
+      // initializing formal parameter for a field that does not exist.
       return null;
     }
 

pkg/analysis_server/lib/src/services/correction/assist.dart

@@ -106,10 +106,10 @@ abstract final class DartAssistKind {
     DartAssistKindPriority.DEFAULT,
     'Convert to double quoted string',
   );
-  static const CONVERT_TO_FIELD_PARAMETER = AssistKind(
-    'dart.assist.convert.toConstructorFieldParameter',
+  static const CONVERT_TO_INITIALIZING_FORMAL = AssistKind(
+    'dart.assist.convert.toInitializingFormal',
     DartAssistKindPriority.DEFAULT,
-    'Convert to field formal parameter',
+    'Convert to initializing formal parameter',
   );
   static const CONVERT_TO_FOR_ELEMENT = AssistKind(
     'dart.assist.convert.toForElement',

pkg/analysis_server/lib/src/services/correction/dart/add_field_formal_parameters.dart

@@ -20,7 +20,7 @@ class AddFieldFormalParameters extends ResolvedCorrectionProducer {
       CorrectionApplicability.singleLocation;
 
   @override
-  FixKind get fixKind => DartFixKind.ADD_FIELD_FORMAL_PARAMETERS;
+  FixKind get fixKind => DartFixKind.ADD_INITIALIZING_FORMAL_PARAMETERS;
 
   @override
   Future<void> compute(ChangeBuilder builder) async {

pkg/analysis_server/lib/src/services/correction/dart/convert_to_field_parameter.dart

@@ -22,7 +22,7 @@ class ConvertToFieldParameter extends ResolvedCorrectionProducer {
       CorrectionApplicability.singleLocation;
 
   @override
-  AssistKind get assistKind => DartAssistKind.CONVERT_TO_FIELD_PARAMETER;
+  AssistKind get assistKind => DartAssistKind.CONVERT_TO_INITIALIZING_FORMAL;
 
   @override
   Future<void> compute(ChangeBuilder builder) async {

pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml

@@ -730,18 +730,18 @@ CompileTimeErrorCode.FIELD_INITIALIZED_IN_PARAMETER_AND_INITIALIZER:
 CompileTimeErrorCode.FIELD_INITIALIZER_FACTORY_CONSTRUCTOR:
   status: needsFix
   notes: |-
-    Replace the field formal parameter with a normal parameter.
+    Replace the initializing formal parameter with a normal parameter.
 CompileTimeErrorCode.FIELD_INITIALIZER_NOT_ASSIGNABLE:
   status: noFix
 CompileTimeErrorCode.FIELD_INITIALIZER_OUTSIDE_CONSTRUCTOR:
   status: needsFix
   notes: |-
-    Replace the field formal parameter with a normal parameter and add an
-    assignment to the field in the method.
+    Replace the initializing formal parameter with a normal parameter and
+    add an assignment to the field in the method.
 CompileTimeErrorCode.FIELD_INITIALIZER_REDIRECTING_CONSTRUCTOR:
   status: needsFix
   notes: |-
-    Replace the field formal parameter with a normal parameter.
+    Replace the initializing formal parameter with a normal parameter.
 CompileTimeErrorCode.FIELD_INITIALIZING_FORMAL_NOT_ASSIGNABLE:
   status: noFix
 CompileTimeErrorCode.FINAL_CLASS_EXTENDED_OUTSIDE_OF_LIBRARY:

pkg/analysis_server/lib/src/services/correction/fix.dart

@@ -157,10 +157,10 @@ abstract final class DartFixKind {
     DartFixKindPriority.inFile,
     'Add cast everywhere in file',
   );
-  static const ADD_FIELD_FORMAL_PARAMETERS = FixKind(
-    'dart.fix.add.fieldFormalParameters',
+  static const ADD_INITIALIZING_FORMAL_PARAMETERS = FixKind(
+    'dart.fix.add.initializingFormalParameters',
     70,
-    'Add final field formal parameters',
+    'Add final initializing formal parameters',
   );
   static const ADD_KEY_TO_CONSTRUCTORS = FixKind(
     'dart.fix.add.keyToConstructors',

pkg/analysis_server/test/src/services/correction/assist/convert_to_field_parameter_test.dart

@@ -17,7 +17,7 @@ void main() {
 @reflectiveTest
 class ConvertToFieldParameterTest extends AssistProcessorTest {
   @override
-  AssistKind get kind => DartAssistKind.CONVERT_TO_FIELD_PARAMETER;
+  AssistKind get kind => DartAssistKind.CONVERT_TO_INITIALIZING_FORMAL;
 
   Future<void> test_additionalUse() async {
     await resolveTestCode('''

pkg/analysis_server/test/src/services/correction/fix/add_field_formal_parameters_test.dart

@@ -17,7 +17,7 @@ void main() {
 @reflectiveTest
 class AddFieldFormalParametersTest extends FixProcessorTest {
   @override
-  FixKind get kind => DartFixKind.ADD_FIELD_FORMAL_PARAMETERS;
+  FixKind get kind => DartFixKind.ADD_INITIALIZING_FORMAL_PARAMETERS;
 
   Future<void> test_flutter_nullable() async {
     writeTestPackageConfig(flutter: true);

pkg/analyzer_plugin/lib/utilities/change_builder/change_builder_dart.dart

@@ -67,11 +67,11 @@ abstract class DartEditBuilder implements EditBuilder {
   /// parameters (enclosing parenthesis are written for you). Otherwise, if an
   /// [argumentList] is provided then the constructor will have parameters that
   /// match the given arguments. If no argument list is given, but a list of
-  /// [fieldNames] is provided, then field formal parameters will be created for
-  /// each of the field names. If an [initializerWriter] is provided then it is
-  /// used to write the constructor initializers (the ` : ` prefix is written
-  /// for you). If a [bodyWriter] is provided then it is used to write the
-  /// constructor body, otherwise an empty body is written.
+  /// [fieldNames] is provided, then initializing formal parameters will be
+  /// created for each of the field names. If an [initializerWriter] is provided
+  /// then it is used to write the constructor initializers (the ` : ` prefix is
+  /// written for you). If a [bodyWriter] is provided then it is used to write
+  /// the constructor body, otherwise an empty body is written.
   void writeConstructorDeclaration(String className,
       {ArgumentList? argumentList,
       void Function()? bodyWriter,