[element model] migrate prefer_const_constructors

Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I1298112a1b565724b651fe107e4f573fe2f795e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/389404
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>

Author: pq

pkg/linter/analyzer_use_new_elements.txt

@@ -1,6 +1,8 @@
 lib/src/analyzer.dart
+lib/src/lint_codes.dart
+lib/src/lint_codes.g.dart
 lib/src/lint_names.dart
-lib/src/linter_lint_codes.dart
+lib/src/lint_names.g.dart
 lib/src/rules.dart
 lib/src/rules/always_declare_return_types.dart
 lib/src/rules/always_put_control_body_on_new_line.dart
@@ -98,6 +100,7 @@ lib/src/rules/prefer_asserts_with_message.dart
 lib/src/rules/prefer_bool_in_asserts.dart
 lib/src/rules/prefer_collection_literals.dart
 lib/src/rules/prefer_conditional_assignment.dart
+lib/src/rules/prefer_const_constructors.dart
 lib/src/rules/prefer_const_declarations.dart
 lib/src/rules/prefer_const_literals_to_create_immutables.dart
 lib/src/rules/prefer_contains.dart
@@ -153,6 +156,7 @@ lib/src/rules/unnecessary_library_name.dart
 lib/src/rules/unnecessary_new.dart
 lib/src/rules/unnecessary_null_aware_assignments.dart
 lib/src/rules/unnecessary_null_in_if_null_operators.dart
+lib/src/rules/unnecessary_nullable_for_final_variable_declarations.dart
 lib/src/rules/unnecessary_parenthesis.dart
 lib/src/rules/unnecessary_raw_strings.dart
 lib/src/rules/unnecessary_statements.dart
@@ -431,7 +435,7 @@ test/validate_incompatible_rules_test.dart
 test/validate_no_rule_description_references_test.dart
 test/validate_rule_description_format_test.dart
 test/verify_checks_test.dart
-test/verify_generated_codes_test.dart
+test/verify_generated_files_test.dart
 test/verify_reflective_test_suites_test.dart
 test_data/rules/no_default_cases.dart
 test_data/rules/overridden_fields.dart
@@ -447,14 +451,14 @@ test_data/rules/unmocked/unsafe_html.dart
 test_data/rules/unnecessary_lambdas.dart
 test_data/rules/unnecessary_parenthesis.dart
 test_data/rules/void_checks.dart
+tool/benchmark.dart
 tool/changelog.dart
 tool/checks/check_all_yaml.dart
 tool/checks/check_messages_yaml.dart
 tool/checks/driver.dart
 tool/checks/rules/no_solo_tests.dart
 tool/checks/rules/no_trailing_spaces.dart
-tool/cli.dart
-tool/codes/generate.dart
+tool/generate_lints.dart
 tool/labeler/issue_config.dart
 tool/labeler/pr_config.dart
 tool/legacy_test_move.dart

pkg/linter/lib/src/rules/prefer_const_constructors.dart

@@ -4,7 +4,7 @@
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
-import 'package:analyzer/dart/element/element.dart';
+import 'package:analyzer/dart/element/element2.dart';
 import 'package:analyzer/dart/element/type.dart';
 import 'package:analyzer/src/lint/linter.dart'; // ignore: implementation_imports
 
@@ -41,24 +41,25 @@ class _Visitor extends SimpleAstVisitor<void> {
     if (node.isConst) return;
     if (node.constructorName.type.isDeferred) return;
 
-    var element = node.constructorName.staticElement;
+    var element = node.constructorName.element;
     if (element == null) return;
     if (!element.isConst) return;
 
     // Handled by an analyzer warning.
     if (element.hasLiteral) return;
 
-    var enclosingElement = element.enclosingElement3;
-    if (enclosingElement is ClassElement && enclosingElement.isDartCoreObject) {
+    var enclosingElement = element.enclosingElement2;
+    if (enclosingElement is ClassElement2 &&
+        enclosingElement.isDartCoreObject) {
       // Skip lint for `new Object()`, because it can be used for ID creation.
       return;
     }
 
-    if (enclosingElement.typeParameters.isNotEmpty &&
+    if (enclosingElement.typeParameters2.isNotEmpty &&
         node.constructorName.type.typeArguments == null) {
       var approximateContextType = node.approximateContextType;
       var contextTypeAsInstanceOfEnclosing =
-          approximateContextType?.asInstanceOf(enclosingElement);
+          approximateContextType?.asInstanceOf2(enclosingElement);
       if (contextTypeAsInstanceOfEnclosing != null) {
         if (contextTypeAsInstanceOfEnclosing.typeArguments
             .any((e) => e is TypeParameterType)) {