[vm] Remove --trace_optimized_ic_calls.

TEST=ci
Bug: #54377
Change-Id: Ibd3b2d05de241dffe3fa99b5d3a54cd20e0c4fdd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433041
Reviewed-by: Alexander Aprelev <[email protected]>

Author: rmacnak-google

runtime/vm/compiler/runtime_offsets_extracted.h

@@ -2185,22 +2185,11 @@ void StubCodeCompiler::GenerateCallClosureNoSuchMethodStub() {
 // Cannot use function object from ICData as it may be the inlined
 // function and not the top-scope function.
 void StubCodeCompiler::GenerateOptimizedUsageCounterIncrement() {
-  Register ic_reg = R9;
   Register func_reg = R8;
   if (FLAG_precompiled_mode) {
     __ Breakpoint();
     return;
   }
-  if (FLAG_trace_optimized_ic_calls) {
-    __ EnterStubFrame();
-    __ PushList((1 << R9) | (1 << R8));  // Preserve.
-    __ Push(ic_reg);                     // Argument.
-    __ Push(func_reg);                   // Argument.
-    __ CallRuntime(kTraceICCallRuntimeEntry, 2);
-    __ Drop(2);                         // Discard argument;
-    __ PopList((1 << R9) | (1 << R8));  // Restore.
-    __ LeaveStubFrame();
-  }
   __ ldr(TMP, FieldAddress(func_reg, target::Function::usage_counter_offset()));
   __ add(TMP, TMP, Operand(1));
   __ str(TMP, FieldAddress(func_reg, target::Function::usage_counter_offset()));

runtime/vm/compiler/stub_code_compiler_arm.cc

@@ -2592,24 +2592,11 @@ void StubCodeCompiler::GenerateCallClosureNoSuchMethodStub() {
 // Cannot use function object from ICData as it may be the inlined
 // function and not the top-scope function.
 void StubCodeCompiler::GenerateOptimizedUsageCounterIncrement() {
-  Register ic_reg = R5;
   Register func_reg = R6;
   if (FLAG_precompiled_mode) {
     __ Breakpoint();
     return;
   }
-  if (FLAG_trace_optimized_ic_calls) {
-    __ EnterStubFrame();
-    __ Push(R6);        // Preserve.
-    __ Push(R5);        // Preserve.
-    __ Push(ic_reg);    // Argument.
-    __ Push(func_reg);  // Argument.
-    __ CallRuntime(kTraceICCallRuntimeEntry, 2);
-    __ Drop(2);  // Discard argument;
-    __ Pop(R5);  // Restore.
-    __ Pop(R6);  // Restore.
-    __ LeaveStubFrame();
-  }
   __ LoadFieldFromOffset(R7, func_reg, target::Function::usage_counter_offset(),
                          kFourBytes);
   __ add(R7, R7, Operand(1));

runtime/vm/compiler/stub_code_compiler_arm64.cc

@@ -1935,21 +1935,7 @@ void StubCodeCompiler::GenerateCallClosureNoSuchMethodStub() {
 // Cannot use function object from ICData as it may be the inlined
 // function and not the top-scope function.
 void StubCodeCompiler::GenerateOptimizedUsageCounterIncrement() {
-  Register ic_reg = ECX;
   Register func_reg = EAX;
-  if (FLAG_trace_optimized_ic_calls) {
-    __ EnterStubFrame();
-    __ pushl(func_reg);  // Preserve
-    __ pushl(ic_reg);    // Preserve.
-    __ pushl(ic_reg);    // Argument.
-    __ pushl(func_reg);  // Argument.
-    __ CallRuntime(kTraceICCallRuntimeEntry, 2);
-    __ popl(EAX);       // Discard argument;
-    __ popl(EAX);       // Discard argument;
-    __ popl(ic_reg);    // Restore.
-    __ popl(func_reg);  // Restore.
-    __ LeaveFrame();
-  }
   __ incl(FieldAddress(func_reg, target::Function::usage_counter_offset()));
 }
 

runtime/vm/compiler/stub_code_compiler_ia32.cc

@@ -2186,9 +2186,6 @@ void StubCodeCompiler::GenerateOptimizedUsageCounterIncrement() {
     __ Breakpoint();
     return;
   }
-  if (FLAG_trace_optimized_ic_calls) {
-    __ Stop("Unimplemented");
-  }
   __ LoadFieldFromOffset(TMP, A6, target::Function::usage_counter_offset(),
                          kFourBytes);
   __ addi(TMP, TMP, 1);

runtime/vm/compiler/stub_code_compiler_riscv.cc

@@ -2498,21 +2498,7 @@ void StubCodeCompiler::GenerateOptimizedUsageCounterIncrement() {
     __ Breakpoint();
     return;
   }
-  Register ic_reg = RBX;
   Register func_reg = RDI;
-  if (FLAG_trace_optimized_ic_calls) {
-    __ EnterStubFrame();
-    __ pushq(func_reg);  // Preserve
-    __ pushq(ic_reg);    // Preserve.
-    __ pushq(ic_reg);    // Argument.
-    __ pushq(func_reg);  // Argument.
-    __ CallRuntime(kTraceICCallRuntimeEntry, 2);
-    __ popq(RAX);       // Discard argument;
-    __ popq(RAX);       // Discard argument;
-    __ popq(ic_reg);    // Restore.
-    __ popq(func_reg);  // Restore.
-    __ LeaveStubFrame();
-  }
   __ incl(FieldAddress(func_reg, target::Function::usage_counter_offset()));
 }
 

runtime/vm/compiler/stub_code_compiler_x64.cc

@@ -213,8 +213,6 @@ constexpr bool FLAG_support_il_printer = false;
   D(trace_type_checks_verbose, bool, false,                                    \
     "Enable verbose trace of runtime type checks.")                            \
   D(trace_patching, bool, false, "Trace patching of code.")                    \
-  D(trace_optimized_ic_calls, bool, false,                                     \
-    "Trace IC calls in optimized code.")                                       \
   D(trace_zones, bool, false, "Traces allocation sizes in the zone.")          \
   P(truncating_left_shift, bool, true,                                         \
     "Optimize left shift to truncate if possible")                             \

runtime/vm/flag_list.h

@@ -3570,19 +3570,6 @@ DEFINE_RUNTIME_ENTRY(InterruptOrStackOverflow, 0) {
 #endif  // !defined(DART_PRECOMPILED_RUNTIME)
 }
 
-DEFINE_RUNTIME_ENTRY(TraceICCall, 2) {
-  const ICData& ic_data = ICData::CheckedHandle(zone, arguments.ArgAt(0));
-  const Function& function = Function::CheckedHandle(zone, arguments.ArgAt(1));
-  DartFrameIterator iterator(thread,
-                             StackFrameIterator::kNoCrossThreadIteration);
-  StackFrame* frame = iterator.NextFrame();
-  ASSERT(frame != nullptr);
-  OS::PrintErr(
-      "IC call @%#" Px ": ICData: %#" Px " cnt:%" Pd " nchecks: %" Pd " %s\n",
-      frame->pc(), static_cast<uword>(ic_data.ptr()), function.usage_counter(),
-      ic_data.NumberOfChecks(), function.ToFullyQualifiedCString());
-}
-
 // Compile a function. Should call only if the function has not been compiled.
 //   Arg0: function object.
 DEFINE_RUNTIME_ENTRY(CompileFunction, 1) {

runtime/vm/runtime_entry.cc

@@ -44,7 +44,6 @@ namespace dart {
   V(NoSuchMethodFromCallStub)                                                  \
   V(NoSuchMethodFromPrologue)                                                  \
   V(OptimizeInvokedFunction)                                                   \
-  V(TraceICCall)                                                               \
   V(PatchStaticCall)                                                           \
   V(RangeError)                                                                \
   V(RangeErrorUnboxedInt64)                                                    \