[_fe_analyzer_shared] Support extension types in macro metadata

Change-Id: I91d4a2837285583ec8c05f0f8f3c4c906f861411
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391402
Reviewed-by: Jens Johansen <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>

Author: johnniwinther

pkg/_fe_analyzer_shared/lib/src/metadata/proto.dart

@@ -516,6 +516,110 @@ class GenericClassProto extends Proto {
   }
 }
 
+/// A [reference] to an extension type.
+///
+/// The [Proto] includes the [scope] of the extension type, which is used to
+/// resolve access to constructors and static members on the extension type.
+class ExtensionTypeProto extends Proto {
+  final ExtensionTypeReference reference;
+  final TypeDeclarationScope scope;
+
+  ExtensionTypeProto(this.reference, this.scope);
+
+  @override
+  String toString() => 'ExtensionTypeProto($reference)';
+
+  @override
+  Proto access(String? name) {
+    if (name == null) {
+      return this;
+    }
+    if (name == 'new') {
+      name = '';
+    }
+    return scope.lookup(name);
+  }
+
+  @override
+  Proto instantiate(List<TypeAnnotation>? typeArguments) {
+    return typeArguments != null
+        ? new GenericExtensionTypeProto(reference, scope, typeArguments)
+        : this;
+  }
+
+  @override
+  Proto invoke(List<Argument>? arguments) {
+    return arguments != null ? access('new').invoke(arguments) : this;
+  }
+
+  @override
+  Expression toExpression() {
+    return new TypeLiteral(toTypeAnnotation());
+  }
+
+  @override
+  TypeAnnotation toTypeAnnotation() => new NamedTypeAnnotation(reference);
+
+  @override
+  Proto? resolve() => null;
+}
+
+/// A [reference] to an extension type instantiated with [typeArguments].
+///
+/// The [Proto] includes the [scope] of the extension type, which is used to
+/// resolve access to constructors on the class.
+class GenericExtensionTypeProto extends Proto {
+  final ExtensionTypeReference reference;
+  final TypeDeclarationScope scope;
+  final List<TypeAnnotation> typeArguments;
+
+  GenericExtensionTypeProto(this.reference, this.scope, this.typeArguments);
+
+  @override
+  String toString() => 'GenericExtensionTypeProto($reference,$typeArguments)';
+
+  @override
+  Proto access(String? name) {
+    if (name == null) {
+      return this;
+    }
+    if (name == 'new') {
+      name = '';
+    }
+    return scope.lookup(name, typeArguments);
+  }
+
+  @override
+  Proto instantiate(List<TypeAnnotation>? typeArguments) {
+    return typeArguments != null
+        ? throw new UnimplementedError('GenericExtensionTypeProto.instantiate')
+        : this;
+  }
+
+  @override
+  Proto invoke(List<Argument>? arguments) {
+    return arguments != null ? access('new').invoke(arguments) : this;
+  }
+
+  @override
+  Expression toExpression() {
+    return new TypeLiteral(toTypeAnnotation());
+  }
+
+  @override
+  TypeAnnotation toTypeAnnotation() =>
+      new NamedTypeAnnotation(reference, typeArguments);
+
+  @override
+  Proto? resolve() {
+    List<TypeAnnotation>? newTypeArguments =
+        typeArguments.resolve((a) => a.resolve());
+    return newTypeArguments == null
+        ? null
+        : new GenericExtensionTypeProto(reference, scope, newTypeArguments);
+  }
+}
+
 /// A [reference] to a typedef.
 ///
 /// The [Proto] includes the [scope] of the typedef, which is used to resolve
@@ -990,23 +1094,23 @@ class InstanceAccessProto extends Proto {
     if (name == null) {
       return this;
     }
-    throw new UnimplementedError('InstanceAccessProto.access');
+    throw new UnimplementedError('$this.access');
   }
 
   @override
   Proto instantiate(List<TypeAnnotation>? typeArguments) {
     if (typeArguments == null) {
       return this;
     }
-    throw new UnimplementedError('InstanceAccessProto.instantiate');
+    throw new UnimplementedError('$this.instantiate');
   }
 
   @override
   Proto invoke(List<Argument>? arguments) {
     if (arguments == null) {
       return this;
     }
-    throw new UnimplementedError('InstanceAccessProto.invoke');
+    throw new UnimplementedError('$this.invoke');
   }
 
   @override

pkg/_fe_analyzer_shared/lib/src/metadata/references.dart

@@ -59,6 +59,13 @@ abstract class ExtensionReference extends Reference {
   String toString() => 'ExtensionReference(${name})';
 }
 
+abstract class ExtensionTypeReference extends Reference {
+  String get name;
+
+  @override
+  String toString() => 'ExtensionTypeReference(${name})';
+}
+
 abstract class FunctionTypeParameterReference extends Reference {
   String get name;
 

pkg/_fe_analyzer_shared/lib/src/metadata/scope.dart

@@ -75,6 +75,42 @@ abstract base class BaseExtensionScope implements TypeDeclarationScope {
   }
 }
 
+/// Base implementation for creating a [TypeDeclarationScope] for an extension
+/// type.
+abstract base class BaseExtensionTypeScope implements TypeDeclarationScope {
+  ExtensionTypeReference get extensionTypeReference;
+
+  Proto createConstructorProto(List<TypeAnnotation>? typeArguments,
+      ConstructorReference constructorReference) {
+    return new ConstructorProto(extensionTypeReference,
+        typeArguments ?? const [], constructorReference);
+  }
+
+  Proto createMemberProto<T>(List<TypeAnnotation>? typeArguments, String name,
+      T? member, Proto Function(T, String) memberToProto) {
+    if (member == null) {
+      if (typeArguments != null) {
+        return new UnresolvedAccess(
+            new GenericExtensionTypeProto(
+                extensionTypeReference, this, typeArguments),
+            name);
+      } else {
+        return new UnresolvedAccess(
+            new ExtensionTypeProto(extensionTypeReference, this), name);
+      }
+    } else {
+      if (typeArguments != null) {
+        return new InvalidAccessProto(
+            new GenericExtensionTypeProto(
+                extensionTypeReference, this, typeArguments),
+            name);
+      } else {
+        return memberToProto(member, name);
+      }
+    }
+  }
+}
+
 /// Base implementation for creating a [TypeDeclarationScope] for a typedef.
 abstract base class BaseTypedefScope implements TypeDeclarationScope {
   TypedefReference get typedefReference;

pkg/_fe_analyzer_shared/lib/src/testing/metadata_helper.dart

@@ -168,7 +168,7 @@ class Writer {
         _write(expression.name);
         _write(')');
       case TypeLiteral():
-        _write('NullAwarePropertyGet(');
+        _write('TypeLiteral(');
         _typeAnnotationToText(expression.typeAnnotation);
         _write(')');
       case ParenthesizedExpression():
@@ -286,6 +286,8 @@ class Writer {
         _write(reference.name);
       case ExtensionReference():
         _write(reference.name);
+      case ExtensionTypeReference():
+        _write(reference.name);
       case FunctionTypeParameterReference():
         _write(reference.name);
     }
@@ -622,6 +624,15 @@ class Writer {
         _write('ExtensionProto(');
         _referenceToText(proto.reference);
         _write(')');
+      case ExtensionTypeProto():
+        _write('ExtensionTypeProto(');
+        _referenceToText(proto.reference);
+        _write(')');
+      case GenericExtensionTypeProto():
+        _write('GenericExtensionTypeProto(');
+        _referenceToText(proto.reference);
+        _typeArgumentsToText(proto.typeArguments);
+        _write(')');
       case TypedefProto():
         _write('TypedefProto(');
         _referenceToText(proto.reference);

pkg/_fe_analyzer_shared/test/metadata/data/access/main.dart

@@ -48,7 +48,7 @@ void access3() {}
 
 @Helper(Class)
 /*member: access4:
-NullAwarePropertyGet(Class)*/
+TypeLiteral(Class)*/
 void access4() {}
 
 @Helper(Class.new)
@@ -93,7 +93,7 @@ void access12() {}
 
 @Helper(self.Class)
 /*member: access13:
-NullAwarePropertyGet(Class)*/
+TypeLiteral(Class)*/
 void access13() {}
 
 @Helper(self.Class.new)
@@ -123,7 +123,7 @@ void access18() {}
 
 @Helper(dynamic)
 /*member: access19:
-NullAwarePropertyGet(dynamic)*/
+TypeLiteral(dynamic)*/
 void access19() {}
 
 @Helper(Alias.new)
@@ -178,7 +178,7 @@ void access29() {}
 
 @Helper(dynamic)
 /*member: access30:
-NullAwarePropertyGet(dynamic)*/
+TypeLiteral(dynamic)*/
 void access30() {}
 
 @Helper(self.Alias.new)