analyzer: Rename NodeLintRegistry to RuleVisitorRegistry, provide alias

Work towards #50986

Change-Id: Id0053b4721ca0517e315d5118ae48839dfaa3027
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/429465
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>

Author: srawlins

pkg/analysis_server/lib/src/services/correction/bulk_fix_processor.dart

@@ -534,7 +534,7 @@ class BulkFixProcessor {
     LintRuleUnitContext currentUnit,
     List<LintRuleUnitContext> allUnits,
   ) {
-    var nodeRegistry = NodeLintRegistry(enableTiming: false);
+    var nodeRegistry = RuleVisitorRegistry(enableTiming: false);
     var context = LinterContextWithParsedResults(allUnits, currentUnit);
     var lintRules =
         _syntacticLintCodes

pkg/analysis_server_plugin/lib/src/plugin_server.dart

@@ -339,7 +339,7 @@ class PluginServer {
 
     // TODO(srawlins): Enable timing similar to what the linter package's
     // `benchhmark.dart` script does.
-    var nodeRegistry = NodeLintRegistry(enableTiming: false);
+    var nodeRegistry = RuleVisitorRegistry(enableTiming: false);
 
     var context = LinterContextWithResolvedResults(
       allUnits,

pkg/analysis_server_plugin/test/src/lint_rules.dart

@@ -6,6 +6,7 @@ import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/error/error.dart';
 import 'package:analyzer/src/lint/linter.dart';
+import 'package:analyzer/src/lint/linter_visitor.dart';
 
 class NoBoolsRule extends AnalysisRule {
   static const LintCode code = LintCode('no_bools', 'No bools message');
@@ -17,7 +18,7 @@ class NoBoolsRule extends AnalysisRule {
 
   @override
   void registerNodeProcessors(
-      NodeLintRegistry registry, LinterContext context) {
+      RuleVisitorRegistry registry, LinterContext context) {
     var visitor = _NoBoolsVisitor(this);
     registry.addBooleanLiteral(this, visitor);
   }
@@ -34,7 +35,7 @@ class NoDoublesRule extends AnalysisRule {
 
   @override
   void registerNodeProcessors(
-      NodeLintRegistry registry, LinterContext context) {
+      RuleVisitorRegistry registry, LinterContext context) {
     var visitor = _NoDoublesVisitor(this);
     registry.addDoubleLiteral(this, visitor);
   }

pkg/analysis_server_plugin/test/src/plugin_server_error_test.dart

@@ -12,6 +12,7 @@ import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/error/error.dart';
 import 'package:analyzer/src/lint/linter.dart';
+import 'package:analyzer/src/lint/linter_visitor.dart';
 import 'package:analyzer_plugin/protocol/protocol_constants.dart' as protocol;
 import 'package:analyzer_plugin/protocol/protocol_generated.dart' as protocol;
 import 'package:analyzer_plugin/utilities/change_builder/change_builder_core.dart';
@@ -269,7 +270,7 @@ class _ThrowsAsyncErrorRule extends AnalysisRule {
 
   @override
   void registerNodeProcessors(
-      NodeLintRegistry registry, LinterContext context) {
+      RuleVisitorRegistry registry, LinterContext context) {
     var visitor = _ThrowsAsyncErrorVisitor(this);
     registry.addBooleanLiteral(this, visitor);
   }
@@ -316,7 +317,7 @@ class _ThrowsSyncErrorRule extends AnalysisRule {
 
   @override
   void registerNodeProcessors(
-      NodeLintRegistry registry, LinterContext context) {
+      RuleVisitorRegistry registry, LinterContext context) {
     var visitor = _ThrowsSyncErrorVisitor(this);
     registry.addBooleanLiteral(this, visitor);
   }

pkg/analyzer/lib/src/dart/analysis/library_analyzer.dart

@@ -402,7 +402,7 @@ class LibraryAnalyzer {
     var allUnits = analysesToContextUnits.values.toList();
     definingContextUnit ??= allUnits.first;
 
-    var nodeRegistry = NodeLintRegistry(enableTiming: _enableLintRuleTiming);
+    var nodeRegistry = RuleVisitorRegistry(enableTiming: _enableLintRuleTiming);
     var context = LinterContextWithResolvedResults(
       allUnits,
       definingContextUnit,

pkg/analyzer/lib/src/lint/linter.dart

@@ -13,7 +13,7 @@ import 'package:analyzer/diagnostic/diagnostic.dart';
 import 'package:analyzer/error/error.dart';
 import 'package:analyzer/error/listener.dart';
 import 'package:analyzer/file_system/file_system.dart';
-import 'package:analyzer/src/lint/linter_visitor.dart' show NodeLintRegistry;
+import 'package:analyzer/src/lint/linter_visitor.dart' show RuleVisitorRegistry;
 import 'package:analyzer/src/lint/pub.dart';
 import 'package:analyzer/src/lint/state.dart';
 import 'package:analyzer/workspace/workspace.dart';
@@ -75,7 +75,7 @@ sealed class AbstractAnalysisRule {
   /// The node processors may use the provided [context] to access information
   /// that is not available from the AST nodes or their associated elements.
   void registerNodeProcessors(
-    NodeLintRegistry registry,
+    RuleVisitorRegistry registry,
     LinterContext context,
   ) {}
 

pkg/analyzer/lib/src/lint/linter_visitor.dart

@@ -8,9 +8,12 @@ import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/lint/analysis_rule_timers.dart';
 import 'package:analyzer/src/lint/linter.dart';
 
+/// The soon-to-be-deprecated alias for a [RuleVisitorRegistry].
+typedef NodeLintRegistry = RuleVisitorRegistry;
+
 /// The AST visitor that runs handlers for nodes from the [_registry].
 class AnalysisRuleVisitor implements AstVisitor<void> {
-  final NodeLintRegistry _registry;
+  final RuleVisitorRegistry _registry;
 
   /// Whether exceptions should be propagated (by rethrowing them).
   final bool _shouldPropagateExceptions;
@@ -1142,7 +1145,7 @@ class AnalysisRuleVisitor implements AstVisitor<void> {
 }
 
 /// The container to register visitors for separate AST node types.
-class NodeLintRegistry {
+class RuleVisitorRegistry {
   final bool _enableTiming;
   final List<_AfterLibrarySubscription> _afterLibrary = [];
   final List<_Subscription<AdjacentStrings>> _forAdjacentStrings = [];
@@ -1360,7 +1363,8 @@ class NodeLintRegistry {
   final List<_Subscription<WithClause>> _forWithClause = [];
   final List<_Subscription<YieldStatement>> _forYieldStatement = [];
 
-  NodeLintRegistry({required bool enableTiming}) : _enableTiming = enableTiming;
+  RuleVisitorRegistry({required bool enableTiming})
+    : _enableTiming = enableTiming;
 
   void addAdjacentStrings(AbstractAnalysisRule rule, AstVisitor visitor) {
     _forAdjacentStrings.add(_Subscription(rule, visitor, _getTimer(rule)));

pkg/analyzer/test/src/dart/analysis/driver_test.dart

@@ -20,6 +20,7 @@ import 'package:analyzer/src/dart/element/element.dart';
 import 'package:analyzer/src/error/codes.dart';
 import 'package:analyzer/src/fine/requirements.dart';
 import 'package:analyzer/src/lint/linter.dart';
+import 'package:analyzer/src/lint/linter_visitor.dart';
 import 'package:analyzer/src/test_utilities/lint_registration_mixin.dart';
 import 'package:analyzer/src/utilities/extensions/async.dart';
 import 'package:analyzer/utilities/package_config_file_builder.dart';
@@ -43487,7 +43488,7 @@ class _AlwaysReportedLint extends LintRule {
 
   @override
   void registerNodeProcessors(
-    NodeLintRegistry registry,
+    RuleVisitorRegistry registry,
     LinterContext context,
   ) {
     var visitor = _AlwaysReportedLintVisitor(this);

pkg/analyzer/test/src/diagnostics/unignorable_ignore_test.dart

@@ -7,6 +7,7 @@ import 'package:analyzer/dart/ast/visitor.dart';
 import 'package:analyzer/error/error.dart';
 import 'package:analyzer/src/error/codes.dart';
 import 'package:analyzer/src/lint/linter.dart';
+import 'package:analyzer/src/lint/linter_visitor.dart';
 import 'package:analyzer/src/test_utilities/lint_registration_mixin.dart';
 import 'package:analyzer_testing/utilities/utilities.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
@@ -100,7 +101,7 @@ class _AvoidIntRule extends LintRule {
 
   @override
   void registerNodeProcessors(
-    NodeLintRegistry registry,
+    RuleVisitorRegistry registry,
     LinterContext context,
   ) {
     var visitor = _AvoidIntVisitor(this);