Skip to content

Commit 89831d8

Browse files
committed
Elements. Remove V1 ElementVisitor.
Change-Id: I3e4128fb72833b535a8f9ea9bdd25a55fb2b952b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/422842 Reviewed-by: Paul Berry <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]>
1 parent b0e12e5 commit 89831d8

File tree

5 files changed

+0
-1002
lines changed

5 files changed

+0
-1002
lines changed

pkg/analyzer/api.txt

Lines changed: 0 additions & 148 deletions
Original file line numberDiff line numberDiff line change
@@ -3184,15 +3184,13 @@ package:analyzer/dart/element/element.dart:
31843184
session (getter: AnalysisSession?)
31853185
sinceSdkVersion (getter: Version?)
31863186
source (getter: Source?)
3187-
accept (method: T? Function<T>(ElementVisitor<T>), deprecated)
31883187
getDisplayString (method: String Function({bool multiline, bool withNullability}))
31893188
getExtendedDisplayName (method: String Function(String?))
31903189
isAccessibleIn (method: bool Function(LibraryElement), deprecated)
31913190
thisOrAncestorMatching (method: E? Function<E extends Element>(bool Function(Element)), deprecated)
31923191
thisOrAncestorMatching3 (method: E? Function<E extends Element>(bool Function(Element)), deprecated)
31933192
thisOrAncestorOfType (method: E? Function<E extends Element>(), deprecated)
31943193
thisOrAncestorOfType3 (method: E? Function<E extends Element>(), deprecated)
3195-
visitChildren (method: void Function(ElementVisitor<dynamic>), deprecated)
31963194
ElementAnnotation (class extends Object implements ConstantEvaluationTarget):
31973195
new (constructor: ElementAnnotation Function())
31983196
constantEvaluationErrors (getter: List<AnalysisError>?)
@@ -3276,34 +3274,6 @@ package:analyzer/dart/element/element.dart:
32763274
new (constructor: ElementLocation Function())
32773275
components (getter: List<String>)
32783276
encoding (getter: String)
3279-
ElementVisitor (class<R> extends Object, deprecated):
3280-
new (constructor: ElementVisitor<R> Function())
3281-
visitClassElement (method: R? Function(ClassElement))
3282-
visitCompilationUnitElement (method: R? Function(CompilationUnitElement))
3283-
visitConstructorElement (method: R? Function(ConstructorElement))
3284-
visitEnumElement (method: R? Function(EnumElement))
3285-
visitExtensionElement (method: R? Function(ExtensionElement))
3286-
visitExtensionTypeElement (method: R? Function(ExtensionTypeElement))
3287-
visitFieldElement (method: R? Function(FieldElement))
3288-
visitFieldFormalParameterElement (method: R? Function(FieldFormalParameterElement))
3289-
visitFunctionElement (method: R? Function(FunctionElement))
3290-
visitGenericFunctionTypeElement (method: R? Function(GenericFunctionTypeElement))
3291-
visitLabelElement (method: R? Function(LabelElement))
3292-
visitLibraryElement (method: R? Function(LibraryElement))
3293-
visitLibraryExportElement (method: R? Function(LibraryExportElement))
3294-
visitLibraryImportElement (method: R? Function(LibraryImportElement))
3295-
visitLocalVariableElement (method: R? Function(LocalVariableElement))
3296-
visitMethodElement (method: R? Function(MethodElement))
3297-
visitMixinElement (method: R? Function(MixinElement))
3298-
visitMultiplyDefinedElement (method: R? Function(MultiplyDefinedElement))
3299-
visitParameterElement (method: R? Function(ParameterElement))
3300-
visitPartElement (method: R? Function(PartElement))
3301-
visitPrefixElement (method: R? Function(PrefixElement))
3302-
visitPropertyAccessorElement (method: R? Function(PropertyAccessorElement))
3303-
visitSuperFormalParameterElement (method: R? Function(SuperFormalParameterElement))
3304-
visitTopLevelVariableElement (method: R? Function(TopLevelVariableElement))
3305-
visitTypeAliasElement (method: R? Function(TypeAliasElement))
3306-
visitTypeParameterElement (method: R? Function(TypeParameterElement))
33073277
EnumElement (class extends Object implements InterfaceElement, deprecated):
33083278
new (constructor: EnumElement Function())
33093279
augmented (getter: AugmentedEnumElement, deprecated)
@@ -4612,124 +4582,6 @@ package:analyzer/dart/element/type_visitor.dart:
46124582
visitRecordType (method: R Function(RecordType, A))
46134583
visitTypeParameterType (method: R Function(TypeParameterType, A))
46144584
visitVoidType (method: R Function(VoidType, A))
4615-
package:analyzer/dart/element/visitor.dart:
4616-
GeneralizingElementVisitor (class<R> extends Object implements ElementVisitor<R>, deprecated):
4617-
new (constructor: GeneralizingElementVisitor<R> Function())
4618-
visitClassElement (method: R? Function(ClassElement))
4619-
visitCompilationUnitElement (method: R? Function(CompilationUnitElement))
4620-
visitConstructorElement (method: R? Function(ConstructorElement))
4621-
visitElement (method: R? Function(Element))
4622-
visitEnumElement (method: R? Function(EnumElement))
4623-
visitExecutableElement (method: R? Function(ExecutableElement))
4624-
visitExtensionElement (method: R? Function(ExtensionElement))
4625-
visitExtensionTypeElement (method: R? Function(ExtensionTypeElement))
4626-
visitFieldElement (method: R? Function(FieldElement))
4627-
visitFieldFormalParameterElement (method: R? Function(FieldFormalParameterElement))
4628-
visitFunctionElement (method: R? Function(FunctionElement))
4629-
visitGenericFunctionTypeElement (method: R? Function(GenericFunctionTypeElement))
4630-
visitLabelElement (method: R? Function(LabelElement))
4631-
visitLibraryElement (method: R? Function(LibraryElement))
4632-
visitLibraryExportElement (method: R? Function(LibraryExportElement))
4633-
visitLibraryImportElement (method: R? Function(LibraryImportElement))
4634-
visitLocalElement (method: R? Function(LocalElement))
4635-
visitLocalVariableElement (method: R? Function(LocalVariableElement))
4636-
visitMethodElement (method: R? Function(MethodElement))
4637-
visitMixinElement (method: R? Function(MixinElement))
4638-
visitMultiplyDefinedElement (method: R? Function(MultiplyDefinedElement))
4639-
visitParameterElement (method: R? Function(ParameterElement))
4640-
visitPartElement (method: R? Function(PartElement))
4641-
visitPrefixElement (method: R? Function(PrefixElement))
4642-
visitPropertyAccessorElement (method: R? Function(PropertyAccessorElement))
4643-
visitPropertyInducingElement (method: R? Function(PropertyInducingElement))
4644-
visitSuperFormalParameterElement (method: R? Function(SuperFormalParameterElement))
4645-
visitTopLevelVariableElement (method: R? Function(TopLevelVariableElement))
4646-
visitTypeAliasElement (method: R? Function(TypeAliasElement))
4647-
visitTypeParameterElement (method: R? Function(TypeParameterElement))
4648-
visitVariableElement (method: R? Function(VariableElement))
4649-
RecursiveElementVisitor (class<R> extends Object implements ElementVisitor<R>, deprecated):
4650-
new (constructor: RecursiveElementVisitor<R> Function())
4651-
visitClassElement (method: R? Function(ClassElement))
4652-
visitCompilationUnitElement (method: R? Function(CompilationUnitElement))
4653-
visitConstructorElement (method: R? Function(ConstructorElement))
4654-
visitEnumElement (method: R? Function(EnumElement))
4655-
visitExtensionElement (method: R? Function(ExtensionElement))
4656-
visitExtensionTypeElement (method: R? Function(ExtensionTypeElement))
4657-
visitFieldElement (method: R? Function(FieldElement))
4658-
visitFieldFormalParameterElement (method: R? Function(FieldFormalParameterElement))
4659-
visitFunctionElement (method: R? Function(FunctionElement))
4660-
visitGenericFunctionTypeElement (method: R? Function(GenericFunctionTypeElement))
4661-
visitLabelElement (method: R? Function(LabelElement))
4662-
visitLibraryElement (method: R? Function(LibraryElement))
4663-
visitLibraryExportElement (method: R? Function(LibraryExportElement))
4664-
visitLibraryImportElement (method: R? Function(LibraryImportElement))
4665-
visitLocalVariableElement (method: R? Function(LocalVariableElement))
4666-
visitMethodElement (method: R? Function(MethodElement))
4667-
visitMixinElement (method: R? Function(MixinElement))
4668-
visitMultiplyDefinedElement (method: R? Function(MultiplyDefinedElement))
4669-
visitParameterElement (method: R? Function(ParameterElement))
4670-
visitPartElement (method: R? Function(PartElement))
4671-
visitPrefixElement (method: R? Function(PrefixElement))
4672-
visitPropertyAccessorElement (method: R? Function(PropertyAccessorElement))
4673-
visitSuperFormalParameterElement (method: R? Function(SuperFormalParameterElement))
4674-
visitTopLevelVariableElement (method: R? Function(TopLevelVariableElement))
4675-
visitTypeAliasElement (method: R? Function(TypeAliasElement))
4676-
visitTypeParameterElement (method: R? Function(TypeParameterElement))
4677-
SimpleElementVisitor (class<R> extends Object implements ElementVisitor<R>, deprecated):
4678-
new (constructor: SimpleElementVisitor<R> Function())
4679-
visitClassElement (method: R? Function(ClassElement))
4680-
visitCompilationUnitElement (method: R? Function(CompilationUnitElement))
4681-
visitConstructorElement (method: R? Function(ConstructorElement))
4682-
visitEnumElement (method: R? Function(EnumElement))
4683-
visitExtensionElement (method: R? Function(ExtensionElement))
4684-
visitExtensionTypeElement (method: R? Function(ExtensionTypeElement))
4685-
visitFieldElement (method: R? Function(FieldElement))
4686-
visitFieldFormalParameterElement (method: R? Function(FieldFormalParameterElement))
4687-
visitFunctionElement (method: R? Function(FunctionElement))
4688-
visitGenericFunctionTypeElement (method: R? Function(GenericFunctionTypeElement))
4689-
visitLabelElement (method: R? Function(LabelElement))
4690-
visitLibraryElement (method: R? Function(LibraryElement))
4691-
visitLibraryExportElement (method: R? Function(LibraryExportElement))
4692-
visitLibraryImportElement (method: R? Function(LibraryImportElement))
4693-
visitLocalVariableElement (method: R? Function(LocalVariableElement))
4694-
visitMethodElement (method: R? Function(MethodElement))
4695-
visitMixinElement (method: R? Function(MixinElement))
4696-
visitMultiplyDefinedElement (method: R? Function(MultiplyDefinedElement))
4697-
visitParameterElement (method: R? Function(ParameterElement))
4698-
visitPartElement (method: R? Function(PartElement))
4699-
visitPrefixElement (method: R? Function(PrefixElement))
4700-
visitPropertyAccessorElement (method: R? Function(PropertyAccessorElement))
4701-
visitSuperFormalParameterElement (method: R? Function(SuperFormalParameterElement))
4702-
visitTopLevelVariableElement (method: R? Function(TopLevelVariableElement))
4703-
visitTypeAliasElement (method: R? Function(TypeAliasElement))
4704-
visitTypeParameterElement (method: R? Function(TypeParameterElement))
4705-
ThrowingElementVisitor (class<R> extends Object implements ElementVisitor<R>, deprecated):
4706-
new (constructor: ThrowingElementVisitor<R> Function())
4707-
visitClassElement (method: R? Function(ClassElement))
4708-
visitCompilationUnitElement (method: R? Function(CompilationUnitElement))
4709-
visitConstructorElement (method: R? Function(ConstructorElement))
4710-
visitEnumElement (method: R? Function(EnumElement))
4711-
visitExtensionElement (method: R? Function(ExtensionElement))
4712-
visitExtensionTypeElement (method: R? Function(ExtensionTypeElement))
4713-
visitFieldElement (method: R? Function(FieldElement))
4714-
visitFieldFormalParameterElement (method: R? Function(FieldFormalParameterElement))
4715-
visitFunctionElement (method: R? Function(FunctionElement))
4716-
visitGenericFunctionTypeElement (method: R? Function(GenericFunctionTypeElement))
4717-
visitLabelElement (method: R? Function(LabelElement))
4718-
visitLibraryElement (method: R? Function(LibraryElement))
4719-
visitLibraryExportElement (method: R? Function(LibraryExportElement))
4720-
visitLibraryImportElement (method: R? Function(LibraryImportElement))
4721-
visitLocalVariableElement (method: R? Function(LocalVariableElement))
4722-
visitMethodElement (method: R? Function(MethodElement))
4723-
visitMixinElement (method: R? Function(MixinElement))
4724-
visitMultiplyDefinedElement (method: R? Function(MultiplyDefinedElement))
4725-
visitParameterElement (method: R? Function(ParameterElement))
4726-
visitPartElement (method: R? Function(PartElement))
4727-
visitPrefixElement (method: R? Function(PrefixElement))
4728-
visitPropertyAccessorElement (method: R? Function(PropertyAccessorElement))
4729-
visitSuperFormalParameterElement (method: R? Function(SuperFormalParameterElement))
4730-
visitTopLevelVariableElement (method: R? Function(TopLevelVariableElement))
4731-
visitTypeAliasElement (method: R? Function(TypeAliasElement))
4732-
visitTypeParameterElement (method: R? Function(TypeParameterElement))
47334585
package:analyzer/dart/element/visitor2.dart:
47344586
GeneralizingElementVisitor2 (class<R> extends Object implements ElementVisitor2<R>):
47354587
new (constructor: GeneralizingElementVisitor2<R> Function())

pkg/analyzer/lib/dart/element/element.dart

Lines changed: 0 additions & 78 deletions
Original file line numberDiff line numberDiff line change
@@ -807,13 +807,6 @@ abstract class Element implements AnalysisTarget {
807807
@override
808808
Source? get source;
809809

810-
/// Uses the given [visitor] to visit this element.
811-
///
812-
/// Returns the value returned by the visitor as a result of visiting this
813-
/// element.
814-
@Deprecated('Use Element2 and accept2() instead')
815-
T? accept<T>(ElementVisitor<T> visitor);
816-
817810
/// Returns the presentation of this element as it should appear when
818811
/// presented to users.
819812
///
@@ -879,11 +872,6 @@ abstract class Element implements AnalysisTarget {
879872
/// that has the given type, or `null` if there is no such element.
880873
@Deprecated('Use Element2.thisOrAncestorMatching2() instead')
881874
E? thisOrAncestorOfType3<E extends Element>();
882-
883-
/// Uses the given [visitor] to visit all of the children of this element.
884-
/// There is no guarantee of the order in which the children will be visited.
885-
@Deprecated('Use Element2 and visitChildren2() instead')
886-
void visitChildren(ElementVisitor visitor);
887875
}
888876

889877
/// A single annotation associated with an element.
@@ -1193,72 +1181,6 @@ abstract class ElementLocation {
11931181
String get encoding;
11941182
}
11951183

1196-
/// An object that can be used to visit an element structure.
1197-
///
1198-
/// Clients may not extend, implement or mix-in this class. There are classes
1199-
/// that implement this interface that provide useful default behaviors in
1200-
/// `package:analyzer/dart/element/visitor.dart`. A couple of the most useful
1201-
/// include
1202-
/// * SimpleElementVisitor which implements every visit method by doing nothing,
1203-
/// * RecursiveElementVisitor which will cause every node in a structure to be
1204-
/// visited, and
1205-
/// * ThrowingElementVisitor which implements every visit method by throwing an
1206-
/// exception.
1207-
@Deprecated('Use ElementVisitor2 instead')
1208-
abstract class ElementVisitor<R> {
1209-
R? visitClassElement(ClassElement element);
1210-
1211-
R? visitCompilationUnitElement(CompilationUnitElement element);
1212-
1213-
R? visitConstructorElement(ConstructorElement element);
1214-
1215-
R? visitEnumElement(EnumElement element);
1216-
1217-
R? visitExtensionElement(ExtensionElement element);
1218-
1219-
R? visitExtensionTypeElement(ExtensionTypeElement element);
1220-
1221-
R? visitFieldElement(FieldElement element);
1222-
1223-
R? visitFieldFormalParameterElement(FieldFormalParameterElement element);
1224-
1225-
R? visitFunctionElement(FunctionElement element);
1226-
1227-
R? visitGenericFunctionTypeElement(GenericFunctionTypeElement element);
1228-
1229-
R? visitLabelElement(LabelElement element);
1230-
1231-
R? visitLibraryElement(LibraryElement element);
1232-
1233-
R? visitLibraryExportElement(LibraryExportElement element);
1234-
1235-
R? visitLibraryImportElement(LibraryImportElement element);
1236-
1237-
R? visitLocalVariableElement(LocalVariableElement element);
1238-
1239-
R? visitMethodElement(MethodElement element);
1240-
1241-
R? visitMixinElement(MixinElement element);
1242-
1243-
R? visitMultiplyDefinedElement(MultiplyDefinedElement element);
1244-
1245-
R? visitParameterElement(ParameterElement element);
1246-
1247-
R? visitPartElement(PartElement element);
1248-
1249-
R? visitPrefixElement(PrefixElement element);
1250-
1251-
R? visitPropertyAccessorElement(PropertyAccessorElement element);
1252-
1253-
R? visitSuperFormalParameterElement(SuperFormalParameterElement element);
1254-
1255-
R? visitTopLevelVariableElement(TopLevelVariableElement element);
1256-
1257-
R? visitTypeAliasElement(TypeAliasElement element);
1258-
1259-
R? visitTypeParameterElement(TypeParameterElement element);
1260-
}
1261-
12621184
/// An element that represents an enum.
12631185
///
12641186
/// Clients may not extend, implement or mix-in this class.

0 commit comments

Comments
 (0)