[dot-shorthands][co19] Rename enum-shorthands flag to dot-shorthands (and roll co19 to b14b080)

We've decided to rename enum shorthands to dot shorthands. It describes the entire feature better. It's not only for enum values. We'll update the experiment name before the implementation goes in, that way our users can use a flag that matches the actual feature name.

Additionally, roll co19 to b14b0802e696a60c79b00d0f052e26fb986f0faf so we can avoid an infra failure with co19 using what's now an unknown feature flag (enum-shorthands).

2025-02-06 [email protected] Fixes dart-lang/co19#3067. Rename the static access shorthand feature experiment flag (dart-lang/co19#3068)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Bug: #57037
Change-Id: I031e3bce8166145b24dbb77acf259d78e6e00f0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/407603
Reviewed-by: Alexander Thomas <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Commit-Queue: Kallen Tu <[email protected]>

Author: kallentu

DEPS

@@ -54,7 +54,7 @@ vars = {
 
   # co19 is a cipd package automatically generated for each co19 commit.
   # Use tests/co19/update.sh to update this hash.
-  "co19_rev": "dd7fa9c980a47c5196c192046f5d4a43dbce70ef",
+  "co19_rev": "b14b0802e696a60c79b00d0f052e26fb986f0faf",
 
   # The internal benchmarks to use. See go/dart-benchmarks-internal
   "benchmarks_internal_rev": "6e26684f965f797471d9d424beef5cf0908c60ee",

pkg/_fe_analyzer_shared/lib/src/experiments/flags.dart

@@ -59,6 +59,13 @@ enum ExperimentalFlag {
       experimentEnabledVersion: const Version(3, 6),
       experimentReleasedVersion: const Version(3, 6)),
 
+  dotShorthands(
+      name: 'dot-shorthands',
+      isEnabledByDefault: false,
+      isExpired: false,
+      experimentEnabledVersion: defaultLanguageVersion,
+      experimentReleasedVersion: defaultLanguageVersion),
+
   enhancedEnums(
       name: 'enhanced-enums',
       isEnabledByDefault: true,
@@ -73,13 +80,6 @@ enum ExperimentalFlag {
       experimentEnabledVersion: defaultLanguageVersion,
       experimentReleasedVersion: const Version(3, 6)),
 
-  enumShorthands(
-      name: 'enum-shorthands',
-      isEnabledByDefault: false,
-      isExpired: false,
-      experimentEnabledVersion: defaultLanguageVersion,
-      experimentReleasedVersion: defaultLanguageVersion),
-
   extensionMethods(
       name: 'extension-methods',
       isEnabledByDefault: true,

pkg/analyzer/lib/dart/analysis/features.dart

@@ -31,15 +31,15 @@ abstract class Feature {
   static final control_flow_collections =
       ExperimentalFeatures.control_flow_collections;
 
+  /// Feature information for dot shorthands.
+  static final dot_shorthands = ExperimentalFeatures.dot_shorthands;
+
   /// Feature information for enhanced enums.
   static final enhanced_enums = ExperimentalFeatures.enhanced_enums;
 
   /// Feature information for enhanced parts.
   static final enhanced_parts = ExperimentalFeatures.enhanced_parts;
 
-  /// Feature information for enum shorthands.
-  static final enum_shorthands = ExperimentalFeatures.enum_shorthands;
-
   /// Feature information for extension methods.
   static final extension_methods = ExperimentalFeatures.extension_methods;
 

pkg/analyzer/lib/src/dart/analysis/driver.dart

@@ -97,7 +97,7 @@ import 'package:meta/meta.dart';
 // TODO(scheglov): Clean up the list of implicitly analyzed files.
 class AnalysisDriver {
   /// The version of data format, should be incremented on every format change.
-  static const int DATA_VERSION = 429;
+  static const int DATA_VERSION = 430;
 
   /// The number of exception contexts allowed to write. Once this field is
   /// zero, we stop writing any new exception contexts in this process.

pkg/analyzer/lib/src/dart/analysis/experiments.g.dart

@@ -24,9 +24,9 @@ final _knownFeatures = <String, ExperimentalFeature>{
   EnableString.control_flow_collections:
       ExperimentalFeatures.control_flow_collections,
   EnableString.digit_separators: ExperimentalFeatures.digit_separators,
+  EnableString.dot_shorthands: ExperimentalFeatures.dot_shorthands,
   EnableString.enhanced_enums: ExperimentalFeatures.enhanced_enums,
   EnableString.enhanced_parts: ExperimentalFeatures.enhanced_parts,
-  EnableString.enum_shorthands: ExperimentalFeatures.enum_shorthands,
   EnableString.extension_methods: ExperimentalFeatures.extension_methods,
   EnableString.generic_metadata: ExperimentalFeatures.generic_metadata,
   EnableString.getter_setter_error: ExperimentalFeatures.getter_setter_error,
@@ -84,15 +84,15 @@ class EnableString {
   /// String to enable the experiment "digit-separators"
   static const String digit_separators = 'digit-separators';
 
+  /// String to enable the experiment "dot-shorthands"
+  static const String dot_shorthands = 'dot-shorthands';
+
   /// String to enable the experiment "enhanced-enums"
   static const String enhanced_enums = 'enhanced-enums';
 
   /// String to enable the experiment "enhanced-parts"
   static const String enhanced_parts = 'enhanced-parts';
 
-  /// String to enable the experiment "enum-shorthands"
-  static const String enum_shorthands = 'enum-shorthands';
-
   /// String to enable the experiment "extension-methods"
   static const String extension_methods = 'extension-methods';
 
@@ -258,8 +258,19 @@ class ExperimentalFeatures {
     channels: ["stable", "beta", "dev", "main"],
   );
 
-  static final enhanced_enums = ExperimentalFeature(
+  static final dot_shorthands = ExperimentalFeature(
     index: 7,
+    enableString: EnableString.dot_shorthands,
+    isEnabledByDefault: IsEnabledByDefault.dot_shorthands,
+    isExpired: IsExpired.dot_shorthands,
+    documentation: 'Shorter dot syntax for static accesses.',
+    experimentalReleaseVersion: null,
+    releaseVersion: null,
+    channels: ["stable", "beta", "dev", "main"],
+  );
+
+  static final enhanced_enums = ExperimentalFeature(
+    index: 8,
     enableString: EnableString.enhanced_enums,
     isEnabledByDefault: IsEnabledByDefault.enhanced_enums,
     isExpired: IsExpired.enhanced_enums,
@@ -270,7 +281,7 @@ class ExperimentalFeatures {
   );
 
   static final enhanced_parts = ExperimentalFeature(
-    index: 8,
+    index: 9,
     enableString: EnableString.enhanced_parts,
     isEnabledByDefault: IsEnabledByDefault.enhanced_parts,
     isExpired: IsExpired.enhanced_parts,
@@ -280,17 +291,6 @@ class ExperimentalFeatures {
     channels: ["stable", "beta", "dev", "main"],
   );
 
-  static final enum_shorthands = ExperimentalFeature(
-    index: 9,
-    enableString: EnableString.enum_shorthands,
-    isEnabledByDefault: IsEnabledByDefault.enum_shorthands,
-    isExpired: IsExpired.enum_shorthands,
-    documentation: 'Shorter dot syntax for enum values.',
-    experimentalReleaseVersion: null,
-    releaseVersion: null,
-    channels: ["stable", "beta", "dev", "main"],
-  );
-
   static final extension_methods = ExperimentalFeature(
     index: 10,
     enableString: EnableString.extension_methods,
@@ -631,15 +631,15 @@ class IsEnabledByDefault {
   /// Default state of the experiment "digit-separators"
   static const bool digit_separators = true;
 
+  /// Default state of the experiment "dot-shorthands"
+  static const bool dot_shorthands = false;
+
   /// Default state of the experiment "enhanced-enums"
   static const bool enhanced_enums = true;
 
   /// Default state of the experiment "enhanced-parts"
   static const bool enhanced_parts = false;
 
-  /// Default state of the experiment "enum-shorthands"
-  static const bool enum_shorthands = false;
-
   /// Default state of the experiment "extension-methods"
   static const bool extension_methods = true;
 
@@ -750,15 +750,15 @@ class IsExpired {
   /// Expiration status of the experiment "digit-separators"
   static const bool digit_separators = true;
 
+  /// Expiration status of the experiment "dot-shorthands"
+  static const bool dot_shorthands = false;
+
   /// Expiration status of the experiment "enhanced-enums"
   static const bool enhanced_enums = true;
 
   /// Expiration status of the experiment "enhanced-parts"
   static const bool enhanced_parts = false;
 
-  /// Expiration status of the experiment "enum-shorthands"
-  static const bool enum_shorthands = false;
-
   /// Expiration status of the experiment "extension-methods"
   static const bool extension_methods = true;
 
@@ -869,15 +869,15 @@ mixin _CurrentState {
   /// Current state for the flag "digit-separators"
   bool get digit_separators => isEnabled(ExperimentalFeatures.digit_separators);
 
+  /// Current state for the flag "dot-shorthands"
+  bool get dot_shorthands => isEnabled(ExperimentalFeatures.dot_shorthands);
+
   /// Current state for the flag "enhanced-enums"
   bool get enhanced_enums => isEnabled(ExperimentalFeatures.enhanced_enums);
 
   /// Current state for the flag "enhanced-parts"
   bool get enhanced_parts => isEnabled(ExperimentalFeatures.enhanced_parts);
 
-  /// Current state for the flag "enum-shorthands"
-  bool get enum_shorthands => isEnabled(ExperimentalFeatures.enum_shorthands);
-
   /// Current state for the flag "extension-methods"
   bool get extension_methods =>
       isEnabled(ExperimentalFeatures.extension_methods);

pkg/front_end/lib/src/api_prototype/experimental_flags_generated.dart

@@ -115,6 +115,14 @@ class ExperimentalFlag {
       experimentEnabledVersion: const Version(3, 6),
       experimentReleasedVersion: const Version(3, 6));
 
+  static const ExperimentalFlag dotShorthands = const ExperimentalFlag(
+      name: 'dot-shorthands',
+      isEnabledByDefault: false,
+      isExpired: false,
+      enabledVersion: defaultLanguageVersion,
+      experimentEnabledVersion: defaultLanguageVersion,
+      experimentReleasedVersion: defaultLanguageVersion);
+
   static const ExperimentalFlag enhancedEnums = const ExperimentalFlag(
       name: 'enhanced-enums',
       isEnabledByDefault: true,
@@ -131,14 +139,6 @@ class ExperimentalFlag {
       experimentEnabledVersion: defaultLanguageVersion,
       experimentReleasedVersion: const Version(3, 6));
 
-  static const ExperimentalFlag enumShorthands = const ExperimentalFlag(
-      name: 'enum-shorthands',
-      isEnabledByDefault: false,
-      isExpired: false,
-      enabledVersion: defaultLanguageVersion,
-      experimentEnabledVersion: defaultLanguageVersion,
-      experimentReleasedVersion: defaultLanguageVersion);
-
   static const ExperimentalFlag extensionMethods = const ExperimentalFlag(
       name: 'extension-methods',
       isEnabledByDefault: true,
@@ -442,6 +442,10 @@ class GlobalFeatures {
   GlobalFeature get digitSeparators => _digitSeparators ??=
       _computeGlobalFeature(ExperimentalFlag.digitSeparators);
 
+  GlobalFeature? _dotShorthands;
+  GlobalFeature get dotShorthands =>
+      _dotShorthands ??= _computeGlobalFeature(ExperimentalFlag.dotShorthands);
+
   GlobalFeature? _enhancedEnums;
   GlobalFeature get enhancedEnums =>
       _enhancedEnums ??= _computeGlobalFeature(ExperimentalFlag.enhancedEnums);
@@ -450,10 +454,6 @@ class GlobalFeatures {
   GlobalFeature get enhancedParts =>
       _enhancedParts ??= _computeGlobalFeature(ExperimentalFlag.enhancedParts);
 
-  GlobalFeature? _enumShorthands;
-  GlobalFeature get enumShorthands => _enumShorthands ??=
-      _computeGlobalFeature(ExperimentalFlag.enumShorthands);
-
   GlobalFeature? _extensionMethods;
   GlobalFeature get extensionMethods => _extensionMethods ??=
       _computeGlobalFeature(ExperimentalFlag.extensionMethods);
@@ -621,6 +621,11 @@ class LibraryFeatures {
       _digitSeparators ??= globalFeatures._computeLibraryFeature(
           ExperimentalFlag.digitSeparators, canonicalUri, libraryVersion);
 
+  LibraryFeature? _dotShorthands;
+  LibraryFeature get dotShorthands =>
+      _dotShorthands ??= globalFeatures._computeLibraryFeature(
+          ExperimentalFlag.dotShorthands, canonicalUri, libraryVersion);
+
   LibraryFeature? _enhancedEnums;
   LibraryFeature get enhancedEnums =>
       _enhancedEnums ??= globalFeatures._computeLibraryFeature(
@@ -631,11 +636,6 @@ class LibraryFeatures {
       _enhancedParts ??= globalFeatures._computeLibraryFeature(
           ExperimentalFlag.enhancedParts, canonicalUri, libraryVersion);
 
-  LibraryFeature? _enumShorthands;
-  LibraryFeature get enumShorthands =>
-      _enumShorthands ??= globalFeatures._computeLibraryFeature(
-          ExperimentalFlag.enumShorthands, canonicalUri, libraryVersion);
-
   LibraryFeature? _extensionMethods;
   LibraryFeature get extensionMethods =>
       _extensionMethods ??= globalFeatures._computeLibraryFeature(
@@ -798,12 +798,12 @@ class LibraryFeatures {
         return controlFlowCollections;
       case shared.ExperimentalFlag.digitSeparators:
         return digitSeparators;
+      case shared.ExperimentalFlag.dotShorthands:
+        return dotShorthands;
       case shared.ExperimentalFlag.enhancedEnums:
         return enhancedEnums;
       case shared.ExperimentalFlag.enhancedParts:
         return enhancedParts;
-      case shared.ExperimentalFlag.enumShorthands:
-        return enumShorthands;
       case shared.ExperimentalFlag.extensionMethods:
         return extensionMethods;
       case shared.ExperimentalFlag.genericMetadata:
@@ -882,12 +882,12 @@ ExperimentalFlag? parseExperimentalFlag(String flag) {
       return ExperimentalFlag.controlFlowCollections;
     case "digit-separators":
       return ExperimentalFlag.digitSeparators;
+    case "dot-shorthands":
+      return ExperimentalFlag.dotShorthands;
     case "enhanced-enums":
       return ExperimentalFlag.enhancedEnums;
     case "enhanced-parts":
       return ExperimentalFlag.enhancedParts;
-    case "enum-shorthands":
-      return ExperimentalFlag.enumShorthands;
     case "extension-methods":
       return ExperimentalFlag.extensionMethods;
     case "generic-metadata":
@@ -965,12 +965,12 @@ final Map<ExperimentalFlag, bool> defaultExperimentalFlags = {
       ExperimentalFlag.controlFlowCollections.isEnabledByDefault,
   ExperimentalFlag.digitSeparators:
       ExperimentalFlag.digitSeparators.isEnabledByDefault,
+  ExperimentalFlag.dotShorthands:
+      ExperimentalFlag.dotShorthands.isEnabledByDefault,
   ExperimentalFlag.enhancedEnums:
       ExperimentalFlag.enhancedEnums.isEnabledByDefault,
   ExperimentalFlag.enhancedParts:
       ExperimentalFlag.enhancedParts.isEnabledByDefault,
-  ExperimentalFlag.enumShorthands:
-      ExperimentalFlag.enumShorthands.isEnabledByDefault,
   ExperimentalFlag.extensionMethods:
       ExperimentalFlag.extensionMethods.isEnabledByDefault,
   ExperimentalFlag.genericMetadata:
@@ -1039,9 +1039,9 @@ const Map<shared.ExperimentalFlag, ExperimentalFlag> sharedExperimentalFlags = {
   shared.ExperimentalFlag.controlFlowCollections:
       ExperimentalFlag.controlFlowCollections,
   shared.ExperimentalFlag.digitSeparators: ExperimentalFlag.digitSeparators,
+  shared.ExperimentalFlag.dotShorthands: ExperimentalFlag.dotShorthands,
   shared.ExperimentalFlag.enhancedEnums: ExperimentalFlag.enhancedEnums,
   shared.ExperimentalFlag.enhancedParts: ExperimentalFlag.enhancedParts,
-  shared.ExperimentalFlag.enumShorthands: ExperimentalFlag.enumShorthands,
   shared.ExperimentalFlag.extensionMethods: ExperimentalFlag.extensionMethods,
   shared.ExperimentalFlag.genericMetadata: ExperimentalFlag.genericMetadata,
   shared.ExperimentalFlag.getterSetterError: ExperimentalFlag.getterSetterError,

tests/language/enum_shorthands/constructor/constructor_cascade_test.dart

@@ -4,7 +4,7 @@
 
 // Context type is propagated down in cascades for constructor enum shorthands.
 
-// SharedOptions=--enable-experiment=enum-shorthands
+// SharedOptions=--enable-experiment=dot-shorthands
 
 import '../enum_shorthand_helper.dart';
 

tests/language/enum_shorthands/constructor/constructor_collection_literal_test.dart

@@ -5,7 +5,7 @@
 // Context type is propagated down in collection literals.
 // Testing with constructor shorthands.
 
-// SharedOptions=--enable-experiment=enum-shorthands
+// SharedOptions=--enable-experiment=dot-shorthands
 
 import '../enum_shorthand_helper.dart';
 

tests/language/enum_shorthands/constructor/constructor_error_test.dart

@@ -4,7 +4,7 @@
 
 // Errors involving enum shorthands of constructors.
 
-// SharedOptions=--enable-experiment=enum-shorthands
+// SharedOptions=--enable-experiment=dot-shorthands
 
 import '../enum_shorthand_helper.dart';
 

tests/language/enum_shorthands/constructor/constructor_future_or_test.dart

@@ -5,7 +5,7 @@
 // `FutureOr<S>` denotes the same namespace as `S` for enum shorthands on
 // constructors.
 
-// SharedOptions=--enable-experiment=enum-shorthands
+// SharedOptions=--enable-experiment=dot-shorthands
 
 import 'dart:async';