[element model] migrate avoid_implementing_value_types

Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: If4b94dcc815a1f83372b91e8c1e67afd2eae996f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/389560
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>

Author: pq

pkg/linter/analyzer_use_new_elements.txt

@@ -22,6 +22,7 @@ lib/src/rules/avoid_empty_else.dart
 lib/src/rules/avoid_escaping_inner_quotes.dart
 lib/src/rules/avoid_final_parameters.dart
 lib/src/rules/avoid_function_literals_in_foreach_calls.dart
+lib/src/rules/avoid_implementing_value_types.dart
 lib/src/rules/avoid_js_rounded_ints.dart
 lib/src/rules/avoid_multiple_declarations_per_line.dart
 lib/src/rules/avoid_print.dart
@@ -139,6 +140,7 @@ lib/src/rules/sort_constructors_first.dart
 lib/src/rules/sort_unnamed_constructors_first.dart
 lib/src/rules/specify_nonobvious_local_variable_types.dart
 lib/src/rules/super_goes_last.dart
+lib/src/rules/test_types_in_equals.dart
 lib/src/rules/throw_in_finally.dart
 lib/src/rules/tighten_type_of_initializing_formals.dart
 lib/src/rules/type_annotate_public_apis.dart

pkg/linter/lib/src/rules/avoid_implementing_value_types.dart

@@ -4,7 +4,7 @@
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
-import 'package:analyzer/dart/element/element.dart';
+import 'package:analyzer/dart/element/element2.dart';
 import 'package:analyzer/dart/element/type.dart';
 
 import '../analyzer.dart';
@@ -24,34 +24,39 @@ class AvoidImplementingValueTypes extends LintRule {
   @override
   void registerNodeProcessors(
       NodeLintRegistry registry, LinterContext context) {
-    var visitor = _Visitor(this);
+    var visitor = _Visitor(this, context.inheritanceManager);
     registry.addClassDeclaration(this, visitor);
   }
 }
 
 class _Visitor extends SimpleAstVisitor<void> {
+  static var equalsName = Name(null, '==');
+
   final LintRule rule;
+  final InheritanceManager3 inheritanceManager;
 
-  _Visitor(this.rule);
+  _Visitor(this.rule, this.inheritanceManager);
 
   @override
   void visitClassDeclaration(ClassDeclaration node) {
     var implementsClause = node.implementsClause;
     if (implementsClause == null) {
       return;
     }
+
     for (var interface in implementsClause.interfaces) {
       var interfaceType = interface.type;
       if (interfaceType is InterfaceType &&
-          _overridesEquals(interfaceType.element)) {
+          _overridesEquals(interfaceType.element3)) {
         rule.reportLint(interface);
       }
     }
   }
 
-  static bool _overridesEquals(InterfaceElement element) {
-    var method = element.lookUpConcreteMethod('==', element.library);
-    var enclosing = method?.enclosingElement3;
-    return enclosing is ClassElement && !enclosing.isDartCoreObject;
+  bool _overridesEquals(InterfaceElement2 element) {
+    var member =
+        inheritanceManager.getMember4(element, equalsName, concrete: true);
+    var definingLibrary = member?.enclosingElement2?.library2;
+    return definingLibrary != null && !definingLibrary.isDartCore;
   }
 }

pkg/linter/test/rules/avoid_implementing_value_types_test.dart

@@ -75,6 +75,13 @@ class C implements A {}
     ]);
   }
 
+  test_implementsClassWithoutEqualEqual() async {
+    await assertNoDiagnostics(r'''
+class A {}
+class C implements A {}
+''');
+  }
+
   test_mixin() async {
     await assertNoDiagnostics(r'''
 mixin M {