[element model] migrate prefer_initializing_formals

Bug: #59548
Change-Id: I8a510f82c5a938610d7f46b85fcf3f906bbb700e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398920
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>

Author: pq

pkg/linter/analyzer_use_new_elements.txt

@@ -1,6 +1,5 @@
 lib/src/extensions.dart
 lib/src/rules/invalid_runtime_check_with_js_interop_types.dart
-lib/src/rules/prefer_initializing_formals.dart
 lib/src/rules/unnecessary_overrides.dart
 lib/src/rules/use_build_context_synchronously.dart
 lib/src/rules/use_late_for_private_fields_and_variables.dart

pkg/linter/lib/src/rules/prefer_initializing_formals.dart

@@ -4,7 +4,7 @@
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
-import 'package:analyzer/dart/element/element.dart';
+import 'package:analyzer/dart/element/element2.dart';
 
 import '../analyzer.dart';
 import '../extensions.dart';
@@ -32,14 +32,14 @@ Iterable<ConstructorFieldInitializer>
             ConstructorDeclaration node) =>
         node.initializers.whereType<ConstructorFieldInitializer>();
 
-Element? _getLeftElement(AssignmentExpression assignment) =>
-    assignment.writeElement?.canonicalElement;
+Element2? _getLeftElement(AssignmentExpression assignment) =>
+    assignment.writeElement2?.canonicalElement2;
 
-Iterable<Element?> _getParameters(ConstructorDeclaration node) =>
-    node.parameters.parameters.map((e) => e.declaredElement);
+Iterable<FormalParameterElement?> _getParameters(ConstructorDeclaration node) =>
+    node.parameters.parameters.map((e) => e.declaredFragment?.element);
 
-Element? _getRightElement(AssignmentExpression assignment) =>
-    assignment.rightHandSide.canonicalElement;
+Element2? _getRightElement(AssignmentExpression assignment) =>
+    assignment.rightHandSide.canonicalElement2;
 
 class PreferInitializingFormals extends LintRule {
   PreferInitializingFormals()
@@ -73,24 +73,24 @@ class _Visitor extends SimpleAstVisitor<void> {
     }
 
     var parameters = _getParameters(node);
-    var parametersUsedOnce = <Element?>{};
-    var parametersUsedMoreThanOnce = <Element?>{};
+    var parametersUsedOnce = <Element2?>{};
+    var parametersUsedMoreThanOnce = <Element2?>{};
 
     bool isAssignmentExpressionToLint(AssignmentExpression assignment) {
       var leftElement = _getLeftElement(assignment);
       var rightElement = _getRightElement(assignment);
       return leftElement != null &&
           rightElement != null &&
-          leftElement.name == rightElement.name &&
+          leftElement.name3 == rightElement.name3 &&
           !leftElement.isPrivate &&
-          leftElement is FieldElement &&
+          leftElement is FieldElement2 &&
           !leftElement.isSynthetic &&
-          leftElement.enclosingElement3 ==
-              node.declaredElement?.enclosingElement3 &&
+          leftElement.enclosingElement2 ==
+              node.declaredFragment?.element.enclosingElement2 &&
           parameters.contains(rightElement) &&
           (!parametersUsedMoreThanOnce.contains(rightElement) &&
-                  !(rightElement as ParameterElement).isNamed ||
-              leftElement.name == rightElement.name);
+                  !(rightElement as FormalParameterElement).isNamed ||
+              leftElement.name3 == rightElement.name3);
     }
 
     bool isConstructorFieldInitializerToLint(
@@ -101,28 +101,30 @@ class _Visitor extends SimpleAstVisitor<void> {
         if (fieldName.name != expression.name) {
           return false;
         }
-        var staticElement = expression.staticElement;
-        return staticElement is ParameterElement &&
-            !(constructorFieldInitializer.fieldName.staticElement?.isPrivate ??
+        var staticElement = expression.element;
+        return staticElement is FormalParameterElement &&
+            !(constructorFieldInitializer.fieldName.element?.isPrivate ??
                 true) &&
             parameters.contains(staticElement) &&
-            (!parametersUsedMoreThanOnce.contains(expression.staticElement) &&
+            (!parametersUsedMoreThanOnce.contains(expression.element) &&
                     !staticElement.isNamed ||
-                (constructorFieldInitializer.fieldName.staticElement?.name ==
-                    expression.staticElement?.name));
+                (constructorFieldInitializer.fieldName.element?.name3 ==
+                    expression.element?.name3));
       }
       return false;
     }
 
-    void processElement(Element? element) {
+    void processElement(Element2? element) {
       if (!parametersUsedOnce.add(element)) {
         parametersUsedMoreThanOnce.add(element);
       }
     }
 
-    var parameterElements = node.parameters.parameterElements;
-    for (var parameter in parameterElements) {
-      if (parameter?.isInitializingFormal ?? false) {
+    for (var parameterFragment in node.parameters.parameterFragments) {
+      if (parameterFragment == null) continue;
+
+      var parameter = parameterFragment.element;
+      if (parameter.isInitializingFormal) {
         processElement(parameter);
       }
     }
@@ -137,8 +139,7 @@ class _Visitor extends SimpleAstVisitor<void> {
     var initializers = _getConstructorFieldInitializersInInitializers(node);
     for (var initializer in initializers) {
       if (isConstructorFieldInitializerToLint(initializer)) {
-        processElement(
-            (initializer.expression as SimpleIdentifier).staticElement);
+        processElement((initializer.expression as SimpleIdentifier).element);
       }
     }
 
@@ -151,7 +152,7 @@ class _Visitor extends SimpleAstVisitor<void> {
 
     for (var initializer in initializers) {
       if (isConstructorFieldInitializerToLint(initializer)) {
-        var name = initializer.fieldName.staticElement!.name!;
+        var name = initializer.fieldName.element!.name3!;
         rule.reportLint(initializer, arguments: [name]);
       }
     }