Skip to content

Commit 8cfa901

Browse files
fshcheglovCommit Queue
authored andcommitted
Rename nameOffset2 to nameOffset
Change-Id: I3c8051840122b6046bc89ed48ec329c825607fe5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/440180 Reviewed-by: Samuel Rawlins <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
1 parent bb2ba56 commit 8cfa901

File tree

61 files changed

+250
-226
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

61 files changed

+250
-226
lines changed

pkg/analysis_server/lib/src/cider/rename.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ class CheckNameResponse {
240240
infos.add(
241241
ReplaceInfo(
242242
newName,
243-
lineInfo.getLocation(getter.firstFragment.nameOffset2!),
243+
lineInfo.getLocation(getter.firstFragment.nameOffset!),
244244
getter.name!.length,
245245
),
246246
);
@@ -250,7 +250,7 @@ class CheckNameResponse {
250250
infos.add(
251251
ReplaceInfo(
252252
newName,
253-
lineInfo.getLocation(setter.firstFragment.nameOffset2!),
253+
lineInfo.getLocation(setter.firstFragment.nameOffset!),
254254
setter.name!.length,
255255
),
256256
);
@@ -290,7 +290,7 @@ class CheckNameResponse {
290290
} else {
291291
var location = (await canRename._fileResolver.resolve(
292292
path: sourcePath,
293-
)).lineInfo.getLocation(element.firstFragment.nameOffset2!);
293+
)).lineInfo.getLocation(element.firstFragment.nameOffset!);
294294
infos.add(ReplaceInfo(newName, location, element.name!.length));
295295
}
296296
return infos;
@@ -305,7 +305,7 @@ class CheckNameResponse {
305305
var libraryFragment = firstFragment.libraryFragment;
306306
var sourcePath = libraryFragment.source.fullName;
307307
var location = libraryFragment.lineInfo.getLocation(
308-
firstFragment.nameOffset2!,
308+
firstFragment.nameOffset!,
309309
);
310310
CiderSearchMatch ciderMatch;
311311
var searchInfo = CiderSearchInfo(

pkg/analysis_server/lib/src/computer/computer_call_hierarchy.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ class CallHierarchyItem {
135135
element = _nonSynthetic(element);
136136
var fragment = element.firstFragment as FragmentImpl;
137137

138-
var nameOffset = fragment.nameOffset2;
138+
var nameOffset = fragment.nameOffset;
139139
var nameEnd = fragment.nameEnd;
140140
if (nameOffset != null && nameEnd != null) {
141141
return SourceRange(nameOffset, nameEnd - nameOffset);

pkg/analysis_server/lib/src/computer/computer_inlay_hint.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ class DartInlayHintComputer {
208208
return null;
209209
}
210210
var firstFragment = element.firstFragment;
211-
var nameOffset = firstFragment.nameOffset2;
211+
var nameOffset = firstFragment.nameOffset;
212212
var libraryFragment = firstFragment.libraryFragment;
213213
var path = libraryFragment?.source.fullName;
214214
var lineInfo = libraryFragment?.lineInfo;

pkg/analysis_server/lib/src/computer/computer_lazy_type_hierarchy.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -231,10 +231,10 @@ class TypeHierarchyItem {
231231

232232
// Some non-synthetic items can still have invalid nameOffsets (for example
233233
// a compilation unit). This should never happen here, but guard against it.
234-
assert(fragment.nameOffset2 != -1);
235-
return fragment.nameOffset2 == -1
234+
assert(fragment.nameOffset != -1);
235+
return fragment.nameOffset == -1
236236
? SourceRange(0, 0)
237-
: SourceRange(fragment.nameOffset2 ?? 0, fragment.name?.length ?? 0);
237+
: SourceRange(fragment.nameOffset ?? 0, fragment.name?.length ?? 0);
238238
}
239239
}
240240

pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class ImplementedComputer {
3434

3535
void _addImplementedClass(InterfaceElement element) {
3636
for (var fragment in element.fragments) {
37-
var offset = fragment.nameOffset2;
37+
var offset = fragment.nameOffset;
3838
var name = fragment.name;
3939
if (offset != null && name != null) {
4040
classes.add(protocol.ImplementedClass(offset, name.length));
@@ -44,7 +44,7 @@ class ImplementedComputer {
4444

4545
void _addImplementedMember(Element element) {
4646
for (var fragment in element.fragments) {
47-
var offset = fragment.nameOffset2;
47+
var offset = fragment.nameOffset;
4848
var name = fragment.name;
4949
if (offset != null && name != null) {
5050
members.add(protocol.ImplementedMember(offset, name.length));

pkg/analysis_server/lib/src/lsp/handlers/code_lens/abstract_code_lens_provider.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ abstract class AbstractCodeLensProvider
3333
/// If for any reason the location cannot be computed, returns `null`.
3434
Location? getLocation(Fragment fragment) {
3535
// We can't produce a location to a name if there isn't one.
36-
var nameOffset = fragment.nameOffset2;
36+
var nameOffset = fragment.nameOffset;
3737
var nameLength = fragment.element.displayName.length;
3838
if (nameOffset == null) {
3939
return null;

pkg/analysis_server/lib/src/lsp/handlers/code_lens/augmentations.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ class AugmentationCodeLensProvider extends AbstractCodeLensProvider {
7777
title,
7878
targetFragment,
7979
);
80-
var nameOffset = thisFragment.nameOffset2;
80+
var nameOffset = thisFragment.nameOffset;
8181
var nameLength = thisFragment.element.displayName.length;
8282
if (command != null && nameOffset != null) {
8383
var range = toRange(result.lineInfo, nameOffset, nameLength);

pkg/analysis_server/lib/src/lsp/handlers/handler_implementation.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ class ImplementationHandler
106106
return null;
107107
}
108108

109-
var nameOffset = firstFragment.nameOffset2;
109+
var nameOffset = firstFragment.nameOffset;
110110
var name = firstFragment.name;
111111
if (nameOffset == null || name == null) {
112112
return null;

pkg/analysis_server/lib/src/lsp/handlers/handler_type_definition.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ class TypeDefinitionHandler
122122
return success(_emptyResult);
123123
}
124124

125-
var nameOffset = targetFragment.nameOffset2;
125+
var nameOffset = targetFragment.nameOffset;
126126
var nameLength = targetFragment.name?.length;
127127
if (nameOffset == null || nameLength == null) {
128128
return success(_emptyResult);

pkg/analysis_server/lib/src/lsp/mapping.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -533,10 +533,10 @@ lsp.Location? fragmentToLocation(
533533
:var isSynthetic,
534534
) when isSynthetic) {
535535
var element = fragment.element.nonSynthetic;
536-
nameOffset = element.firstFragment.nameOffset2;
536+
nameOffset = element.firstFragment.nameOffset;
537537
nameLength = element.firstFragment.name?.length;
538538
} else {
539-
nameOffset = fragment.nameOffset2;
539+
nameOffset = fragment.nameOffset;
540540
nameLength = fragment.name?.length;
541541
}
542542

0 commit comments

Comments
 (0)