Remove references to .packages from build scripts.

It's just names and comments, they already used
`package_config.json` as the package configuration.

Change-Id: Icd421ed99079fa9058426e1536565658938252ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/414100
Commit-Queue: Lasse Nielsen <[email protected]>
Reviewed-by: Brian Quinlan <[email protected]>

Author: lrhn

build/dart/dart_action.gni

@@ -179,7 +179,7 @@ template("_prebuilt_tool_action") {
 #    The arguments to pass to the Dart script.
 #
 #  packages (optional):
-#    The un-rebased path to the .packages file.
+#    The un-rebased path to the package_config.json file.
 #
 #  Forwarded to action() with the usual meaning:
 #    depfile
@@ -218,7 +218,7 @@ template("prebuilt_dart_action") {
 #    The arguments to pass to the Dart script.
 #
 #  packages (optional):
-#    The un-rebased path to the .packages file.
+#    The un-rebased path to the package_config.json file.
 #
 #  Forwarded to action() with the usual meaning:
 #    depfile
@@ -292,7 +292,7 @@ template("_built_tool_action") {
 #    The arguments to pass to the Dart script.
 #
 #  packages (optional):
-#    The un-rebased path to the .packages file.
+#    The un-rebased path to the package_config.json file.
 #
 #  Forwarded to action() with the usual meaning:
 #    depfile

runtime/tools/wiki/build/xrefs.py

@@ -7,8 +7,8 @@
 Xref is a reference of form [`symbol`][] or [text][`symbol`], where symbol
 is expected to be one of the following:
 
-   * package:-scheme URI - it will be resolved using .packages file in the
-     root directory
+   * package:-scheme URI - it will be resolved using the
+     .dart_tool/package_config.json file in the root directory
    * file path
    * C++ symbol - will be resolved through xref.json file (see README.md)
 
@@ -85,7 +85,7 @@ def handleMatch(self, m, data):
 
     def _resolve_ref(self, ref: str) -> Optional[str]:
         if ref.startswith('package:'):
-            # Resolve as package uri via .packages.
+            # Resolve as package uri via package_config.json.
             uri = urlparse(ref)
             (package_name, *path_to_file) = uri.path.split('/', 1)
             package_path = self.packages[package_name]

utils/aot_snapshot.gni

@@ -33,10 +33,10 @@ template("aot_snapshot") {
   if (defined(invoker.inputs)) {
     extra_inputs += invoker.inputs
   }
-  if (defined(invoker.dot_packages)) {
-    dot_packages = invoker.dot_packages
+  if (defined(invoker.package_config)) {
+    package_config = invoker.package_config
   } else {
-    dot_packages = rebase_path("$_dart_root/.dart_tool/package_config.json")
+    package_config = rebase_path("$_dart_root/.dart_tool/package_config.json")
   }
   output = "$root_out_dir/$name.snapshot"
   if (defined(invoker.output)) {
@@ -65,7 +65,7 @@ template("aot_snapshot") {
                gen_kernel_kernel,
                platform_dill,
                main_dart,
-               dot_packages,
+               package_config,
              ]
     output = dill
     outputs = [ output ]
@@ -80,7 +80,7 @@ template("aot_snapshot") {
     script = gen_kernel_kernel
 
     args = [
-      "--packages=" + rebase_path(dot_packages, root_build_dir),
+      "--packages=" + rebase_path(package_config, root_build_dir),
       "--platform=" + rebase_path(platform_dill, root_build_dir),
       "--aot",
       "--output=" + rebase_path(output, root_build_dir),

utils/application_snapshot.gni

@@ -46,8 +46,9 @@ declare_args() {
 #  extra_inputs (optional):
 #    Any extra build inputs.
 #
-#  dot_packages (optional):
-#    The .packages file for the app. Defaults to the $_dart_root/.packages.
+#  package_config (optional):
+#    The package_config.json file for the app.
+#    Defaults to the $_dart_root/.dart_tool/package_config.json file.
 #
 #  output (optional):
 #    Overrides the full output path.
@@ -101,10 +102,10 @@ template("application_snapshot") {
   if (defined(invoker.inputs)) {
     extra_inputs += invoker.inputs
   }
-  if (defined(invoker.dot_packages)) {
-    dot_packages = invoker.dot_packages
+  if (defined(invoker.package_config)) {
+    package_config = invoker.package_config
   } else {
-    dot_packages = rebase_path("$_dart_root/.dart_tool/package_config.json")
+    package_config = rebase_path("$_dart_root/.dart_tool/package_config.json")
   }
   output = "$root_gen_dir/$name.dart.snapshot"
   if (defined(invoker.output)) {
@@ -136,7 +137,7 @@ template("application_snapshot") {
                gen_kernel_kernel,
                platform_dill,
                main_dart,
-               dot_packages,
+               package_config,
              ]
     output = "$target_gen_dir/$name.dart.dill"
     outputs = [ output ]
@@ -152,7 +153,7 @@ template("application_snapshot") {
     is_product_flag = dart_runtime_mode == "release"
 
     args = [
-      "--packages=" + rebase_path(dot_packages, root_build_dir),
+      "--packages=" + rebase_path(package_config, root_build_dir),
       "--platform=" + rebase_path(platform_dill, root_build_dir),
       "--no-aot",
       "--no-embed-sources",
@@ -204,7 +205,7 @@ template("application_snapshot") {
 
       vm_args = [
                   "--deterministic",
-                  "--packages=" + rebase_path(dot_packages, root_build_dir),
+                  "--packages=" + rebase_path(package_config, root_build_dir),
                   "--snapshot=" + rebase_path(output, root_build_dir),
                   "--snapshot-depfile=" + rebase_path(depfile, root_build_dir),
                 ] + snapshot_vm_args

utils/gen_kernel/BUILD.gn

@@ -15,12 +15,12 @@ prebuilt_dart_action("bootstrap_gen_kernel") {
   ]
   gen_kernel_script = "$_dart_root/pkg/vm/bin/gen_kernel.dart"
   platform_dill = "$root_out_dir/vm_platform_strong.dill"
-  dot_packages = rebase_path("$_dart_root/.dart_tool/package_config.json")
+  package_config = rebase_path("$_dart_root/.dart_tool/package_config.json")
 
   inputs = [
     gen_kernel_script,
     platform_dill,
-    dot_packages,
+    package_config,
   ]
   output = "$target_gen_dir/bootstrap_gen_kernel.dill"
   outputs = [ output ]
@@ -34,7 +34,7 @@ prebuilt_dart_action("bootstrap_gen_kernel") {
     # Ensure gen_kernel.dart will use this SDK hash when consuming/producing kernel.
     "-Dsdk_hash=$sdk_hash",
 
-    "--packages=" + rebase_path(dot_packages, root_build_dir),
+    "--packages=" + rebase_path(package_config, root_build_dir),
   ]
   script = gen_kernel_script
   args = []